fixed a bug if the user exists and then is changed to jailkit

server/plugins-available/shelluser_jailkit_plugin.inc.php

@@ -226,8 +226,10 @@ class shelluser_jailkit_plugin {
 			$jailkit_chroot_userhome = $this->_get_home_dir($this->data['new']['username']);
 			$jailkit_chroot_puserhome = $this->_get_home_dir($this->data['new']['puser']);
 			
-			if (!is_dir($this->data['new']['dir'].$jailkit_chroot_userhome))
-			{
+			// IMPORTANT!
+			// ALWAYS create the user. Even if the user was created before
+			// if we check if the user exists, then a update (no shell -> jailkit) will not work
+			// and the user has FULL ACCESS to the root of the server!
 			$command = '/usr/local/ispconfig/server/scripts/create_jailkit_user.sh';
 			$command .= ' '.escapeshellcmd($this->data['new']['username']);
 			$command .= ' '.escapeshellcmd($this->data['new']['dir']);
@@ -248,8 +250,6 @@ class shelluser_jailkit_plugin {
 			exec("chown ".$this->data['new']['puser'].":".$this->data['new']['pgroup']." ".escapeshellcmd($this->data['new']['dir'].$jailkit_chroot_puserhome));
 				
 			$this->app->log("Added created jailkit parent user home in : ".$this->data['new']['dir'].$jailkit_chroot_puserhome,LOGLEVEL_DEBUG);
-				
-			}	
 	}