From 5ab1840750b0dc858930c2e7da7d39ac7dd27965 Mon Sep 17 00:00:00 2001
From: Jesse Norell <jesse@kci.net>
Date: Mon, 19 Oct 2020 09:09:46 -0600
Subject: [PATCH] log if web folder is skipped for update/delete
---
server/lib/classes/system.inc.php | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/server/lib/classes/system.inc.php b/server/lib/classes/system.inc.php
index 697c925d18..20bdd08bc7 100644
--- a/server/lib/classes/system.inc.php
+++ b/server/lib/classes/system.inc.php
@@ -2523,6 +2523,10 @@ $app->log("update_jailkit_chroot called for $home_dir with options ".print_r($op
break;
default:
if (preg_match('@^skip[ =]/?(.+)$@', $opt, $matches) ) {
+ if (in_array($matches[1], $jailkit_directories)) {
+ $app->log("update_jailkit_chroot: skipping update of jailkit directory $home_dir/".$matches[1]
+ . "; if this is in use as a web folder, it is insecure and should be fixed.", LOGLEVEL_WARN);
+ }
$jailkit_directories = $app->functions->array_unset_by_value($jailkit_directories, $matches[1]);
$skips .= ' --skip=/'.escapeshellarg($matches[1]);
}
@@ -2740,6 +2744,10 @@ $app->log("delete_jailkit_chroot called for $home_dir with options ".print_r($op
switch ($opt) {
default:
if (preg_match('@^skip[ =]/?(.+)$@', $opt, $matches) ) {
+ if (in_array($matches[1], $jailkit_directories)) {
+ $app->log("delete_jailkit_chroot: skipping removal of jailkit directory .$home_dir/".$matches[1]
+ . "; if this is in use as a web folder, it is insecure and should be fixed.", LOGLEVEL_WARN);
+ }
$jailkit_directories = $app->functions->array_unset_by_value($jailkit_directories, $matches[1]);
}
break;
--
GitLab