diff --git a/interface/web/dns/dns_dkim_edit.php b/interface/web/dns/dns_dkim_edit.php index 6bc3086d068500f95df5cb4d01a8211d30af1fa0..1735473a04aefed768b991beb1a2569173d0a08d 100644 --- a/interface/web/dns/dns_dkim_edit.php +++ b/interface/web/dns/dns_dkim_edit.php @@ -97,7 +97,7 @@ class page_action extends tform_actions { $this->dataRecord["server_id"] = $soa["server_id"]; // add dkim-settings to the public-key in the txt-record - $this->dataRecord['data']='v=DKIM1; t=s; p='.$this->dataRecord['data']; + if (!empty($this->dataRecord['data'])) $this->dataRecord['data']='v=DKIM1; t=s; p='.$this->dataRecord['data']; $this->dataRecord['name']='default._domainkey.'.$this->dataRecord['name']; // Update the serial number and timestamp of the RR record @@ -108,7 +108,7 @@ class page_action extends tform_actions { // check for duplicate entry $check=$app->db->queryOneRecord("SELECT * FROM dns_rr WHERE zone = ".$this->dataRecord["zone"]." AND type = '".$this->dataRecord["type"]."' AND data ='".$this->dataRecord["data"]."' AND name = '".$this->dataRecord['name']."'"); if ($check!='') $app->tform->errorMessage .= $app->tform->wordbook["record_exists_txt"]; - + if (empty($this->dataRecord['data'])) $app->tform->errorMessage .= $app->tform->wordbook["dkim_disabled_txt"]; parent::onSubmit(); } diff --git a/interface/web/dns/dns_dkim_get.php b/interface/web/dns/dns_dkim_get.php index 6c58d4078f0b25f4f5a9824e51e533ed7aeaa9ab..157f894fe4e8d672f19106e15ca1187a9aee6a06 100644 --- a/interface/web/dns/dns_dkim_get.php +++ b/interface/web/dns/dns_dkim_get.php @@ -1,42 +1,42 @@ <?php /** - Copyright (c) 2007 - 2013, Till Brehm, projektfarm Gmbh - Copyright (c) 2013, Florian Schaal, info@schaal-24.de - All rights reserved. - - Redistribution and use in source and binary forms, with or without modification, - are permitted provided that the following conditions are met: - - * Redistributions of source code must retain the above copyright notice, - this list of conditions and the following disclaimer. - * Redistributions in binary form must reproduce the above copyright notice, - this list of conditions and the following disclaimer in the documentation - and/or other materials provided with the distribution. - * Neither the name of ISPConfig nor the names of its contributors - may be used to endorse or promote products derived from this software without - specific prior written permission. - - THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. - IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, - INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY - OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING - NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, - EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - +Copyright (c) 2007 - 2013, Till Brehm, projektfarm Gmbh +Copyright (c) 2013, Florian Schaal, info@schaal-24.de +All rights reserved. + +Redistribution and use in source and binary forms, with or without modification, +are permitted provided that the following conditions are met: + + * Redistributions of source code must retain the above copyright notice, + this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. + * Neither the name of ISPConfig nor the names of its contributors + may be used to endorse or promote products derived from this software without + specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. +IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, +INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, +BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY +OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING +NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, +EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +*/ /** - * This script is invoked by interface/web/dns/templates/dns_dkim_edit.htm - * when generating the DKIM Private-key. - * - * return DKIM Public-Key for the DNS-record - */ -require_once '../../lib/config.inc.php'; -require_once '../../lib/app.inc.php'; +* This script is invoked by interface/web/dns/templates/dns_dkim_edit.htm +* when generating the DKIM Private-key. +* +* return DKIM Public-Key for the DNS-record +*/ + +require_once('../../lib/config.inc.php'); +require_once('../../lib/app.inc.php'); //* Check permissions for module $app->auth->check_module_permissions('dns'); @@ -49,34 +49,33 @@ $app->uses('tform,tform_actions'); header('Content-Type: text/xml; charset=utf-8'); header('Cache-Control: must-revalidate, pre-check=0, no-store, no-cache, max-age=0, post-check=0'); - /** - * This function fix PHP's messing up POST input containing characters space, dot, - * open square bracket and others to be compatible with with the deprecated register_globals - * @return array POST - */ +* This function fix PHP's messing up POST input containing characters space, dot, +* open square bracket and others to be compatible with with the deprecated register_globals +* @return array POST +*/ + function getRealPOST() { - $pairs = explode("&", file_get_contents("php://input")); - $vars = array(); - foreach ($pairs as $pair) { - $nv = explode("=", $pair, 2); - $name = urldecode($nv[0]); - $value = $nv[1]; - $vars[$name] = $value; - } - return $vars; + $pairs = explode("&", file_get_contents("php://input")); + $vars = array(); + foreach ($pairs as $pair) { + $nv = explode("=", $pair, 2); + $name = urldecode($nv[0]); + $value = $nv[1]; + $vars[$name] = $value; + } + return $vars; } - /** - * This function formats the public-key - * @param array $pubkey - * @return string public-key - */ +* This function formats the public-key +* @param array $pubkey +* @return string public-key +*/ function pub_key($pubkey) { - $public_key=''; - foreach($pubkey as $values) $public_key=$public_key.$values; - return $public_key; + $public_key=''; + foreach($pubkey as $values) $public_key=$public_key.$values; + return $public_key; } $_POST=getRealPost(); @@ -85,11 +84,11 @@ if (ctype_digit($_POST['zone'])) { // Get the parent soa record of the domain $soa = $app->db->queryOneRecord("SELECT * FROM dns_soa WHERE id = '".$app->db->quote($_POST['zone'])."' AND ".$app->tform->getAuthSQL('r')); - $public_key=$app->db->queryOneRecord("SELECT dkim_public FROM mail_domain WHERE domain = '".substr_replace($soa['origin'], '', -1)."' AND ".$app->tform->getAuthSQL('r')); + $public_key=$app->db->queryOneRecord("SELECT dkim_public FROM mail_domain WHERE domain = '".substr_replace($soa['origin'],'',-1)."' AND dkim = 'Y' AND ".$app->tform->getAuthSQL('r')); $public_key=pub_key($public_key); - $public_key=str_replace(array('-----BEGIN PUBLIC KEY-----', '-----END PUBLIC KEY-----', "\r", "\n"), '', $public_key); + $public_key=str_replace(array('-----BEGIN PUBLIC KEY-----','-----END PUBLIC KEY-----',"\r","\n"),'',$public_key); echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n"; echo "<formatname>\n"; diff --git a/interface/web/dns/dns_wizard.php b/interface/web/dns/dns_wizard.php index 61611ab70a88e0a8b6641e900c388e89519f8a76..ce36f70aa3f1a5d35c72211da2d3b023e4b21d3b 100644 --- a/interface/web/dns/dns_wizard.php +++ b/interface/web/dns/dns_wizard.php @@ -245,7 +245,7 @@ if($_POST['create'] == 1) { $public_key=$app->db->queryOneRecord("SELECT dkim_public FROM mail_domain WHERE domain = '".$app->db->quote($_POST['domain'])."' AND dkim = 'y' AND ".$app->tform->getAuthSQL('r')); if ($public_key!='') { $dns_record=str_replace(array("\r\n", "\n", "\r", "-----BEGIN PUBLIC KEY-----", "-----END PUBLIC KEY-----"), '', $public_key['dkim_public']); - $tpl_content = str_replace('{DKIM}', 'TXT|default._domainkey.'.$_POST['domain'].'.|v=DKIM1; t=s; p='.$dns_record, $tpl_content); + $tpl_content = str_replace('TXT|'.$_POST['domain'].'.|{DKIM}', 'TXT|default._domainkey.'.$_POST['domain'].'.|v=DKIM1; t=s; p='.$dns_record, $tpl_content); } } @@ -348,4 +348,4 @@ $app->tpl_defaults(); $app->tpl->pparse(); -?> \ No newline at end of file +?> diff --git a/interface/web/dns/form/dns_template.tform.php b/interface/web/dns/form/dns_template.tform.php index e209153f747fc6b86042ba97f24476abba11e775..4285e41e9947ab87b4de80220ef396cddc8a0248 100644 --- a/interface/web/dns/form/dns_template.tform.php +++ b/interface/web/dns/form/dns_template.tform.php @@ -74,7 +74,7 @@ $form["tabs"]['template'] = array ( 'formtype' => 'CHECKBOXARRAY', 'default' => '', 'separator' => ',', - 'value' => array('DOMAIN' => 'Domain', 'IP' => 'IP Address', 'NS1' => 'NS 1', 'NS2' => 'NS 2', 'EMAIL' => 'Email', 'DKIM' => 'DKIM (use {DKIM}|0|3600 in your Template)'), + 'value' => array('DOMAIN' => 'Domain', 'IP' => 'IP Address', 'NS1' => 'NS 1', 'NS2' => 'NS 2', 'EMAIL' => 'Email', 'DKIM' => 'DKIM (use TXT|{DOMAIN}.|{DKIM} in your Template)'), 'validators' => array ( 0 => array ('type' => 'CUSTOM', 'class' => 'validate_dkim', 'function' => 'check_template', diff --git a/interface/web/dns/lib/lang/de_dns_dkim.lng b/interface/web/dns/lib/lang/de_dns_dkim.lng index 97f04b7f7f2662a6a2a0354ba1dfe23e9fc88139..550239de1261fa869ea79647dd8b86269e72205a 100644 --- a/interface/web/dns/lib/lang/de_dns_dkim.lng +++ b/interface/web/dns/lib/lang/de_dns_dkim.lng @@ -3,6 +3,7 @@ $wb["public_key_txt"] = 'Public-Key'; $wb["ttl_txt"] = 'TTL'; $wb["active_txt"] = 'Aktiv'; $wb["record_exists_txt"] = 'DNS-Eintrag bereits vorhanden'; +$wb["dkim_disabled_txt"] = 'DKIM st fuer diese Domain nicht aktiv.'; $wb["limit_dns_record_txt"] = 'Die max. Anzahl von DNS Eintraegen fuer den Account ist erreicht.'; $wb["no_zone_perm"] = 'Fehlende Berechtigung zum Hinzufuegen eines Eintrags zur DNS-Zone.'; ?> diff --git a/interface/web/dns/lib/lang/en_dns_dkim.lng b/interface/web/dns/lib/lang/en_dns_dkim.lng index dabee2bd11d864e6b1a5cc8136c64d5bc49fd02a..c24d401c979e3e29d91e501ba99c1165ac733c70 100644 --- a/interface/web/dns/lib/lang/en_dns_dkim.lng +++ b/interface/web/dns/lib/lang/en_dns_dkim.lng @@ -3,6 +3,7 @@ $wb["public_key_txt"] = 'Public-Key'; $wb["ttl_txt"] = 'TTL'; $wb["active_txt"] = 'Active'; $wb["record_exists_txt"] = 'DNS-Record already exists'; +$wb["dkim_disabled_txt"] = 'DKIM disabled for this mail-domain'; $wb["limit_dns_record_txt"] = 'The max. number of DNS records for your account is reached.'; $wb["no_zone_perm"] = 'You do not have the permission to add a record to this DNS zone.'; ?>