diff --git a/interface/web/tools/resync_do.php b/interface/web/tools/resync_do.php index 62d02e06dfa9b54945568d7aaf667e41f38ce70c..08157376f63d01dbaadb085e9f940d0f952c2c88 100644 --- a/interface/web/tools/resync_do.php +++ b/interface/web/tools/resync_do.php @@ -244,7 +244,7 @@ class page_action extends tform_actions { $index_field = 'mailuser_id'; $server_type = 'mail'; $server_id = $app->functions->intval($this->dataRecord['mailbox_server_id']); - if ($server_id == -1) $tmp = query_server($db_table, $server_id, $server_type, 'WHERE 1', false); else $tmp = query_server($db_table, $server_id, $server_type); + if ($server_id == -1) $tmp = query_server($db_table, $server_id, $server_type, 'WHERE 1', false); else $tmp = query_server($db_table, $server_id, $server_type, 'WHERE 1'); $records = $tmp[0]; $server_name = $tmp[1]; unset($tmp); diff --git a/server/plugins-available/mail_plugin_dkim.inc.php b/server/plugins-available/mail_plugin_dkim.inc.php index 3a451d37d5fb496b97ed65aebb0e6994893e5d46..3e00ada4a99906ded7986f74a1869a82657c6f8b 100755 --- a/server/plugins-available/mail_plugin_dkim.inc.php +++ b/server/plugins-available/mail_plugin_dkim.inc.php @@ -117,14 +117,14 @@ class mail_plugin_dkim { $app->log('Amavis-config not found or not writeable.', LOGLEVEL_ERROR); $check=false; } + /* dir for dkim-keys writeable? */ $mail_config = $app->getconf->get_server_config($conf['server_id'], 'mail'); if ( isset($mail_config['dkim_path']) && !empty($mail_config['dkim_path']) && isset($data['new']['dkim_private']) && !empty($data['new']['dkim_private']) && - $mail_config['dkim_path'] != '/' && - $app->system->checkpath($mail_config['dkim_path']) + $mail_config['dkim_path'] != '/' ) { if (!is_dir($mail_config['dkim_path'])) { $app->log('DKIM Path '.$mail_config['dkim_path'].' not found - (re)created.', LOGLEVEL_DEBUG); @@ -150,6 +150,11 @@ class mail_plugin_dkim { $check=false; } + if ( !$app->system->checkpath($mail_config['dkim_path']) ) { + $app->log('DKIM Path '.$mail_config['dkim_path'].' failed in checkpath.', LOGLEVEL_ERROR); + $check = false; + } + } else { $app->log('Unable to write DKIM settings - no or invalid DKIM-Path defined', LOGLEVEL_ERROR); $check=false; @@ -184,7 +189,7 @@ class mail_plugin_dkim { * @param string $key_file full path to the key-file * @param string $key_value private-key * @param string $key_domain mail-domain - * @return bool - true when the key is written to disk + * @return bool - true when the private key was written to disk */ function write_dkim_key($key_file, $key_value, $key_domain) { global $app, $mailconfig;