From d12a7064ea342fa8de768d764b32aa7cda302873 Mon Sep 17 00:00:00 2001
From: Jesse Norell <jesse@kci.net>
Date: Mon, 31 Aug 2020 14:32:41 -0600
Subject: [PATCH] changes from review feedback
---
interface/lib/plugins/mail_user_filter_plugin.inc.php | 3 +--
security/ids.whitelist | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/interface/lib/plugins/mail_user_filter_plugin.inc.php b/interface/lib/plugins/mail_user_filter_plugin.inc.php
index 45c32179f6..4f24042b30 100644
--- a/interface/lib/plugins/mail_user_filter_plugin.inc.php
+++ b/interface/lib/plugins/mail_user_filter_plugin.inc.php
@@ -139,8 +139,7 @@ class mail_user_filter_plugin {
if($page_form->dataRecord["source"] == 'Header') {
$parts = explode(':',trim($page_form->dataRecord["searchterm"]));
- $page_form->dataRecord["source"] = trim($parts[0]);
- unset($parts[0]);
+ $page_form->dataRecord["source"] = trim(array_shift($parts));
$page_form->dataRecord["searchterm"] = trim(implode(':',$parts));
unset($parts);
}
diff --git a/security/ids.whitelist b/security/ids.whitelist
index ab7ee504a3..d9b0ba70b5 100644
--- a/security/ids.whitelist
+++ b/security/ids.whitelist
@@ -55,7 +55,6 @@ user:/login/index.php:POST.password
user:/mail/mail_domain_edit.php:POST.dkim_private
user:/mail/mail_domain_edit.php:POST.dkim_public
user:/mail/mail_domain_edit.php:POST.dns_record
-user:/sites/web_vhost_domain_edit.php:POST.fastcgi_php_version
admin:/mail/mail_user_filter_edit.php:POST.searchterm
user:/mail/mail_user_filter_edit.php:POST.searchterm
admin:/mail/mail_user_edit.php:POST.custom_mailfilter
--
GitLab