From a86b05a02215bb7b17857635e8bdd93a24eb465a Mon Sep 17 00:00:00 2001
From: Herman van Rink <rink@initfour.nl>
Date: Mon, 15 Apr 2024 23:46:43 +0200
Subject: [PATCH] Update the serial after the actual insert, #6690

---
 interface/lib/classes/remote.d/dns.inc.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/interface/lib/classes/remote.d/dns.inc.php b/interface/lib/classes/remote.d/dns.inc.php
index c9a5031f0e..d1bdfc7995 100644
--- a/interface/lib/classes/remote.d/dns.inc.php
+++ b/interface/lib/classes/remote.d/dns.inc.php
@@ -218,10 +218,11 @@ class remoting_dns extends remoting {
 		if(!$this->checkPerm($session_id, 'dns_' . $rr_type . '_add')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 		}
+		$primary_id = $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);
 		if($update_serial) {
 			$this->increase_serial($session_id, $client_id, $params);
 		}
-		return $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);
+		return $primary_id;
 	}
 
 	//* Update a record
-- 
GitLab