ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2023-03-09T10:04:03Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6434Vim insertmode i left behind2023-03-09T10:04:03ZHelmoVim insertmode i left behindI found an extra `i` chacter in interface/web/mail/templates/mail_user_mailbox_edit.htm, added by me in !1543
![image](/uploads/f5a34497de5cbb62a19c0935256681d4/image.png)I found an extra `i` chacter in interface/web/mail/templates/mail_user_mailbox_edit.htm, added by me in !1543
![image](/uploads/f5a34497de5cbb62a19c0935256681d4/image.png)3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6433Safedelete warning when dir does not exist2023-03-06T21:44:41ZHelmoSafedelete warning when dir does not exist
The code from !1454 needs an extra check to see if the maildomain directory actually exists.
`mv: cannot stat '/var/vmail/example.com': No such file or directory`
Patch comming...
The code from !1454 needs an extra check to see if the maildomain directory actually exists.
`mv: cannot stat '/var/vmail/example.com': No such file or directory`
Patch comming...3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6432Rspamd: SQL error after server settings update2023-04-01T21:20:09ZDaniel JagszentRspamd: SQL error after server settings update
## Summary
SQL Error when Rspamd plugin handles server table updates.
## Steps to reproduce
1. Have an ISPConfig with Mail&RSpamd configured
2. Go to the server settings (System -> Server Config -> server name)
3. Change anything and s...
## Summary
SQL Error when Rspamd plugin handles server table updates.
## Steps to reproduce
1. Have an ISPConfig with Mail&RSpamd configured
2. Go to the server settings (System -> Server Config -> server name)
3. Change anything and save
4. Wait for the datalog to be processed
5. You will get an email with
```
ispconfig.server - 19.12.2022-20:58 - WARNING - Falsche Anfrage / Wrong QuerySQL-Query = SELECT `ip_address`, `ip_type` FROM .server_ip WHERE `server_id` = 1 -> 1064 (You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '.server_ip WHERE `server_id` = 1' at line 1)
```
## Correct behaviour
No SQL error.
## Environment
Server OS + version: Ubuntu 20.04
ISPConfig version: 3.2.9 / develop
Software version of the related software (Rspamd): 3.4-1~focal3.2.10ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6431Rspamd User Config deleted on mail user changes2023-04-14T12:22:42ZDimitriRspamd User Config deleted on mail user changesFor some long time I noticed, that spam filter settings are sometimes not being applied properly and these days I took a look into it.
So what I found was, that ISPConfig was dropping existing `/etc/rspamd/local.d/users/user_domain_tld.c...For some long time I noticed, that spam filter settings are sometimes not being applied properly and these days I took a look into it.
So what I found was, that ISPConfig was dropping existing `/etc/rspamd/local.d/users/user_domain_tld.conf` files when something was changed in for the mail user.
**Steps to reproduce**
- Create a mail account and set a spam filter for it (the `normal` one will do it).
- The config file in `/etc/rspamd/local.d/users/user_domain_tld.conf` should now exist.
- Now change something for the mail account
- The file should be deleted
- In order to get ISPConfig to write the config file again, just change something that triggers `spamfilter_user` in `user_settings_update()` function in the rspamd plugin.
I was able to fix this `quick and dirty` for myself by adding `&& $type == 'spamfilter_user'` to the if in [rspamd_plugin.inc.php#L284](https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/server/plugins-available/rspamd_plugin.inc.php#L284)
My Setup:
- Ubuntu 22.04
- php 7.4.33
- rspamd 3.2-1~bionic3.2.10DimitriDimitrihttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6430PHP8: Unable to add database on multiserver setup withs eparate DB server2022-12-16T17:50:55ZTill BrehmPHP8: Unable to add database on multiserver setup withs eparate DB serverError message:
```
[Fri Dec 16 15:18:06.151694 2022] [fcgid:warn] [pid 1039:tid 139904281384512] [client xxx:59996] mod_fcgid: stderr: PHP Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null ...Error message:
```
[Fri Dec 16 15:18:06.151694 2022] [fcgid:warn] [pid 1039:tid 139904281384512] [client xxx:59996] mod_fcgid: stderr: PHP Fatal error: Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /usr/local/ispconfig/interface/web/sites/database_edit.php:462, referer: https://xxx:8080/index.php
```3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6428Postfix advertises SMTPUTF8 but local LMTP delivery fails because dovecot doe...2023-04-30T19:03:20ZJudah - MWPostfix advertises SMTPUTF8 but local LMTP delivery fails because dovecot does not support it## Summary
Postfix has SMTPUTF8 support enabled by default. External mailservers can take advantage of this to try to deliver UTF8 encoded messages. However when postfix attempts local delivery of such a message to Dovecot using LMTP i...## Summary
Postfix has SMTPUTF8 support enabled by default. External mailservers can take advantage of this to try to deliver UTF8 encoded messages. However when postfix attempts local delivery of such a message to Dovecot using LMTP it bounces because Dovecot does not have SMTPUTF8 support.
## Steps to reproduce
1. Send a message to a valid email address on ISPConfig with non-ASCII chars in the localpart - the easiest way is send to a catchall or to use a plus address e.g.: `user+tést@example.com`. Please note this is simply the easiest way to reproduce this error, but some mailservers may use SMTPUTF8 if there is any non-ASCII text in the entire message.
2. Check the logs or bounce DSN for the message: `SMTPUTF8 is required, but was not offered by host mail.example.com[private/dovecot-lmtp]`
## Correct behaviour
Postfix should not advertise SMTPUTF8 until Dovecot supports it.
```
$ telnet mail.example.com 25
Trying ::1...
Connected to localhost.
Escape character is '^]'.
220 mail.example.com ESMTP Postfix
EHLO user.example.com
250-mail.example.com
250-PIPELINING
250-VRFY
250-ETRN
250-STARTTLS
250-AUTH PLAIN LOGIN
250-AUTH=PLAIN LOGIN
250-ENHANCEDSTATUSCODES
250-8BITMIME
250-DSN
250-SMTPUTF8 <-- Disable this
250 CHUNKING
QUIT
221 2.0.0 Bye
Connection closed by foreign host.
```
## Environment
- Server OS + version: CentOS 8.7
- ISPConfig version: 3.2.8
- Postfix version: 3.7.3
- Dovecot version: 2.3.16
## Proposed fix
Disable SMTPUTF8 in postfix main.cf:
```
smtputf8_enable = no
```
## References
Good starting place: https://unix.stackexchange.com/questions/320091/configure-postfix-and-dovecot-lmtp-to-receive-mail-via-smtputf8
Postfix documentation: https://www.postfix.org/SMTPUTF8_README.html
## Log lines
```
dovecot[]: quota-status(): Error: Client sent invalid recipient address `user+tést@example.com': Invalid character in localpart
postfix/lmtp[]: to=<user+tést@example.com>, relay=mail.example.com[private/dovecot-lmtp], delay=0.03, delays=0.02/0/0/0, dsn=5.6.7, status=bounced (SMTPUTF8 is required, but was not offered by host mail.example.com[private/dovecot-lmtp])
```3.2.10ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6424Notifications to reseller and clients not working2023-04-14T12:24:23ZKrzysztof BaranowskiNotifications to reseller and clients not workingRelated to issue #6347 but fix 4d5369ae broke notifications for users and resellers.Related to issue #6347 but fix 4d5369ae broke notifications for users and resellers.3.2.10Krzysztof BaranowskiKrzysztof Baranowskihttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6416Undefined constant "LOGLEVEL_WARNING" in /usr/local/ispconfig/server/plugins-...2023-04-14T12:26:38ZTill BrehmUndefined constant "LOGLEVEL_WARNING" in /usr/local/ispconfig/server/plugins-available/mysql_clientdb_plugin.inc.php:283```
26.11.2022-12:04 - WARNING - There is already a lockfile set, but no process running with this pid (453515). Continuing.
PHP Fatal error: Uncaught Error: Undefined constant "LOGLEVEL_WARNING" in /usr/local/ispconfig/server/plugins-av...```
26.11.2022-12:04 - WARNING - There is already a lockfile set, but no process running with this pid (453515). Continuing.
PHP Fatal error: Uncaught Error: Undefined constant "LOGLEVEL_WARNING" in /usr/local/ispconfig/server/plugins-available/mysql_clientdb_plugin.inc.php:283
Stack trace:
#0 /usr/local/ispconfig/server/lib/classes/plugins.inc.php(120): mysql_clientdb_plugin->db_insert()
#1 /usr/local/ispconfig/server/mods-available/database_module.inc.php(98): plugins->raiseEvent()
#2 /usr/local/ispconfig/server/lib/classes/modules.inc.php(302): database_module->process()
#3 /usr/local/ispconfig/server/lib/classes/modules.inc.php(235): modules->raiseTableHook()
#4 /usr/local/ispconfig/server/server.php(180): modules->processDatalog()
#5 {main}
thrown in /usr/local/ispconfig/server/plugins-available/mysql_clientdb_plugin.inc.php on line 283
```3.2.10Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6406Undefined variable $conf with php 82022-11-05T08:26:29ZHelmoUndefined variable $conf with php 8During an update testrun ...
```
PHP Warning: Undefined variable $conf in /tmp/update_runner.sh.MBtkgvU64J/install/lib/installer_base.lib.php on line 251
PHP Warning: Trying to access array offset on value of type null in /tmp/update_...During an update testrun ...
```
PHP Warning: Undefined variable $conf in /tmp/update_runner.sh.MBtkgvU64J/install/lib/installer_base.lib.php on line 251
PHP Warning: Trying to access array offset on value of type null in /tmp/update_runner.sh.MBtkgvU64J/install/lib/installer_base.lib.php on line 251
```3.2.9HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6405Undefined variable $postfix_version with php 82022-11-05T08:27:48ZHelmoUndefined variable $postfix_version with php 8During an update testrun ...
```
PHP Warning: Undefined variable $postfix_version in /tmp/update_runner.sh.MBtkgvU64J/install/lib/installer_base.lib.php on line 1731
```During an update testrun ...
```
PHP Warning: Undefined variable $postfix_version in /tmp/update_runner.sh.MBtkgvU64J/install/lib/installer_base.lib.php on line 1731
```3.2.9HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6400PHP warnings & errors for 3.2.92022-11-07T16:12:52ZMichaelPHP warnings & errors for 3.2.9While testing 3.2.9 develop on AlmaLinux 9 (PHP 8.0.13) the following warnings and error occurs (branched from 39bf4b24):
```
PHP Warning: Undefined array key "xmpp" in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 365
P...While testing 3.2.9 develop on AlmaLinux 9 (PHP 8.0.13) the following warnings and error occurs (branched from 39bf4b24):
```
PHP Warning: Undefined array key "xmpp" in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 365
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 365
PHP Warning: Undefined array key "ufw" in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 366
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 366
PHP Warning: Undefined variable $firewall_server_enabled in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 372
PHP Warning: Undefined variable $xmpp_server_enabled in /tmp/ispconfig3-6373-el9x-support/install/update.php on line 372
PHP Warning: Undefined array key "ufw" in /tmp/ispconfig3-6373-el9x-support/install/lib/installer_base.lib.php on line 400
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/lib/installer_base.lib.php on line 400
PHP Warning: Undefined array key "postgrey" in /tmp/ispconfig3-6373-el9x-support/install/lib/installer_base.lib.php on line 1139
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/lib/installer_base.lib.php on line 1139
See "systemctl status amavisd.service" and "journalctl -xeu amavisd.service" for details.
PHP Warning: Undefined array key "ufw" in /tmp/ispconfig3-6373-el9x-support/install/install.php on line 664
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/install.php on line 664
PHP Warning: Undefined array key "xmpp" in /tmp/ispconfig3-6373-el9x-support/install/install.php on line 665
PHP Warning: Trying to access array offset on value of type null in /tmp/ispconfig3-6373-el9x-support/install/install.php on line 665
Mi 26. Okt 16:00:02 CEST 2022 PHP Fatal error: Uncaught TypeError: mktime(): Argument #6 ($year) must be of type ?int, string given in /usr/local/ispconfig/server/lib/classes/cron.inc.php:246
Mi 26. Okt 16:00:02 CEST 2022 Stack trace:
Mi 26. Okt 16:00:02 CEST 2022 #0 /usr/local/ispconfig/server/lib/classes/cron.inc.php(246): mktime()
Mi 26. Okt 16:00:02 CEST 2022 #1 /usr/local/ispconfig/server/lib/classes/cronjob.inc.php(124): cron->getNextRun()
Mi 26. Okt 16:00:02 CEST 2022 #2 /usr/local/ispconfig/server/lib/classes/cron.d/100-mailbox_stats.inc.php(43): cronjob->onPrepare()
Mi 26. Okt 16:00:02 CEST 2022 #3 /usr/local/ispconfig/server/lib/classes/cronjob.inc.php(87): cronjob_mailbox_stats->onPrepare()
Mi 26. Okt 16:00:02 CEST 2022 #4 /usr/local/ispconfig/server/cron.php(116): cronjob->run()
Mi 26. Okt 16:00:02 CEST 2022 #5 {main}
Mi 26. Okt 16:00:02 CEST 2022 thrown in /usr/local/ispconfig/server/lib/classes/cron.inc.php on line 246
```3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6398PHP warnings in Installer on PHP 8.12022-10-24T16:18:54ZTill BrehmPHP warnings in Installer on PHP 8.1Warnings during installation:
```
PHP Warning: Undefined variable $config_dir in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 2190
PHP Warning: Undefined array key "master_port" in /tmp/ispconfig3_install/install...Warnings during installation:
```
PHP Warning: Undefined variable $config_dir in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 2190
PHP Warning: Undefined array key "master_port" in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 3381
PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 3381
PHP Warning: Undefined array key "master_port" in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 3408
PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /tmp/ispconfig3_install/install/lib/installer_base.lib.php on line 3408
```3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6389Mail filter not configured correctly2023-05-03T13:31:52ZThomMail filter not configured correctlyThe mailfilter is not configured correctly on install when using Rspamd, as the mail_filter variable is set incorrectly in the installer code. When updating it corrects itself, but after initial install it leaves users with a non working...The mailfilter is not configured correctly on install when using Rspamd, as the mail_filter variable is set incorrectly in the installer code. When updating it corrects itself, but after initial install it leaves users with a non working system.
See https://git.ispconfig.org/ispconfig/ispconfig-autoinstaller/-/issues/78 as well.3.2.8p2ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6386Stats for vhost alias/subdomain dont work2023-05-03T13:34:32ZWHOStats for vhost alias/subdomain dont work## Summary
If statistics are set for vhost alias or vhost subdomain, access will give an internal server error.
For vhost alias and vhost subdmain the stats older will be created in $web_folder folder (good)
But the htpasswd file is alw...## Summary
If statistics are set for vhost alias or vhost subdomain, access will give an internal server error.
For vhost alias and vhost subdmain the stats older will be created in $web_folder folder (good)
But the htpasswd file is always created under /web/stats/. There is no stats folder there because the folder is created unter $web_folder. Therefore the htpasswd file should always be placed in the $web_folder. From my point of view it is also better because there is no overlapping of the paths for vhost and vhost-alias/subdomain logins.
## Proposed fix
/server/plugins-available/apache2_plugin.inc.php
**Current code:** (Line 1938)
```
if($data['new']['stats_type'] != '') {
if(!is_dir($data['new']['document_root'].'/' . $web_folder . '/stats')) $app->system->mkdir($data['new']['document_root'].'/' . $web_folder . '/stats');
$ht_file = "AuthType Basic\nAuthName \"Members Only\"\nAuthUserFile ".$data['new']['document_root']."/web/stats/.htpasswd_stats\nrequire valid-user\nDirectoryIndex index.html index.php\nHeader set Content-Security-Policy \"default-src * 'self' 'unsafe-inline' 'unsafe-eval' data:;\"\n<Files \"goaindex.html\">\nAddDefaultCharset UTF-8\n</Files>\n";
$app->system->file_put_contents($data['new']['document_root'].'/' . $web_folder . '/stats/.htaccess', $ht_file);
$app->system->chmod($data['new']['document_root'].'/' . $web_folder . '/stats/.htaccess', 0755);
unset($ht_file);
if(!is_file($data['new']['document_root'].'/web/stats/.htpasswd_stats') || $data['new']['stats_password'] != $data['old']['stats_password']) {
if(trim($data['new']['stats_password']) != '') {
$htp_file = 'admin:'.trim($data['new']['stats_password']);
$app->system->web_folder_protection($data['new']['document_root'], false);
$app->system->file_put_contents($data['new']['document_root'].'/web/stats/.htpasswd_stats', $htp_file);
$app->system->web_folder_protection($data['new']['document_root'], true);
$app->system->chmod($data['new']['document_root'].'/web/stats/.htpasswd_stats', 0755);
unset($htp_file);
}
}
}
```
**Possible Fix:**
```
if($data['new']['stats_type'] != '') {
if(!is_dir($data['new']['document_root'].'/' . $web_folder . '/stats')) $app->system->mkdir($data['new']['document_root'].'/' . $web_folder . '/stats');
$ht_file = "AuthType Basic\nAuthName \"Members Only\"\nAuthUserFile ".$data['new']['document_root']."/".$web_folder."/stats/.htpasswd_stats\nrequire valid-user\nDirectoryIndex index.html index.php\nHeader set Content-Security-Policy \"default-src * 'self' 'unsafe-inline' 'unsafe-eval' data:;\"\n<Files \"goaindex.html\">\nAddDefaultCharset UTF-8\n</Files>\n";
$app->system->file_put_contents($data['new']['document_root'].'/' . $web_folder . '/stats/.htaccess', $ht_file);
$app->system->chmod($data['new']['document_root'].'/' . $web_folder . '/stats/.htaccess', 0755);
unset($ht_file);
if(!is_file($data['new']['document_root'].'/'.$web_folder.'/stats/.htpasswd_stats') || $data['new']['stats_password'] != $data['old']['stats_password']) {
if(trim($data['new']['stats_password']) != '') {
$htp_file = 'admin:'.trim($data['new']['stats_password']);
$app->system->web_folder_protection($data['new']['document_root'], false);
$app->system->file_put_contents($data['new']['document_root'].'/'.$web_folder.'/stats/.htpasswd_stats', $htp_file);
$app->system->web_folder_protection($data['new']['document_root'], true);
$app->system->chmod($data['new']['document_root'].'/'.$web_folder.'/stats/.htpasswd_stats', 0755);
unset($htp_file);
}
}
}
```3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6383AH00548: NameVirtualHost has no effect and will be removed in the next releas...2022-09-29T15:02:28ZJensAH00548: NameVirtualHost has no effect and will be removed in the next release /etc/apache2/sites-enabled/000-ispconfig.vhost:7## Summary
The line mentioned in $SUBJECT is output every restart of apache.
## Steps to reproduce
* Setup an Ubuntu 22.04 minimal VM image and ssh into it
* cd /tmp
* git clone https://git.ispconfig.org/ispconfig/ispconfig-autoinstalle...## Summary
The line mentioned in $SUBJECT is output every restart of apache.
## Steps to reproduce
* Setup an Ubuntu 22.04 minimal VM image and ssh into it
* cd /tmp
* git clone https://git.ispconfig.org/ispconfig/ispconfig-autoinstaller.git
* cd ispconfig-autoinstaller
* git checkout ubuntu-22
* sed -i -e '/8\.1/s/8\.1/7.2/g' lib/os/class.ISPConfigUbuntu2204OS.inc.php
* ./ispc3-ai.sh --channel=dev --use-ftp-ports=40110-40210 --unattended-upgrades=autoclean,reboot
* reboot the VM
* execute "apachectl restart"
## Correct behaviour
This line should not appear.
## Solution:
Remove NameVirtualHost from the ISPconfig templates:
```
/usr/local/ispconfig/server/conf# grep NameVirtualHost *
apache_apps.vhost.master:# NameVirtualHost *:{tmpl_var name='apps_vhost_port'}
apache_ispconfig.conf.master: NameVirtualHost *:80
apache_ispconfig.conf.master: NameVirtualHost *:443
apache_ispconfig.conf.master: NameVirtualHost {tmpl_var name="ip_address"}:{tmpl_var name="port"}
```3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6380Mailuser cannot login on develop branch, "Otp method unknown"2022-10-18T08:28:31ZJensMailuser cannot login on develop branch, "Otp method unknown"## Summary
see Subject
## Steps to reproduce
* Setup an Ubuntu 22.04 minimal VM image and ssh into it
* cd /tmp
* git clone https://git.ispconfig.org/ispconfig/ispconfig-autoinstaller.git
* cd ispconfig-autoinstaller
* git checkout ubun...## Summary
see Subject
## Steps to reproduce
* Setup an Ubuntu 22.04 minimal VM image and ssh into it
* cd /tmp
* git clone https://git.ispconfig.org/ispconfig/ispconfig-autoinstaller.git
* cd ispconfig-autoinstaller
* git checkout ubuntu-22
* sed -i -e '/8.1/s/8\.1/7\.4/g' lib/os/class.ISPConfigUbuntu2204OS.inc.php
* ./ispc3-ai.sh --channel=dev --use-ftp-ports=40110-40210 --unattended-upgrades=autoclean,reboot
* reboot the VM
* create a customer, domain, and mailuser
* logout of ispconfig
* try to login using the mailuser
Error message: "Ota method unknown".
## Correct behaviour
The user should be logged in.
## Environment
## Proposed fix
In `interface/web/login/index.php`, line 143, the line should be changed to
```
if(isset($user['otp_type']) and $user['otp_type'] != 'none') {
```
since `$user['ota_type']` is probably always empty for mailusers, and not `"none"`.3.2.9HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6379PHP8: count(): Argument #1 ($value) must be of type Countable|array, bool given2022-09-16T15:28:39ZJensPHP8: count(): Argument #1 ($value) must be of type Countable|array, bool given## Summary
With PHP 8.1, the above error prevents ISPconfig from loading.
With PHP 7.4, this error does not occur.
## Steps to reproduce
- Setup an Ubuntu 22.04 minimal VM image and ssh into it
- cd /tmp
- git clone https://git.ispconfi...## Summary
With PHP 8.1, the above error prevents ISPconfig from loading.
With PHP 7.4, this error does not occur.
## Steps to reproduce
- Setup an Ubuntu 22.04 minimal VM image and ssh into it
- cd /tmp
- git clone https://git.ispconfig.org/ispconfig/ispconfig-autoinstaller.git
- cd ispconfig-autoinstaller
- git checkout ubuntu-22 # for php8 support which ubuntu20.04 doesn't have yet
- ./ispc3-ai.sh --channel=dev --use-ftp-ports=40110-40210 --unattended-upgrades=autoclean,reboot
- reboot the VM
Then test ISPconfig. The header appears, but nothing else. In the apache error log, this error is shown:
```
mod_fcgid: stderr: PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, bool given in /usr/local/ispconfig/interface/lib/classes/tpl.inc.php(1366) : eval()'d code:116
mod_fcgid: stderr: Stack trace:
mod_fcgid: stderr: #0 /usr/local/ispconfig/interface/lib/classes/tpl.inc.php(1366): eval()
mod_fcgid: stderr: #1 /usr/local/ispconfig/interface/lib/classes/tpl.inc.php(769): tpl->_parse()
mod_fcgid: stderr: #2 /usr/local/ispconfig/interface/web/index.php(117): tpl->pparse()
mod_fcgid: stderr: #3 {main}
mod_fcgid: stderr: thrown in /usr/local/ispconfig/interface/lib/classes/tpl.inc.php(1366) : eval()'d code on line 116
```
Using debug output, I could narrow it down to either
`<?php for ($_0=0 ; $_0 < count($this->_arrvars['datalog_changes']); $_0++) {?>`
or
`<?php for ($_0=0 ; $_0 < count($this->_arrvars['js_d_includes']); $_0++) {?>`
not being countable in `/usr/local/ispconfig/interface/web/themes/default/templates/main.tpl.htm`
## Correct behaviour
ISPconfig should load.
If I do this before starting the autoinstaller, ISPconfig loads correctly.
```
sed -i -e '/8.1/s/8\.1/7\.4/g' lib/os/class.ISPConfigUbuntu2204OS.inc.php
```
## Environment
See above.
## References
This probably belongs into the php8 branch.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6378FTP statistic parsing does not work on EPEL/RHEL-like systems2022-08-18T10:50:08ZMichaelFTP statistic parsing does not work on EPEL/RHEL-like systemsDue to the hardcoded path in the cronjob, the pure-ftpd log files could not be parsed on EPEL/RHEL-like systems.Due to the hardcoded path in the cronjob, the pure-ftpd log files could not be parsed on EPEL/RHEL-like systems.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6369Default new users to be active2022-10-18T08:28:31ZHelmoDefault new users to be activeWhen you create a user via `System -> CP Users` it defaults to setting th enew users as not active.
I think it's more likely that you want to have a new account active(Otherwise why would you make it) ... so lets set make that default.
...When you create a user via `System -> CP Users` it defaults to setting th enew users as not active.
I think it's more likely that you want to have a new account active(Otherwise why would you make it) ... so lets set make that default.
MR comming ...3.2.9HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6366Lower the entropy test value in BIND plugin to 2002022-08-15T22:36:13ZTill BrehmLower the entropy test value in BIND plugin to 200https://forum.howtoforge.com/threads/dns-problem-host-not-found-servfail.89186/page-2#post-437701https://forum.howtoforge.com/threads/dns-problem-host-not-found-servfail.89186/page-2#post-4377013.2.9Till BrehmTill Brehm