ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2022-11-04T22:51:36Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6362Mailinglist allow spaces in name2022-11-04T22:51:36Zteuto.netMailinglist allow spaces in name## Summary
You can create a mailinglist with space in name, but spaces are not allowed in mail addresses.
## Steps to reproduce
1. Create a mailinglist with space in name
2. This Mailinglist won't work
## Correct behaviour
Validate for...## Summary
You can create a mailinglist with space in name, but spaces are not allowed in mail addresses.
## Steps to reproduce
1. Create a mailinglist with space in name
2. This Mailinglist won't work
## Correct behaviour
Validate for space in name before add a mailinglist.
## Environment
Ubuntu 20.04
ISPConfig version: 3.2.23.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6358Changing sort in DNS zone list refilters to all zone data2024-03-07T20:54:27ZTony GChanging sort in DNS zone list refilters to all zone dataGo to DNS > Zones and select a zone. Click the table header to sort by type, name, or data. At some point the filter is reset, so all zone records are presented in the new sorted order.
Ubuntu 20 / ISPConfig 3.2.2
![image](/uploads/95...Go to DNS > Zones and select a zone. Click the table header to sort by type, name, or data. At some point the filter is reset, so all zone records are presented in the new sorted order.
Ubuntu 20 / ISPConfig 3.2.2
![image](/uploads/95fceeb5874905c5a3fc1b3c3023516a/image.png)3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6347Notifications to reseller not working2022-12-14T15:15:35ZThomNotifications to reseller not working!1608 introduces notifications to resellers, but this doesn't work because of a line I wrote too fast :smile:
Testing the simple fix now. If it works, I will clean up the plugin a bit as it has a lot of duplicate code.!1608 introduces notifications to resellers, but this doesn't work because of a line I wrote too fast :smile:
Testing the simple fix now. If it works, I will clean up the plugin a bit as it has a lot of duplicate code.3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6345DNS zone file import always fails2023-03-06T21:44:46ZDovi CowanDNS zone file import always fails<!-- Before creating a bug report, please:
- Read the contribution guidelines: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/CONTRIBUTING.md
- Do not ask support questions here. If you are unsure if your problem is a bug,...<!-- Before creating a bug report, please:
- Read the contribution guidelines: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/CONTRIBUTING.md
- Do not ask support questions here. If you are unsure if your problem is a bug, post a thread on the forum: https://www.howtoforge.com/community/#ispconfig-3.23
- Make sure to remove any content from the description that you did not add. For example, if there are no related log entries, remove the whole "Related log entries" part.
-->
## Summary
Importing a DNS zone file always fails with the following error:
```
This zone is not allowed for this account.
This zone file appears invalid.
```
## Steps to reproduce
1. Go to the Zone File Import page
2. Select a client and domain
3. Click "Browse" and select a valid DNS zone file
4. Click "Import Zonefile" - Nothing happens
5. Open the browser dev tools, go to the Network tab, find the request to `/dns/dns_import.php` and check the Response.
## Correct behaviour
The zone file should be imported
## Environment
Server OS + version: Debian 10\
ISPConfig version: 3.2.8p1
<!-- _you can use `grep 'ISPC_APP_VERSION' /usr/local/ispconfig/server/lib/config.inc.php` to get it from the command line_ -->
Software version of the related software:
<!-- You can use 'nginx -v' or 'apachectl -v' to find the webserver version. Use 'php -v' to find the PHP version.> Put this in code blocks, like so: -->
```
# apachectl -v
Server version: Apache/2.4.38 (Debian)
Server built: 2021-12-21T16:50:43
# php -v
PHP 7.3.33-1+0~20211119.91+debian10~1.gbp618351 (cli) (built: Nov 19 2021 06:39:58) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.33, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.33-1+0~20211119.91+debian10~1.gbp618351, Copyright (c) 1999-2018, by Zend Technologies
```
## Proposed fix
This is because the [valid domain check](https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/interface/web/dns/dns_import.php#L625) is done by passing the domain name into [checkDomainModuleDomain](https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/interface/lib/classes/tools_sites.inc.php#L173), which is expecting a domain ID.3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6331Delete in correct order2022-08-15T22:38:13ZHelmoDelete in correct orderWhen deleting a client all it's assets are removed.
The current order is a bit weird, not that is seems to be an issue in the current code.
A mail_domain is cleaned up before the mail accounts under it.
This breaks when you try to do ...When deleting a client all it's assets are removed.
The current order is a bit weird, not that is seems to be an issue in the current code.
A mail_domain is cleaned up before the mail accounts under it.
This breaks when you try to do extra processing on a mail account just before it gets deleted. Like I'm doing in !14543.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6330Rescue core module for apache seems to be broken2023-10-21T15:52:19ZTill BrehmRescue core module for apache seems to be brokenDebug information:
```
root@server1:~# /usr/local/ispconfig/server/server.sh
08.04.2022-09:20 - WARNING - httpd is down! Try rescue httpd (try:1)...
08.04.2022-09:20 - WARNING - Invalid init command action stop
sh: -c: line 0: syntax er...Debug information:
```
root@server1:~# /usr/local/ispconfig/server/server.sh
08.04.2022-09:20 - WARNING - httpd is down! Try rescue httpd (try:1)...
08.04.2022-09:20 - WARNING - Invalid init command action stop
sh: -c: line 0: syntax error near unexpected token `&&'
sh: -c: line 0: ` && (sleep 3; kill $!; sleep 2; kill -9 $!) &> /dev/null'
08.04.2022-09:20 - WARNING - Invalid init command action start
PHP Warning: exec(): Cannot execute a blank command in /usr/local/ispconfig/server/mods-available/rescue_core_module.inc.php on line 478
08.04.2022-09:20 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.
08.04.2022-09:20 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
finished server.php.
```
This seems to happen only when no other actions were processed by server.sh.3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6326Fails to call acme.sh on systems with /bin/sh pointing to a pure-POSIX shell2022-04-07T16:42:21ZMattia RizzoloFails to call acme.sh on systems with /bin/sh pointing to a pure-POSIX shell## Summary
Using acme.sh on systems with /bin/sh → /bin/dash (for example) fail with this in the log:
```
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:430] - Create Let's Encrypt SSL Cert for: XXXX
Thu Mar 31 ...## Summary
Using acme.sh on systems with /bin/sh → /bin/dash (for example) fail with this in the log:
```
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:430] - Create Let's Encrypt SSL Cert for: XXXX
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:431] - Let's Encrypt SSL Cert domains:
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [system.inc:1819] - exec: R=0 ; C=0 ; /root/.acme.sh/acme.sh --issue -d XXXXX -d www.XXXXXX -w /usr/local/ispconfig/interface/acme --always-force-new-domain-key --keylength 4096; R=$? ; if [[ $R -eq 0 || $R -eq 2 ]] ; then /root/.acme.sh/acme.sh --install-cert -d XXXXXXX -d www.XXXXXXXXX --key-file '/var/www/clients/client505/web2/ssl/XXXXXXXXX-le.key' --fullchain-file '/var/www/clients/client505/web2/ssl/XXXXXXX-le.crt' --reloadcmd 'systemctl force-reload apache2.service' --log '/var/log/ispconfig/acme.log'; C=$? ; fi ; if [[ $C -eq 0 ]] ; then exit $R ; else exit $C ; fi
Thu Mar 31 16:36:07 UTC 2022 [Thu Mar 31 16:36:07 UTC 2022] Please add '--debug' or '--log' to check more details.
Thu Mar 31 16:36:07 UTC 2022 [Thu Mar 31 16:36:07 UTC 2022] See: https://github.com/acmesh-official/acme.sh/wiki/How-to-debug-acme.sh
Thu Mar 31 16:36:07 UTC 2022 sh: 1: [[: not found
Thu Mar 31 16:36:07 UTC 2022 sh: 1: 1: not found
Thu Mar 31 16:36:07 UTC 2022 sh: 1: [[: not found
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [system.inc:2399] - safe_exec cmd: which 'apache2ctl' 2> /dev/null - return code: 0
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [apache2 plugin.inc:1875] - Writing the vhost file: /etc/apache2/sites-available/XXXXXXXXX.vhost
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [apache2 plugin.inc:1993] - Apache status is: running
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [services.inc:56] - Calling function 'restartHttpd' from module 'web_module'.
```
(besides, note how this doesn't trigger any ERROR or WARNING, as such no notifications, and on the web panel the tick on "Let's Encrypt" doesn't get removed; however I'm not filing a different bug for this detail, nor am I fixing that)
## Environment
Server OS + version: Ubuntu 20.04.4 (just installed, really) \
ISPConfig version: 3.2.8p1
Software version of the related software:
```
root@web01 ~ # which sh
/usr/bin/sh
root@web01 ~ # ls -l /usr/bin/sh
lrwxrwxrwx 1 root root 4 Mar 22 21:40 /usr/bin/sh -> dash
```
## Proposed fix
That snippet that is also copied into the log use features that are not POSIX-compliant (the `[[` and the `||` in them), that despite being supported by many shells (including bash) are not available in dash.
Since `system()` runs the code with /bin/sh, then you should not presume a specific shell in that.
My fix will remove those bashism.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6322jquery error in dns zone file import page2022-08-15T22:34:15ZTill Brehmjquery error in dns zone file import pagehttps://www.howtoforge.com/community/threads/zone-file-import-not-working.88727/https://www.howtoforge.com/community/threads/zone-file-import-not-working.88727/3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6321Port apps.vhost from install/ to server/2022-09-30T19:05:47ZThomPort apps.vhost from install/ to server/Forgot to port it in c4cd74fca6595da99d816c4d31a72fe93dc61175Forgot to port it in c4cd74fca6595da99d816c4d31a72fe93dc611753.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6320Email backup stats2022-03-31T09:46:23ZTim de BoerEmail backup statsJust like "Sites -> Statistics -> Backup Stats" an overview of all backup settings and their stats, for Email ;)
![image](/uploads/da008d59fcac7e03a185f507bf91ba81/image.png)Just like "Sites -> Statistics -> Backup Stats" an overview of all backup settings and their stats, for Email ;)
![image](/uploads/da008d59fcac7e03a185f507bf91ba81/image.png)3.2.9Tim de BoerTim de Boerhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6319Typo in the ispconfig.vhost - error 4002022-03-26T15:41:08ZThomTypo in the ispconfig.vhost - error 400For the new redirect on error 400, there is a typo in the script.For the new redirect on error 400, there is a typo in the script.3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6316hide stderr from which(1) on centos2022-09-29T15:02:41ZJesse Norellhide stderr from which(1) on centosCentOs which(1) has different output than debian/ubuntu which is just informative, but looks like an error - need to add '2>/dev/null' to all uses of 'which' command.
See https://www.howtoforge.com/community/threads/error-installing-upd...CentOs which(1) has different output than debian/ubuntu which is just informative, but looks like an error - need to add '2>/dev/null' to all uses of 'which' command.
See https://www.howtoforge.com/community/threads/error-installing-update-to-3-2-7p1.88618/3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6312Fix compatibility issues on systems running php52022-03-24T19:13:55ZThomFix compatibility issues on systems running php5Port the compatibility library to server/ and install/ for systems which are using PHP 5.6 as the system php version.Port the compatibility library to server/ and install/ for systems which are using PHP 5.6 as the system php version.3.2.8p1Jesse NorellJesse Norellhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6309Line breaks in ispconfig.log2022-03-24T23:35:59ZGuillaume SubironLine breaks in ispconfig.log## Summary
Since ISPConfig 3.2.8, lines does not break in ispconfig.log
Example:
```
…
logs before update
…
24.03.2022-10:15 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:16 - DEBUG - Calling fu...## Summary
Since ISPConfig 3.2.8, lines does not break in ispconfig.log
Example:
```
…
logs before update
…
24.03.2022-10:15 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:16 - DEBUG - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.
24.03.2022-10:16 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:17 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:17 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:18 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:18 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:19 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:19 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:20 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:20 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:21 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n…logs after update…
```
## Environment
Server OS + version: At least on Debian 10 and Debian 11
ISPConfig version: 3.2.8 only
Thank you.3.2.8p1ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6306Incorrect template name for new AppArmor template2022-03-21T12:39:48ZThomIncorrect template name for new AppArmor templatemissed adding .master to the filenamemissed adding .master to the filename3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6304Database keeps behind if customer get deleted2022-08-17T13:10:44ZHannesDatabase keeps behind if customer get deleted(if already a open report about this sorry - didn't find any)
If i delete a customer than the database left behind.
Database user get deleted and everything else.
Tested on 2 servers (ubu 18.04 and 20.04 with ispc 3.2.7b)
Think only ha...(if already a open report about this sorry - didn't find any)
If i delete a customer than the database left behind.
Database user get deleted and everything else.
Tested on 2 servers (ubu 18.04 and 20.04 with ispc 3.2.7b)
Think only happens since one of the last releases.
the preview of the delete screen doesn't show the database too.
Screenshot shows database before and after delete (after delete the customer/domain gone)
![Unbenannt](/uploads/b76f00a3df7cb0e4c5fe4f900448e2b1/Unbenannt.jpg)3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6297regression: update jquery broke nginx directive snippet links2022-03-14T12:24:54ZJesse Norellregression: update jquery broke nginx directive snippet linkshttps://www.howtoforge.com/community/threads/issue-whit-directive-snippets-links.88019/#post-432856https://www.howtoforge.com/community/threads/issue-whit-directive-snippets-links.88019/#post-4328563.2.8Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6295Tools module not working in dev branch2022-03-01T19:13:10ZThomTools module not working in dev branchWhen I try to open mod tools (labeled as settings in the UI) in 3.2dev, a server error may occure.
is_admin seems to be not set anymore. This happened on a slightly older ISPConfig 3.2dev snapshot which is maybe 3-4 weeks old.
```
[Mon ...When I try to open mod tools (labeled as settings in the UI) in 3.2dev, a server error may occure.
is_admin seems to be not set anymore. This happened on a slightly older ISPConfig 3.2dev snapshot which is maybe 3-4 weeks old.
```
[Mon Feb 28 10:04:32.778573 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #0 /usr/local/ispconfig/interface/web/common.php(48): include_once(), referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778578 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #1 /usr/local/ispconfig/interface/web/capp.php(60): include_menu_dir_files('/usr/local/ispc...'), referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778583 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #2 {main}, referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778588 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: thrown in /usr/local/ispconfig/interface/web/tools/lib/menu.d/resync.menu.php on line 6, referer: https://cp.XXXXX.net:8088/index.php
```3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6293Error viewing the table in the section "help: manage question"2022-03-09T12:44:29ZMartino ColucciError viewing the table in the section "help: manage question"Hi, the table in the "Help: Question Management" section is not displayed correctly. This is because it is affected by the "tiny-col" CSS class which is set to "width: 8%".
Can you correct? Thank youHi, the table in the "Help: Question Management" section is not displayed correctly. This is because it is affected by the "tiny-col" CSS class which is set to "width: 8%".
Can you correct? Thank you3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6291changing owner website from reseller to client gives site on 2 places2024-02-01T15:36:54ZSteffan Noordchanging owner website from reseller to client gives site on 2 placesWhen i cange a website owner from a reseller to a new client the website is visable to the new client, but also stays in the reseller controlpanel.
When looking in the database i see that sys_userid is not changed to the new client
When...When i cange a website owner from a reseller to a new client the website is visable to the new client, but also stays in the reseller controlpanel.
When looking in the database i see that sys_userid is not changed to the new client
When i change sys_userid one number higher then sys_groupid everything is fine again.3.2.12