ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2022-04-24T19:41:16Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6327Failed datalog jobs are "successful" if another unrelated job succeeds2022-04-24T19:41:16ZWebsliceFailed datalog jobs are "successful" if another unrelated job succeedsAccording to the function datalogStatus(), the pending datalog jobs query is:
```
SELECT COUNT( * ) AS cnt, sys_datalog.action, sys_datalog.dbtable FROM sys_datalog, server WHERE server.server_id = sys_datalog.server_id AND sys_datalog....According to the function datalogStatus(), the pending datalog jobs query is:
```
SELECT COUNT( * ) AS cnt, sys_datalog.action, sys_datalog.dbtable FROM sys_datalog, server WHERE server.server_id = sys_datalog.server_id AND sys_datalog.user = ? AND sys_datalog.datalog_id > server.updated GROUP BY sys_datalog.dbtable, sys_datalog.action
```
If I intentionally let 5 jobs crash on a slave node, and then submit a completely unrelated different job successfully, the server.updated field is updated and the 5 crashed jobs are "successful".
Would it be feasible to have the datalog remember for each individual job, whether it was successful or not? So we can retry failed jobs?https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6326Fails to call acme.sh on systems with /bin/sh pointing to a pure-POSIX shell2022-04-07T16:42:21ZMattia RizzoloFails to call acme.sh on systems with /bin/sh pointing to a pure-POSIX shell## Summary
Using acme.sh on systems with /bin/sh → /bin/dash (for example) fail with this in the log:
```
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:430] - Create Let's Encrypt SSL Cert for: XXXX
Thu Mar 31 ...## Summary
Using acme.sh on systems with /bin/sh → /bin/dash (for example) fail with this in the log:
```
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:430] - Create Let's Encrypt SSL Cert for: XXXX
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [letsencrypt.inc:431] - Let's Encrypt SSL Cert domains:
Thu Mar 31 16:36:03 UTC 2022 31.03.2022-16:36 - DEBUG [system.inc:1819] - exec: R=0 ; C=0 ; /root/.acme.sh/acme.sh --issue -d XXXXX -d www.XXXXXX -w /usr/local/ispconfig/interface/acme --always-force-new-domain-key --keylength 4096; R=$? ; if [[ $R -eq 0 || $R -eq 2 ]] ; then /root/.acme.sh/acme.sh --install-cert -d XXXXXXX -d www.XXXXXXXXX --key-file '/var/www/clients/client505/web2/ssl/XXXXXXXXX-le.key' --fullchain-file '/var/www/clients/client505/web2/ssl/XXXXXXX-le.crt' --reloadcmd 'systemctl force-reload apache2.service' --log '/var/log/ispconfig/acme.log'; C=$? ; fi ; if [[ $C -eq 0 ]] ; then exit $R ; else exit $C ; fi
Thu Mar 31 16:36:07 UTC 2022 [Thu Mar 31 16:36:07 UTC 2022] Please add '--debug' or '--log' to check more details.
Thu Mar 31 16:36:07 UTC 2022 [Thu Mar 31 16:36:07 UTC 2022] See: https://github.com/acmesh-official/acme.sh/wiki/How-to-debug-acme.sh
Thu Mar 31 16:36:07 UTC 2022 sh: 1: [[: not found
Thu Mar 31 16:36:07 UTC 2022 sh: 1: 1: not found
Thu Mar 31 16:36:07 UTC 2022 sh: 1: [[: not found
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [system.inc:2399] - safe_exec cmd: which 'apache2ctl' 2> /dev/null - return code: 0
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [apache2 plugin.inc:1875] - Writing the vhost file: /etc/apache2/sites-available/XXXXXXXXX.vhost
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [apache2 plugin.inc:1993] - Apache status is: running
Thu Mar 31 16:36:07 UTC 2022 31.03.2022-16:36 - DEBUG [services.inc:56] - Calling function 'restartHttpd' from module 'web_module'.
```
(besides, note how this doesn't trigger any ERROR or WARNING, as such no notifications, and on the web panel the tick on "Let's Encrypt" doesn't get removed; however I'm not filing a different bug for this detail, nor am I fixing that)
## Environment
Server OS + version: Ubuntu 20.04.4 (just installed, really) \
ISPConfig version: 3.2.8p1
Software version of the related software:
```
root@web01 ~ # which sh
/usr/bin/sh
root@web01 ~ # ls -l /usr/bin/sh
lrwxrwxrwx 1 root root 4 Mar 22 21:40 /usr/bin/sh -> dash
```
## Proposed fix
That snippet that is also copied into the log use features that are not POSIX-compliant (the `[[` and the `||` in them), that despite being supported by many shells (including bash) are not available in dash.
Since `system()` runs the code with /bin/sh, then you should not presume a specific shell in that.
My fix will remove those bashism.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6322jquery error in dns zone file import page2022-08-15T22:34:15ZTill Brehmjquery error in dns zone file import pagehttps://www.howtoforge.com/community/threads/zone-file-import-not-working.88727/https://www.howtoforge.com/community/threads/zone-file-import-not-working.88727/3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6321Port apps.vhost from install/ to server/2022-09-30T19:05:47ZThomPort apps.vhost from install/ to server/Forgot to port it in c4cd74fca6595da99d816c4d31a72fe93dc61175Forgot to port it in c4cd74fca6595da99d816c4d31a72fe93dc611753.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6320Email backup stats2022-03-31T09:46:23ZTim de BoerEmail backup statsJust like "Sites -> Statistics -> Backup Stats" an overview of all backup settings and their stats, for Email ;)
![image](/uploads/da008d59fcac7e03a185f507bf91ba81/image.png)Just like "Sites -> Statistics -> Backup Stats" an overview of all backup settings and their stats, for Email ;)
![image](/uploads/da008d59fcac7e03a185f507bf91ba81/image.png)3.2.9Tim de BoerTim de Boerhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6319Typo in the ispconfig.vhost - error 4002022-03-26T15:41:08ZThomTypo in the ispconfig.vhost - error 400For the new redirect on error 400, there is a typo in the script.For the new redirect on error 400, there is a typo in the script.3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6318Module name not translatable in ISPConfig user settings2022-03-25T17:20:44ZTill BrehmModule name not translatable in ISPConfig user settingsModule name not translatable in ISPConfig user settingsModule name not translatable in ISPConfig user settingshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6316hide stderr from which(1) on centos2022-09-29T15:02:41ZJesse Norellhide stderr from which(1) on centosCentOs which(1) has different output than debian/ubuntu which is just informative, but looks like an error - need to add '2>/dev/null' to all uses of 'which' command.
See https://www.howtoforge.com/community/threads/error-installing-upd...CentOs which(1) has different output than debian/ubuntu which is just informative, but looks like an error - need to add '2>/dev/null' to all uses of 'which' command.
See https://www.howtoforge.com/community/threads/error-installing-update-to-3-2-7p1.88618/3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6315move E-Mail to Junk in Panel does not work2022-12-19T16:30:38ZSebastianmove E-Mail to Junk in Panel does not work
## Summary
<!-- What is happening and what is wrong with that? -->
When selecting something in the dropdown on ISPConfig Panel "email / email account / email filter / move spam to junk folder"
following happens:
Panel-tab gets refresh...
## Summary
<!-- What is happening and what is wrong with that? -->
When selecting something in the dropdown on ISPConfig Panel "email / email account / email filter / move spam to junk folder"
following happens:
Panel-tab gets refreshed when selecting another "move spam to junk folder" option.
Using firefox inspector, it states "tab change interrupted, request still running".
## Steps to reproduce
1. Go on the Panel
2. click E-Mail
3. click E-Mail Account
4. Select Tab: E-Mail filter
5. Select the "move spam to junk folder" and chose any other option
## Correct behaviour
<!-- What should happen instead? -->
It should select another option instead of refreshing the tab.
## Environment
Server OS + version: Debian 11.2 \
ISPConfig version: 3.2.7p1
<!-- _you can use `grep 'ISPC_APP_VERSION' /usr/local/ispconfig/server/lib/config.inc.php` to get it from the command line_ -->
Software version of the related software:
<!-- You can use 'nginx -v' or 'apachectl -v' to find the webserver version. Use 'php -v' to find the PHP version.> Put this in code blocks, like so: -->
```
nginx version: nginx/1.18.0
PHP 7.4.28 (cli) (built: Feb 17 2022 16:17:19) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.28, Copyright (c), by Zend Technologies
```
## Proposed fix
at /usr/local/ispconfig/interface/web/mail/templates/mail_user_filter_list.htm
remove this onclick attribut
```
onclick="return ISPConfig.changeTab('filter_records','mail/mail_user_edit.php');"
```
## References
https://www.howtoforge.com/community/threads/changing-move-e-mail-to-junk-folder-in-gui-doesnt-work.88635/page-2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6312Fix compatibility issues on systems running php52022-03-24T19:13:55ZThomFix compatibility issues on systems running php5Port the compatibility library to server/ and install/ for systems which are using PHP 5.6 as the system php version.Port the compatibility library to server/ and install/ for systems which are using PHP 5.6 as the system php version.3.2.8p1Jesse NorellJesse Norellhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6309Line breaks in ispconfig.log2022-03-24T23:35:59ZGuillaume SubironLine breaks in ispconfig.log## Summary
Since ISPConfig 3.2.8, lines does not break in ispconfig.log
Example:
```
…
logs before update
…
24.03.2022-10:15 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:16 - DEBUG - Calling fu...## Summary
Since ISPConfig 3.2.8, lines does not break in ispconfig.log
Example:
```
…
logs before update
…
24.03.2022-10:15 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:16 - DEBUG - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.
24.03.2022-10:16 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
24.03.2022-10:17 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:17 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:18 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:18 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:19 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:19 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:20 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n24.03.2022-10:20 - DEBUG [server:217] - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock\r\n24.03.2022-10:21 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.\r\n…logs after update…
```
## Environment
Server OS + version: At least on Debian 10 and Debian 11
ISPConfig version: 3.2.8 only
Thank you.3.2.8p1ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6306Incorrect template name for new AppArmor template2022-03-21T12:39:48ZThomIncorrect template name for new AppArmor templatemissed adding .master to the filenamemissed adding .master to the filename3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6304Database keeps behind if customer get deleted2022-08-17T13:10:44ZHannesDatabase keeps behind if customer get deleted(if already a open report about this sorry - didn't find any)
If i delete a customer than the database left behind.
Database user get deleted and everything else.
Tested on 2 servers (ubu 18.04 and 20.04 with ispc 3.2.7b)
Think only ha...(if already a open report about this sorry - didn't find any)
If i delete a customer than the database left behind.
Database user get deleted and everything else.
Tested on 2 servers (ubu 18.04 and 20.04 with ispc 3.2.7b)
Think only happens since one of the last releases.
the preview of the delete screen doesn't show the database too.
Screenshot shows database before and after delete (after delete the customer/domain gone)
![Unbenannt](/uploads/b76f00a3df7cb0e4c5fe4f900448e2b1/Unbenannt.jpg)3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6297regression: update jquery broke nginx directive snippet links2022-03-14T12:24:54ZJesse Norellregression: update jquery broke nginx directive snippet linkshttps://www.howtoforge.com/community/threads/issue-whit-directive-snippets-links.88019/#post-432856https://www.howtoforge.com/community/threads/issue-whit-directive-snippets-links.88019/#post-4328563.2.8Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6295Tools module not working in dev branch2022-03-01T19:13:10ZThomTools module not working in dev branchWhen I try to open mod tools (labeled as settings in the UI) in 3.2dev, a server error may occure.
is_admin seems to be not set anymore. This happened on a slightly older ISPConfig 3.2dev snapshot which is maybe 3-4 weeks old.
```
[Mon ...When I try to open mod tools (labeled as settings in the UI) in 3.2dev, a server error may occure.
is_admin seems to be not set anymore. This happened on a slightly older ISPConfig 3.2dev snapshot which is maybe 3-4 weeks old.
```
[Mon Feb 28 10:04:32.778573 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #0 /usr/local/ispconfig/interface/web/common.php(48): include_once(), referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778578 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #1 /usr/local/ispconfig/interface/web/capp.php(60): include_menu_dir_files('/usr/local/ispc...'), referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778583 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: #2 {main}, referer: https://cp.XXXXX.net:8088/index.php
[Mon Feb 28 10:04:32.778588 2022] [fcgid:warn] [pid 9757:tid 9808] [client 217.227.0.0:25599] mod_fcgid: stderr: thrown in /usr/local/ispconfig/interface/web/tools/lib/menu.d/resync.menu.php on line 6, referer: https://cp.XXXXX.net:8088/index.php
```3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6293Error viewing the table in the section "help: manage question"2022-03-09T12:44:29ZMartino ColucciError viewing the table in the section "help: manage question"Hi, the table in the "Help: Question Management" section is not displayed correctly. This is because it is affected by the "tiny-col" CSS class which is set to "width: 8%".
Can you correct? Thank youHi, the table in the "Help: Question Management" section is not displayed correctly. This is because it is affected by the "tiny-col" CSS class which is set to "width: 8%".
Can you correct? Thank you3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6291changing owner website from reseller to client gives site on 2 places2024-02-01T15:36:54ZSteffan Noordchanging owner website from reseller to client gives site on 2 placesWhen i cange a website owner from a reseller to a new client the website is visable to the new client, but also stays in the reseller controlpanel.
When looking in the database i see that sys_userid is not changed to the new client
When...When i cange a website owner from a reseller to a new client the website is visable to the new client, but also stays in the reseller controlpanel.
When looking in the database i see that sys_userid is not changed to the new client
When i change sys_userid one number higher then sys_groupid everything is fine again.3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6290ISPConfig port detection failure when ISPConfig use Apache + an NGINX is inst...2022-03-02T07:23:16ZManoa RatefiarisonISPConfig port detection failure when ISPConfig use Apache + an NGINX is installed but not used by ISPConfig## Summary
When NGINX is installed alongside the Apache2 of ISPConfig, the port detection during ISPConfig update is not working (becomes empty). Same bug happens with the apps vhost.
## Steps to reproduce
1. Install ISPConfig with Apac...## Summary
When NGINX is installed alongside the Apache2 of ISPConfig, the port detection during ISPConfig update is not working (becomes empty). Same bug happens with the apps vhost.
## Steps to reproduce
1. Install ISPConfig with Apache2
2. Install NGINX and make it listening any port other than 80, 443 and the ISPConfig or apps vhost port (default 8080/8081).
3. Update ISPConfig and see "ISPConfig port" empty
4. Once ISPConfig updated, ports are empty on app.vhost and ispconfig.vhost configuration file in Apache
## Correct behaviour
The ISPConfig port during update.php wizard should state the current port set in Apache2.
## Environment
Server OS + version: Debian 11
ISPConfig version: 3.2.7p1
Software version of the related software: (any version of nginx and apache2)
## Proposed fix
Instead of checking if NGINX or Apache2 is installed, installation should check if ISPConfig is configured with NGINX or with Apache2:
```
root@vps72943:/usr/local/ispconfig# git diff install/lib/install.lib.php
diff --git a/install/lib/install.lib.php b/install/lib/install.lib.php
index 6ff32bb78..6741523b6 100644
--- a/install/lib/install.lib.php
+++ b/install/lib/install.lib.php
@@ -842,7 +842,8 @@ function is_installed($appname) {
function get_ispconfig_port_number() {
global $conf;
- if($conf['nginx']['installed'] == true){
+
+ if(is_file($conf['nginx']['vhost_conf_dir'].'/ispconfig.vhost')) {
$ispconfig_vhost_file = $conf['nginx']['vhost_conf_dir'].'/ispconfig.vhost';
$regex = '/listen (\d+)/';
} else {
@@ -868,7 +869,7 @@ function get_ispconfig_port_number() {
function get_apps_vhost_port_number() {
global $conf;
- if($conf['nginx']['installed'] == true){
+ if(is_file($conf['nginx']['vhost_conf_dir'].'/apps.vhost')) {
$ispconfig_vhost_file = $conf['nginx']['vhost_conf_dir'].'/apps.vhost';
$regex = '/listen (\d+)/';
} else {
```3.2.8Manoa RatefiarisonManoa Ratefiarisonhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6286Deactivate e-mail doman policy dont work2022-02-28T13:15:52ZWHODeactivate e-mail doman policy dont work## Summary
If you set a spam policy you cant deactivate it anymore.
## Steps to reproduce
1. Edit a email domain
2. Set a spam filter
3. Try to deactivate the spam filter again
## Proposed fix
/usr/local/ispconfig/interface/web/mail/ma...## Summary
If you set a spam policy you cant deactivate it anymore.
## Steps to reproduce
1. Edit a email domain
2. Set a spam filter
3. Try to deactivate the spam filter again
## Proposed fix
/usr/local/ispconfig/interface/web/mail/mail_domain_edit.php
**Line 443:**
```
$tmp_user = $app->db->queryOneRecord("SELECT id FROM spamfilter_users WHERE email = ?", '@' . $domain);
```
**Change to:**
```
$tmp_user = $app->db->queryOneRecord("SELECT id, policy_id FROM spamfilter_users WHERE email = ?", '@' . $domain);
```
## Reason
In Line 446 you try to get the attribut $tmp_user['policy_id'] but is not selected in the mysql query.3.2.8ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6277website 'backups' folder not created on backup download2022-02-28T13:13:34ZJesse Norellwebsite 'backups' folder not created on backup downloadWhen downloading a backup, the 'backups' directory should be created if it does not exist.
https://www.howtoforge.com/community/threads/problem-with-web-backup-download.88263/When downloading a backup, the 'backups' directory should be created if it does not exist.
https://www.howtoforge.com/community/threads/problem-with-web-backup-download.88263/3.2.8ThomThom