ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2023-08-23T11:23:42Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6528Account limit incorrectly informed in dashboard - ISPConfig 3.2.102023-08-23T11:23:42ZAlexandre Pereira BühlerAccount limit incorrectly informed in dashboard - ISPConfig 3.2.10In ISPConfig 3.2.10 account limits are being reported as unlimited for customers.
It is for the administrator is informed without values or with wrong values..
example for customers:
Assigned web quota 50200 MB of Unlimited MB
example fo...In ISPConfig 3.2.10 account limits are being reported as unlimited for customers.
It is for the administrator is informed without values or with wrong values..
example for customers:
Assigned web quota 50200 MB of Unlimited MB
example for admin:
Assigned database quota MB of Unlimited MB
Prints do bug no fórum do ispconfig:
https://forum.howtoforge.com/threads/account-limit-incorrectly-informed-in-dashboard-ispconfig-3-2-10.90743/3.2.10p2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6524DNS Zone list server column empty2023-06-09T14:22:44ZTill BrehmDNS Zone list server column emptyIn DNS zone list, the server column is empty in client view when domain limit module is on.In DNS zone list, the server column is empty in client view when domain limit module is on.3.2.10p1https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6523API dkim_selector_error in mail_domain_add ()2023-06-09T12:03:18ZTill BrehmAPI dkim_selector_error in mail_domain_add ()```
<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"><SOAP-ENV:Body><SOAP-ENV:Fault><faultcode>data_processing_error</faultcode><faultstring>dkim_selector_error&lt;br /&...```
<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"><SOAP-ENV:Body><SOAP-ENV:Fault><faultcode>data_processing_error</faultcode><faultstring>dkim_selector_error<br />
</faultstring></SOAP-ENV:Fault></SOAP-ENV:Body></SOAP-ENV:Envelope>
dkim_selector_error<br />
```3.2.10p1https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6522DNS zones can not be added with Wizard when domain module is enabled.2023-06-08T15:24:08ZTill BrehmDNS zones can not be added with Wizard when domain module is enabled.DNS zones can not be added with Wizard when domain module is enabled.
https://forum.howtoforge.com/threads/3-2-10-error-in-the-operation-of-dns-templates.90730/DNS zones can not be added with Wizard when domain module is enabled.
https://forum.howtoforge.com/threads/3-2-10-error-in-the-operation-of-dns-templates.90730/3.2.10p1https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6521Database List Sort on dbuser column not working2023-08-04T17:04:11ZHannesDatabase List Sort on dbuser column not workingOn click on database-user in the table header than the entries vanish from the listOn click on database-user in the table header than the entries vanish from the list3.2.11https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6520Bind plugin doesn't work properly after upgrade to 3.2.10: Call to undefined ...2023-06-07T09:37:23ZArtur YakupovBind plugin doesn't work properly after upgrade to 3.2.10: Call to undefined method bind_plugin::slave_zone_file_prefix()## Summary
Cron jobs don't work properly in 3.2.10 if you have slave DNS (Secondary DNS-Zones) set up.
## Steps to reproduce
1. Set up slave DNS (Secondary DNS-Zones)
2. Configuration changes never apply after that.
3. Cron jobs don't s...## Summary
Cron jobs don't work properly in 3.2.10 if you have slave DNS (Secondary DNS-Zones) set up.
## Steps to reproduce
1. Set up slave DNS (Secondary DNS-Zones)
2. Configuration changes never apply after that.
3. Cron jobs don't start with errors ike that:
Tue Jun 6 09:57:01 AM UTC 2023 06.06.2023-09:57 - WARNING - There is already a lockfile set, but no process running with this pid (30613). Continuing.
Tue Jun 6 09:57:02 AM UTC 2023 PHP Fatal error: Uncaught Error: Call to undefined method bind_plugin::slave_zone_file_prefix() in /usr/local/ispconfig/server/plugins-available/bind_plugin.
inc.php:463
Tue Jun 6 09:57:02 AM UTC 2023 Stack trace:
Tue Jun 6 09:57:02 AM UTC 2023 #0 /usr/local/ispconfig/server/plugins-available/bind_plugin.inc.php(438): bind_plugin->slave_update()
Tue Jun 6 09:57:02 AM UTC 2023 #1 /usr/local/ispconfig/server/lib/classes/plugins.inc.php(120): bind_plugin->slave_insert()
Tue Jun 6 09:57:02 AM UTC 2023 #2 /usr/local/ispconfig/server/mods-available/dns_module.inc.php(108): plugins->raiseEvent()
Tue Jun 6 09:57:02 AM UTC 2023 #3 /usr/local/ispconfig/server/lib/classes/modules.inc.php(302): dns_module->process()
Tue Jun 6 09:57:02 AM UTC 2023 #4 /usr/local/ispconfig/server/lib/classes/modules.inc.php(235): modules->raiseTableHook()
Tue Jun 6 09:57:02 AM UTC 2023 #5 /usr/local/ispconfig/server/server.php(180): modules->processDatalog()
Tue Jun 6 09:57:02 AM UTC 2023 #6 {main}
Tue Jun 6 09:57:02 AM UTC 2023 thrown in /usr/local/ispconfig/server/plugins-available/bind_plugin.inc.php on line 463
## Correct behaviour
Everything should work normally.
## Environment
Server OS + version: Ubuntu 22.04.2 LTS
ISPConfig version: 3.2.10
PHP 7.4.33
## Proposed fix
Added to /usr/local/ispconfig/server/plugins-available/bind_plugin.inc.php
function slave_zone_file_prefix() {
//TODO : change this when distribution information has been integrated into server record
return (file_exists('/etc/gentoo-release')) ? 'sec/' : 'slave/sec.';
}
Somehow it was removed since 3.2.9 but still used.3.2.10p1https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6519DNS Wizard not working with use_domain_module = y2023-06-09T09:34:16ZTim de BoerDNS Wizard not working with use_domain_module = y<!-- Before creating a bug report, please:
- Read the contribution guidelines: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/CONTRIBUTING.md
- Do not ask support questions here. If you are unsure if your problem is a bug,...<!-- Before creating a bug report, please:
- Read the contribution guidelines: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/CONTRIBUTING.md
- Do not ask support questions here. If you are unsure if your problem is a bug, post a thread on the forum: https://www.howtoforge.com/community/#ispconfig-3.23
- Make sure to remove any content from the description that you did not add. For example, if there are no related log entries, remove the whole "Related log entries" part.
-->
## Summary
<!-- What is happening and what is wrong with that? -->
When using the DNS wizard and with the DNS Module enabled; when a domain is selected, this will be parse the "domain_id" as "domain".
After debugging;
`if ($domains_settings['use_domain_module'] == 'y') {` on line 77 of `interface/lib/classes/dns_wizard.inc.php` isn't handling correctly, due to the fact `$domains_settings` isn't available.
## Steps to reproduce
1. Enable Domain Module
2. Add DNS zone with Wizard
3. Choose domain
4. Get an error "Domain contains invalid characters" (because the domain_id is used instead of the domain)
## Correct behaviour
Line 77 should check correctly if Domain Module is used.
## Environment
Server OS + version: Debian 11
ISPConfig version: 3.2.103.2.10p1https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6516Help System sorting messages by date is bugged (messages vanish if date <th> ...2023-06-01T12:48:07ZHannesHelp System sorting messages by date is bugged (messages vanish if date <th> is clicked)Wrong data-column name in templateWrong data-column name in template3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6515Error sending support message in ISPConfig panel2023-05-31T07:41:18ZNatan Fellesnatanfelles@gmail.comError sending support message in ISPConfig panel## Summary
Error sending support message in ISPConfig panel
## Steps to reproduce
1. Go to Help > Send message and try send a message.
2. An error 500 will occurs in the file /help/support_message_edit.php
3. This is the log from /var/...## Summary
Error sending support message in ISPConfig panel
## Steps to reproduce
1. Go to Help > Send message and try send a message.
2. An error 500 will occurs in the file /help/support_message_edit.php
3. This is the log from /var/log/nginx/error.log:
```log
2023/05/30 23:05:15 [error] 26798#26798: *2 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: fsockopen(): Argument #2 ($port) must be of type int, string given in /usr/local/ispconfig/interface/lib/classes/ispcmail.inc.php:588
Stack trace:
#0 /usr/local/ispconfig/interface/lib/classes/ispcmail.inc.php(588): fsockopen()
#1 /usr/local/ispconfig/interface/lib/classes/ispcmail.inc.php(760): ispcmail->_smtp_login()
#2 /usr/local/ispconfig/interface/lib/classes/functions.inc.php(67): ispcmail->send()
#3 /usr/local/ispconfig/interface/web/help/support_message_edit.php(76): functions->mail()
#4 /usr/local/ispconfig/interface/lib/classes/tform_actions.inc.php(69): page_action->onSubmit()
#5 /usr/local/ispconfig/interface/web/help/support_message_edit.php(127): tform_actions->onLoad()
#6 {main}
thrown in /usr/local/ispconfig/interface/lib/classes/ispcmail.inc.php on line 588" while reading response header from upstream, client: 192.168.0.10, server: _, request: "POST /help/support_message_edit.php HTTP/2.0", upstream: "fastcgi://unix:/var/lib/php8.1-fpm/ispconfig.sock:", host: "192.168.0.110:8080", referrer: "https://192.168.0.110:8080/index.php"
```
## Correct behaviour
It should send the support message.
## Environment
Server OS + version: Ubuntu 22.04
ISPConfig version: 3.2.9p1
## Proposed fix
Updating the `smtp_port` property to int at `/usr/local/ispconfig/interface/lib/classes/ispcmail.inc.php:588` solves the issue:
```php
$this->_smtp_conn = fsockopen(($this->smtp_crypt == 'ssl' ? 'tls://' : '') . $this->smtp_host, (int)$this->smtp_port, $errno, $errstr, 30);
```
Thank you!3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6509double key in lang file interface/web/admin/lib/lang/it_system_config.lng2023-05-24T06:45:16ZHannesdouble key in lang file interface/web/admin/lib/lang/it_system_config.lngVersion: devel
<pre>
$wb['show_aps_menu_note_url_txt'] = 'Clicca qui per maggiori informazioni.';
$wb['show_aps_menu_note_url_txt'] = 'Click here for more information.';
</pre>Version: devel
<pre>
$wb['show_aps_menu_note_url_txt'] = 'Clicca qui per maggiori informazioni.';
$wb['show_aps_menu_note_url_txt'] = 'Click here for more information.';
</pre>3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6504DNS zone import as user - wrong sys_groupid in dns_rr and dns_soa2023-05-18T07:03:49ZHannesDNS zone import as user - wrong sys_groupid in dns_rr and dns_soaVersion 3.2.9
Zone import script imports with sys_groupid 0 if a user do this (with admin is correct)
Problem with groupid 0 is the api call dns_zone_get_by_user doesn't return this zone even if sys_userid is the user.
sql from the api ...Version 3.2.9
Zone import script imports with sys_groupid 0 if a user do this (with admin is correct)
Problem with groupid 0 is the api call dns_zone_get_by_user doesn't return this zone even if sys_userid is the user.
sql from the api call
<pre>
SELECT id, origin FROM dns_soa d INNER JOIN sys_user s on(d.sys_groupid = s.default_group) WHERE client_id = ? AND server_id =
</pre>
if i change dns_import.php:64 than it works for me (but not really testet)
<pre>
// import variables
$template_id = (isset($_POST['template_id']))?$app->functions->intval($_POST['template_id']):0;
//$sys_groupid = (isset($_POST['client_group_id']))?$app->functions->intval($_POST['client_group_id']):0;
if (isset($_POST['client_group_id'])) {
$sys_groupid = $app->functions->intval($_POST['client_group_id']);
} else {
$sys_groupid = $_SESSION["s"]["user"]["default_group"];
}
</pre>3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6495Setting the language as a required field when creating a client2023-08-04T16:20:43ZAdamSetting the language as a required field when creating a clientIf we do not set the language parameter when creating a client via the API, an client is not added to the sys_user table, which causes next problems.
Merge request: https://git.ispconfig.org/ispconfig/ispconfig3/-/merge_requests/1719If we do not set the language parameter when creating a client via the API, an client is not added to the sys_user table, which causes next problems.
Merge request: https://git.ispconfig.org/ispconfig/ispconfig3/-/merge_requests/17193.2.11https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6491Create webdomain form lists domains that are already used2023-04-23T10:31:30ZHelmoCreate webdomain form lists domains that are already usedWhen using the domain module the dropdown menu lists all domains, also the ones that already have a site and will give an error when you try.
![image](/uploads/c17be5afb82700891bb348edadded53e/image.png)
The bug is in the getDomainModu...When using the domain module the dropdown menu lists all domains, also the ones that already have a site and will give an error when you try.
![image](/uploads/c17be5afb82700891bb348edadded53e/image.png)
The bug is in the getDomainModuleDomains() function using a NULL value in a query which fails.
I'm preparing a patch...3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6486Wrong database name variable used in Rspamd plugin2023-03-31T16:12:59ZTill BrehmWrong database name variable used in Rspamd pluginhttps://forum.howtoforge.com/threads/ispconfig-3-2-9p1-pending-operations.90383/page-2#post-445146https://forum.howtoforge.com/threads/ispconfig-3-2-9p1-pending-operations.90383/page-2#post-4451463.2.10Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6481replication failed with Uncaught Error: Undefined constant "dbtable"2023-03-27T15:59:10ZTill Brehmreplication failed with Uncaught Error: Undefined constant "dbtable"https://forum.howtoforge.com/threads/uncaught-error-undefined-constant-dbtable.90395/#post-445001https://forum.howtoforge.com/threads/uncaught-error-undefined-constant-dbtable.90395/#post-4450013.2.10Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6480[patch] wrong databases are shown when selecting a server.2023-04-17T15:08:17ZTom[patch] wrong databases are shown when selecting a server.Hi,
We have a multiserver setup, server X has id 6 and server Y has id 26.
When we go to the list of databases, and select server X from the list, we also get the databases of server Y. This is because you match with a LIKE in the the ...Hi,
We have a multiserver setup, server X has id 6 and server Y has id 26.
When we go to the list of databases, and select server X from the list, we also get the databases of server Y. This is because you match with a LIKE in the the database query.
This resolves that:
```
--- interface/web/sites/list/database.list.php.orig 2023-03-17 13:42:56.533206297 +0100
+++ interface/web/sites/list/database.list.php 2023-03-17 13:43:25.781272409 +0100
@@ -103,9 +103,9 @@
$liste["item"][] = array( 'field' => "server_id",
'datatype' => "INTEGER",
'formtype' => "SELECT",
- 'op' => "like",
- 'prefix' => "%",
- 'suffix' => "%",
+ 'op' => "=",
+ 'prefix' => "",
+ 'suffix' => "",
'datasource' => array ( 'type' => 'SQL',
'querystring' => 'SELECT a.server_id, a.server_name FROM server a, web_database b WHERE (a.server_id = b.server_id) AND ({AUTHSQL-B}) ORDER BY a.server_name',
'keyfield'=> 'server_id',
```3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6472Create a shell user - PHP Fatal error: Uncaught TypeError: realpath()2023-04-18T17:11:31ZClaudiusCreate a shell user - PHP Fatal error: Uncaught TypeError: realpath()I tryied to create a shell user
```
28.02.2023-18:01 - WARNING - There is already a lockfile set, but no process running with this pid (180528). Continuing.
28.02.2023-18:01 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_...I tryied to create a shell user
```
28.02.2023-18:01 - WARNING - There is already a lockfile set, but no process running with this pid (180528). Continuing.
28.02.2023-18:01 - DEBUG [plugins.inc:155] - Calling function 'check_phpini_changes' from plugin 'webserver_plugin' raised by action 'server_plugins_loaded'.
28.02.2023-18:01 - DEBUG [server:177] - Found 7 changes, starting update process.
28.02.2023-18:01 - DEBUG [plugins.inc:118] - Calling function 'insert' from plugin 'shelluser_base_plugin' raised by event 'shell_user_insert'.
28.02.2023-18:01 - DEBUG [system.inc:2399] - safe_exec cmd: chattr -i '/var/www/clients/client3/web6' - return code: 0
useradd: user 'USER1234' already exists
28.02.2023-18:01 - DEBUG [system.inc:2399] - safe_exec cmd: useradd -d '/var/www/clients/client3/web6/home/USER1234' -g 'client3' -o -s '/bin/false' -u '5007' 'USER1234' - return code: 9
28.02.2023-18:01 - DEBUG [shelluser base plugin.inc:138] - Executed command: useradd -d ? -g ? -o -s ? -u ? ?
28.02.2023-18:01 - DEBUG [shelluser base plugin.inc:139] - Added shelluser: USER1234
28.02.2023-18:01 - DEBUG [shelluser base plugin.inc:431] - ssh-rsa setup shelluser_base
28.02.2023-18:01 - DEBUG [system.inc:2399] - safe_exec cmd: mktemp -dt id_rsa.XXXXXXXX - return code: 0
PHP Warning: Array to string conversion in /usr/local/ispconfig/server/lib/classes/functions.inc.php on line 473
28.02.2023-18:01 - DEBUG [system.inc:2399] - safe_exec cmd: ssh-keygen -t rsa -C 'USER1234-rsa-key-1677603714' -f 'Array63fe338261e968.84316028' -N "" - return code: 0
28.02.2023-18:01 - WARNING - Action aborted, file is a symlink: Array63fe338261e968.84316028
PHP Warning: Undefined array key "hostname" in /usr/local/ispconfig/server/lib/app.inc.php on line 324
PHP Warning: Undefined array key "hostname" in /usr/local/ispconfig/server/lib/app.inc.php on line 324
28.02.2023-18:01 - WARNING - Action aborted, file is a symlink: Array63fe338261e968.84316028.pub
PHP Warning: Undefined array key "hostname" in /usr/local/ispconfig/server/lib/app.inc.php on line 324
PHP Warning: Undefined array key "hostname" in /usr/local/ispconfig/server/lib/app.inc.php on line 324
28.02.2023-18:01 - DEBUG [db mysql.inc:523] - NON-String given in escape function! (boolean)
28.02.2023-18:01 - DEBUG [db mysql.inc:523] - NON-String given in escape function! (boolean)
PHP Fatal error: Uncaught TypeError: realpath(): Argument #1 ($path) must be of type string, array given in /usr/local/ispconfig/server/lib/classes/system.inc.php:946
Stack trace:
#0 /usr/local/ispconfig/server/lib/classes/system.inc.php(946): realpath()
#1 /usr/local/ispconfig/server/lib/classes/functions.inc.php(480): system->rmdir()
#2 /usr/local/ispconfig/server/plugins-available/shelluser_base_plugin.inc.php(468): functions->generate_ssh_key()
#3 /usr/local/ispconfig/server/plugins-available/shelluser_base_plugin.inc.php(157): shelluser_base_plugin->_setup_ssh_rsa()
#4 /usr/local/ispconfig/server/lib/classes/plugins.inc.php(120): shelluser_base_plugin->insert()
#5 /usr/local/ispconfig/server/mods-available/web_module.inc.php(150): plugins->raiseEvent()
#6 /usr/local/ispconfig/server/lib/classes/modules.inc.php(302): web_module->process()
#7 /usr/local/ispconfig/server/lib/classes/modules.inc.php(235): modules->raiseTableHook()
#8 /usr/local/ispconfig/server/server.php(180): modules->processDatalog()
#9 {main}
thrown in /usr/local/ispconfig/server/lib/classes/system.inc.php on line 946
```3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6471Switch between mod_proxy_protocol and mod_remoteip is not working2023-04-14T12:25:13ZAndreas PalmSwitch between mod_proxy_protocol and mod_remoteip is not working## Summary
Apache vhost config is always filled with mod_proxy_protocol directives even in newer apache versions.
## Steps to reproduce
1. Enable PROXY PROTOCOL in Sites->Options on a system with apache 2.4.30+
2. Check corresponding vh...## Summary
Apache vhost config is always filled with mod_proxy_protocol directives even in newer apache versions.
## Steps to reproduce
1. Enable PROXY PROTOCOL in Sites->Options on a system with apache 2.4.30+
2. Check corresponding vhost file, mod_proxy_protocol is still used
## Correct behaviour
In apache versions newer than 2.4.30 the mod_remoteip should be used instead
## Environment
Server OS + version: Debian 11
ISPConfig version: 3.2.9p1
## References
#5457https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6467Minor Issue in clearBackup function2023-05-26T07:30:28ZHannesMinor Issue in clearBackup functionthe clearBackups() function get called after web backup and after db backup with the backup_copies value from web_domain and web_database.
There is no problem if the backup_copies in web_domain and web_database is the same (that's stand...the clearBackups() function get called after web backup and after db backup with the backup_copies value from web_domain and web_database.
There is no problem if the backup_copies in web_domain and web_database is the same (that's standard)
But if backup_copies form web_domain and web_database is different the the clearBackups delete all backups to the lower backup_copies value.3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6466Wrong Database Right when using auto-installer + Correction2023-05-21T20:09:01ZMonet GuillaumeWrong Database Right when using auto-installer + CorrectionWhen you use a multi-servers installation :
Since the last patch of auto-installer you have this error :
```
ERROR 1142 (42000) at line 1: INSERT command denied to user 'ispcsrvXX'@'XXX' for table `dbispconfig`.`server_php`
[ERROR] Exc...When you use a multi-servers installation :
Since the last patch of auto-installer you have this error :
```
ERROR 1142 (42000) at line 1: INSERT command denied to user 'ispcsrvXX'@'XXX' for table `dbispconfig`.`server_php`
[ERROR] Exception occured: ISPConfigOSException -> Command mysql --host=XXXXX --user=ispcsrvXX --password=XXX -e 'INSERT IGNORE INTO `dbispconfig`.`server_php`
```
It can be resolve by adding insert right for slave user in **installer_base.lib.php** line 809
```
$query = "GRANT SELECT, INSERT ON ?? TO ?@?";
if ($verbose){
echo $query ."\n";
}
if(!$this->dbmaster->query($query, $value['db'] . '.server_php', $value['user'], $host)) {
$this->warning('Unable to set rights of user in master database: '.$value['db']."\n Query: ".$query."\n Error: ".$this->dbmaster->errorMessage);
}
```3.2.10