ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2019-10-09T14:15:50Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5415Insufficient CSRF check for delete actions2019-10-09T14:15:50ZTill BrehmInsufficient CSRF check for delete actionsWhile Edit actions are protected correctly, delete actions in ISPConfig were not protected against CSRF attacks.
This issue has been reported to us by RACK911 LABS.While Edit actions are protected correctly, delete actions in ISPConfig were not protected against CSRF attacks.
This issue has been reported to us by RACK911 LABS.3.1.15p1Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6126Add mail_plugins to separate dovecot config file which is included earlier2021-05-21T12:35:34ZThomAdd mail_plugins to separate dovecot config file which is included earlierUpdate: mail_plugins (and postmaster address?) are refered to in the service blocks from the ISPConfig template. A script should grab them from the conf-custom file, comment them out in the `99-ispconfig-custom-config.conf` file and add ...Update: mail_plugins (and postmaster address?) are refered to in the service blocks from the ISPConfig template. A script should grab them from the conf-custom file, comment them out in the `99-ispconfig-custom-config.conf` file and add them to a new file `98-ispconfig-custom-config.conf` or something like that. This file should be included in the ISPConfig template before the service blocks.
~~I am now looking to the code of !1459 - This will break the implementation~~
~~Because it is included earlier, values after it will override the custom config, but the custom config should override the config in dovecot.conf ofcourse.
I tested the order before the original MR.~~
~~$mail_plugins should be added, that's good!~~https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5789Backup downloads and restores are counted in user quota2022-02-26T20:44:48ZWebsliceBackup downloads and restores are counted in user quotaIn our situation a user has a 1GB quota. They have used 700MB, and they backup tarball is 400MB. In the panel they attempt to download a backup. The backup file is copied to their home directory, and the chown is attempted as per https:/...In our situation a user has a 1GB quota. They have used 700MB, and they backup tarball is 400MB. In the panel they attempt to download a backup. The backup file is copied to their home directory, and the chown is attempted as per https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/3.1.15p2/server/plugins-available/backup_plugin.inc.php#L88 . The chown fails because it would exceed the user quota. As a result, the file cannot be downloaded by the user because it is not owned by them, and the permissions are 600 (which is correct).
It seems it would be good to somehow exclude these backup files from the user quotas. Does a feature like that already exist, and if not, what would be a good solution?Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5683webalizer exec -> safe_exec2020-07-31T06:58:29ZJesse Norellwebalizer exec -> safe_execSee https://www.howtoforge.com/community/threads/warning-150-webalizer-inc-php-exec-expects-at-most-3-parameters-4-given.84849/See https://www.howtoforge.com/community/threads/warning-150-webalizer-inc-php-exec-expects-at-most-3-parameters-4-given.84849/3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5682Wrong page after user settings save2020-07-30T14:12:02ZTorsten WidmannWrong page after user settings saveLatest Git-Stable:
can't switch Language in User Menu
Latest Git-Stable:
can't switch Language in User Menu
3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5681mysql-verify_recipients.cf owner/permissions2020-07-30T12:53:48ZJesse Norellmysql-verify_recipients.cf owner/permissionsI updated a machine to git-stable this morning and found `/etc/postfix/mysql-verify_recipients.cf` was created with owner root:root and perm 600 - that needs to be root:postfix and 640.
Maybe this is just me? I compared with `mysql-vir...I updated a machine to git-stable this morning and found `/etc/postfix/mysql-verify_recipients.cf` was created with owner root:root and perm 600 - that needs to be root:postfix and 640.
Maybe this is just me? I compared with `mysql-virtual_alias_domains.cf` which was correct, and don't see any differences in how the file is handled. Someone else should check though and confirm.3.2Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/56803.1dev: Can't save mailbox when send outgoing copy to is empty2020-07-30T08:20:50ZThom3.1dev: Can't save mailbox when send outgoing copy to is empty![image](/uploads/d04299b383be5aa676180843025d5315/image.png)![image](/uploads/d04299b383be5aa676180843025d5315/image.png)3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5678Latest Git Stable - Unable to choose PHP Version2020-07-30T07:42:16ZTorsten WidmannLatest Git Stable - Unable to choose PHP VersionWith latest Git-Stable it's not possible to choose a PHP Version. It stucks on last one.With latest Git-Stable it's not possible to choose a PHP Version. It stucks on last one.3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5662installer (gentoo) $dovecot_version empty2020-07-27T14:40:58ZChristianinstaller (gentoo) $dovecot_version emptyinstall/dist/lib/gentoo.lib.php
SEARCH
```
version_compare
```
ADD BEFORE
```
//* Get the dovecot version
exec('dovecot --version', $tmp);
$dovecot_version = $tmp[0];
unset($tmp);
```
copied from install/dist/lib/debian60.lib.phpinstall/dist/lib/gentoo.lib.php
SEARCH
```
version_compare
```
ADD BEFORE
```
//* Get the dovecot version
exec('dovecot --version', $tmp);
$dovecot_version = $tmp[0];
unset($tmp);
```
copied from install/dist/lib/debian60.lib.php3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5657cron_debug.php script broken, calls some non existing cronjob functions.2020-07-03T13:47:10ZJesse Norellcron_debug.php script broken, calls some non existing cronjob functions.All cronjobs (or the base 'cronjob' class') need an isRunning() function added or they can't be run manually:
```# php /usr/local/ispconfig/server/cron_debug.php --cronjob=100-monitor_email_quota.inc.php
PH...All cronjobs (or the base 'cronjob' class') need an isRunning() function added or they can't be run manually:
```# php /usr/local/ispconfig/server/cron_debug.php --cronjob=100-monitor_email_quota.inc.php
PHP Fatal error: Uncaught Error: Call to undefined method cronjob_monitor_email_quota::isRunning() in /usr/local/ispconfig/server/cron_debug.php:76
Stack trace:
#0 {main}
thrown in /usr/local/ispconfig/server/cron_debug.php on line 76
```
Cf. https://git.ispconfig.org/ispconfig/ispconfig3/-/commit/b34b1ad5bbc8d75db927116b517e6a23761e42bb#8d6419c0e5202932371f39681470bffbf20e7346_65_763.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5652Crontab deletion after website removal2020-07-24T12:47:50ZBrianCrontab deletion after website removalHey, when deleting website which has created any crontab I got error "Parent domain not found" which is triggered by cron_plugin.inc.php, function delete, wherein the beginning is
```
//* get data from web
$parent_domain = $app->db->que...Hey, when deleting website which has created any crontab I got error "Parent domain not found" which is triggered by cron_plugin.inc.php, function delete, wherein the beginning is
```
//* get data from web
$parent_domain = $app->db->queryOneRecord("SELECT `domain_id`, `system_user`, `system_group`, `document_root`, `hd_quota` FROM `web_domain` WHERE `domain_id` = ?", $data["old"]["parent_domain_id"]);
if(!$parent_domain["domain_id"]) {
$app->log("Parent domain not found", LOGLEVEL_WARN);
return 0;
}
```
The query is empty of course because the record was deleted already when the website was deleted from GUI.
The problem is, when crontab is not deleted and it contains username assigned for a deleted website, this user is no longer available in the system and other crons after this crontab file (in alphabet order) stop working.
The expected behaviour is the deletion of crontab file when deleting a website from WebGUI.3.2Marius BurkardMarius Burkardhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5648Directories of sub- or aliasdomains (vhost) owned by root2020-07-24T09:32:11ZWHODirectories of sub- or aliasdomains (vhost) owned by root## short description
When creating a sub- or aliasdomains (vhost) with **multiple** directories like this
![Bildschirmfoto_2020-06-17_um_10.19.28](/uploads/7065ab8e569a058d859fd91b3a70f13e/Bildschirmfoto_2020-06-17_um_10.19.28.png)
the...## short description
When creating a sub- or aliasdomains (vhost) with **multiple** directories like this
![Bildschirmfoto_2020-06-17_um_10.19.28](/uploads/7065ab8e569a058d859fd91b3a70f13e/Bildschirmfoto_2020-06-17_um_10.19.28.png)
the first directory "b" belongs to root:
![Bildschirmfoto_2020-06-17_um_10.20.54](/uploads/fe65682082fba5a2790673cfc4363e44/Bildschirmfoto_2020-06-17_um_10.20.54.png)
When deleting the sub- or aliasdomains (vhost) in ISP, the directories still exist and can't be deleted by account user
## correct behaviour
Directories should belong to account user otherwise they can't be deleted
or should be deleted when deleting a sub- or aliasdomain(?)
## environment
Server OS: Debian
Server OS version: Buster
ISPConfig version: 3.1.15p33.2Marius BurkardMarius Burkardhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5624Failed to make backup of web files, because of unknown backup format gzip (IS...2020-05-29T09:48:38ZPatrick SchlesingerFailed to make backup of web files, because of unknown backup format gzip (ISPConfig dev version)## short description
After updating the ISPConfig installation on a mutiserver setup the manual and automatic backups do not work anymore.
## environment
```
Operating System: Debian 10.0 (Buster)
```
```
Version: ispconfig3-stable-3...## short description
After updating the ISPConfig installation on a mutiserver setup the manual and automatic backups do not work anymore.
## environment
```
Operating System: Debian 10.0 (Buster)
```
```
Version: ispconfig3-stable-3.1-e69a5b3f683d75e782613577f89e5be3e97d4f27
```
```
nginx version: nginx/1.14.2
```
```
gzip 1.9
```
```
# which gzip
/usr/bin/gzip
```
```
PHP 7.3.18-1+0~20200514.58+debian10~1.gbp12fa4f
```
## log entries
```
28.05.2020-22:27 - DEBUG - Triggered backup routine for domain id 8, action name backup_web_files
28.05.2020-22:27 - DEBUG - safe_exec cmd: mount 2>/dev/null | grep ' on /backup type ' - return code: 0
28.05.2020-22:27 - ERROR - Failed to make backup of web files, because of unknown backup format gzip for website domain.de
28.05.2020-22:27 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
```3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5620"Use SMTP to send system mails" should work with default smtp settings2020-06-09T05:47:06ZJesse Norell"Use SMTP to send system mails" should work with default smtp settingsIf you check the "Use SMTP to send system mails" checkbox and leave the other smtp settings the same, password reset emails stop working and there is no error/indication when this happens. Using 'localhost' as a server name in particula...If you check the "Use SMTP to send system mails" checkbox and leave the other smtp settings the same, password reset emails stop working and there is no error/indication when this happens. Using 'localhost' as a server name in particular should be allowed, as that is the default.
https://www.howtoforge.com/community/threads/password-reset-email-not-sent.84349/3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5616PHP-FPM fails after too many restarts2022-02-26T21:12:41ZGuillaume SubironPHP-FPM fails after too many restarts## short description
I deleted some shell users. After a few seconds, php7.4-fpm stopped and remained failed.
Here is the syslog, which explains why php7.4-fpm failed.
```
May 8 11:49:01 myhost systemd[1]: php7.4-fpm.service: Succeed...## short description
I deleted some shell users. After a few seconds, php7.4-fpm stopped and remained failed.
Here is the syslog, which explains why php7.4-fpm failed.
```
May 8 11:49:01 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:01 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:02 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:02 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Succeeded.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Start request repeated too quickly.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Failed with result 'start-limit-hit'.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Start request repeated too quickly.
May 8 11:49:03 myhost systemd[1]: php7.4-fpm.service: Failed with result 'start-limit-hit'.
May 8 11:49:04 myhost systemd[1]: php7.4-fpm.service: Start request repeated too quickly.
May 8 11:49:04 myhost systemd[1]: php7.4-fpm.service: Failed with result 'start-limit-hit'.
```
And here is anonymized ISPConfig log:
```
08.05.2020-11:49 - DEBUG - Found 9 changes, starting update process.
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web119' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web119/home/user1/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web119' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user1' ; userdel -f 'user1' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user1
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user1
08.05.2020-11:49 - DEBUG - Processed datalog_id 6957
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web121' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web121/home/user2/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web121' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user2' ; userdel -f 'user2' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user2
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user2
08.05.2020-11:49 - DEBUG - Processed datalog_id 6958
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web124' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web124/home/user3/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web124' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user3' ; userdel -f 'user3' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user3
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user3
08.05.2020-11:49 - DEBUG - Processed datalog_id 6959
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web144' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web144/home/user4/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web144' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user4' ; userdel -f 'user4' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user4
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user4
08.05.2020-11:49 - DEBUG - Processed datalog_id 6960
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web163' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web163/home/user5/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web163' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user5' ; userdel -f 'user5' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user5
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user5
08.05.2020-11:49 - DEBUG - Processed datalog_id 6961
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web122' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web122/home/user6/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web122' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user6' ; userdel -f 'user6' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user6
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user6
08.05.2020-11:49 - DEBUG - Processed datalog_id 6962
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web81' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web81/home/user7/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web81' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user7' ; userdel -f 'user7' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user7
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user7
08.05.2020-11:49 - DEBUG - Processed datalog_id 6963
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web50' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web50/home/user8/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web50' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user8' ; userdel -f 'user8' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user8
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user8
08.05.2020-11:49 - DEBUG - Processed datalog_id 6964
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_base_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web166' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: rm -rf '/var/www/clients/client1/web166/home/user9/.ssh' - return code: 0
08.05.2020-11:49 - DEBUG - safe_exec cmd: chattr -i '/var/www/clients/client1/web166' - return code: 0
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl stop php7.4-fpm.service
08.05.2020-11:49 - DEBUG - safe_exec cmd: killall -u 'user9' ; userdel -f 'user9' &> /dev/null - return code: 0
08.05.2020-11:49 - DEBUG - Deleted shelluser: user9
08.05.2020-11:49 - DEBUG - Calling function 'restartPHP_FPM' from module 'web_module'.
08.05.2020-11:49 - DEBUG - Restarting php-fpm: systemctl start php7.4-fpm.service
08.05.2020-11:49 - DEBUG - Calling function 'delete' from plugin 'shelluser_jailkit_plugin' raised by event 'shell_user_delete'.
08.05.2020-11:49 - DEBUG - Jailkit Plugin -> delete username:user9
08.05.2020-11:49 - DEBUG - Processed datalog_id 6965
08.05.2020-11:49 - DEBUG - Remove Lock: /usr/local/ispconfig/server/temp/.ispconfig_lock
```
## environment
Server OS: Debian 10 "Buster"
ISPConfig version: 3.1.15p3
## proposed fix
It seems tunning Systemd (https://www.freedesktop.org/software/systemd/man/systemd.unit.html#StartLimitIntervalSec=interval) could avoid this, but I don't think this is the right solution, and I don't want to edit the systemd unit for every FPM version.
I think ISPConfig should be careful not to restart the same PHP-FPM too many times in a row.
Thanks.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5614Fix home initialization for Jailkit (incl. Fix)2020-08-26T16:19:06ZTill BrehmFix home initialization for Jailkit (incl. Fix)The previous dir (without `./home/$user`) causes usermod to crash when some FPM processes are already launched for the UID (in `server/scripts/create_jailkit_user.sh`), so jk_jailuser is not able to detect the home inside the jail, inser...The previous dir (without `./home/$user`) causes usermod to crash when some FPM processes are already launched for the UID (in `server/scripts/create_jailkit_user.sh`), so jk_jailuser is not able to detect the home inside the jail, inserting an empty one in the passwd file, and causing an error when the user want to connect via SSH for example.
https://git.ispconfig.org/ispconfig/ispconfig3/-/merge_requests/7953.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5613Adding zones to PowerDNS with 'notified_serial' set breaks native DNS replica...2020-05-08T08:31:14ZMichael WeißAdding zones to PowerDNS with 'notified_serial' set breaks native DNS replication## short description
When creating a new zone, the powerdns-plugin inserts the domain with the field "notified_serial" set to the inital serial from SOA. Therefore the pdns server does not notify any slaves since notified_serial == curre...## short description
When creating a new zone, the powerdns-plugin inserts the domain with the field "notified_serial" set to the inital serial from SOA. Therefore the pdns server does not notify any slaves since notified_serial == current serial from soa. This breaks zone replication to e.g. bind slaves.
## correct behaviour
Leave out "notified_serial" when adding a new zone or set it explicitly to NULL.
## environment
Any.
## proposed fix
server/plugins-available/powerdns_plugin.inc.php: 137,16
$app->db->query("INSERT INTO powerdns.domains (name, type, ispconfig_id) VALUES (?, ?, ?)", $origin, 'MASTER', $ispconfig_id);https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5608[rspamd] DKIM check not working when switching from amavis to rspamd (CentOS7)2022-04-26T17:53:27ZJanThiel[rspamd] DKIM check not working when switching from amavis to rspamd (CentOS7)## short description
As described in this topic already, the dkim_signing.conf is not created in the rspamd config folder ( /etc/rspamd/local.d/ ) when you switch from amavisd to rspam. The _rspamd user also needs to be added to the amav...## short description
As described in this topic already, the dkim_signing.conf is not created in the rspamd config folder ( /etc/rspamd/local.d/ ) when you switch from amavisd to rspam. The _rspamd user also needs to be added to the amavis group (though I didn't check if this really was missing, before simply adding it :-/)
Thus rspamd is not able to find the dkim keys and throws warnings in the log.
```
dkim_module_load_key_format: cannot load dkim key /var/lib/rspamd/dkim/[DOMAIN].dkim.key: cannot stat key file: '/var/lib/rspamd/dkim/[DOMAIN].dkim.key' File or folder not found
```
https://www.howtoforge.com/community/threads/rspamd-greylist-dkim-keys-not-loaded.82823/#post-395279
## correct behaviour
DKIM files should be read from existing amavisd folder without manual intervention and configuration
## environment
Server OS: centos 7
ISPConfig version: 3.1.15p3
## proposed fix
- _rspamd user should be added to group amavisd
- **/etc/rspamd/local.d/dkim_signing.conf** should be created with the following content:
```
try_fallback = false;
path_map = "/etc/rspamd/local.d/dkim_domains.map";
selector_map = "/etc/rspamd/local.d/dkim_selectors.map";
```https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5607Clicking from search result alias/child domain fails to open2020-07-08T19:06:50ZHelmoClicking from search result alias/child domain fails to openWhen you use the search function to look for an alias or child domain it shows the result but clicking the link fails to open.
With the Firefox developer tools I noticed that the https response was 'redirect contains unallowed chars.'
...When you use the search function to look for an alias or child domain it shows the result but clicking the link fails to open.
With the Firefox developer tools I noticed that the https response was 'redirect contains unallowed chars.'
It tries to load `capp.php?mod=sites&redirect=sites/web_childdomain_edit.php%3Fid%3D291%26type%3Daliasdomain`
The `%26` in there is the & char, from the extra 'type=aliasdomain' parameter. Regular domains only get the `id` parameter.
The patch below is a quick fix to allow the extra `type` parameter. Would that be sufficient?
```patch
diff --git a/interface/web/capp.php b/interface/web/capp.php
index 39392691f..5d49fe80d 100755
--- a/interface/web/capp.php
+++ b/interface/web/capp.php
@@ -43,7 +43,7 @@ if($_SESSION["s"]["user"]['active'] != 1) {
}
if(!preg_match("/^[a-z]{2,20}$/i", $mod)) die('module name contains unallowed chars.');
-if($redirect != '' && !preg_match("/^[a-z0-9]+\/[a-z0-9_\.\-]+\?id=[0-9]{1,9}$/i", $redirect)) die('redirect contains unallowed chars.');
+if($redirect != '' && !preg_match("/^[a-z0-9]+\/[a-z0-9_\.\-]+\?id=[0-9]{1,9}(\&type=[a-z0-9_\.\-]+)?$/i", $redirect)) die('redirect contains unallowed chars.');
//* Check if user may use the module.
$user_modules = explode(",", $_SESSION["s"]["user"]["modules"]);
```3.2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5602mailman images not showing [nginx fix]2020-07-24T09:25:55ZBarretmailman images not showing [nginx fix]The images on the bottom of the web interface are not showing,
The problem is located in `000-apps.vhost` at the mailman image directive.
Nginx fix:
```
#location /images/mailman {
# alias /usr/share/images/mail...The images on the bottom of the web interface are not showing,
The problem is located in `000-apps.vhost` at the mailman image directive.
Nginx fix:
```
#location /images/mailman {
# alias /usr/share/images/mailman;
#}
location ^~ /images/mailman {
alias /usr/share/images/mailman;
}
```
Running ISPConfig 3.1.15p3 on Debian 10 using Nginx3.2Marius BurkardMarius Burkard