Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I ISPConfig 3
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 554
    • Issues 554
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISPConfig
  • ISPConfig 3
  • Issues
  • #354
Closed
Open
Created Jan 21, 2009 by skeldof@skeldof

Bug r879 php CGI wrapper?

I was looking at the recent SVN commits and think there's something off in r879: $cgi_config["cgi_starter_path"] = "/var/www/php-cgi-scripts/[system_user]/";

Shouldn't the system_user be expanded to $data["new"]["system_user"]? Otherwise all php-cgi starter scripts end up in the same directory and when disabling it for one would delete for all.

--- server/plugins-available/apache2_plugin.inc.php (revision 879) +++ server/plugins-available/apache2_plugin.inc.php (working copy) @@ -551,7 +551,7 @@ { //$cgi_config = $app->getconf->get_server_config($conf["server_id"], 'cgi');

  •                   $cgi_config["cgi_starter_path"] = "/var/www/php-cgi-scripts/[system_user]/";
  •                   $cgi_config["cgi_starter_path"] = "/var/www/php-cgi-scripts/".$data["new"]["system_user"]."/";
                      $cgi_config["cgi_starter_script"] = "php-cgi-starter";
                      $cgi_config["cgi_bin"] = "/usr/bin/php-cgi";

@@ -654,7 +654,7 @@ if ($data["old"]["php"] == "cgi") { // TODO: fetch the date from the server-settings

  •                   $web_config["cgi_starter_path"] = "/var/www/php-cgi-scripts/[system_user]/";
  •                   $web_config["cgi_starter_path"] = "/var/www/php-cgi-scripts/".$data["old"]["system_user"]."/";
    
                      $cgi_starter_path = str_replace("[system_user]",$data["old"]["system_user"],$web_config["cgi_starter_path"]);
                      if (is_dir($cgi_starter_path))
Assignee
Assign to
Time tracking