The one place for your designs
To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.
invalid HTML when create new DNS SPF & DMARC record
short description
When I create a new DNS SPF or DMARC record, there is "/>" next to the "Active" checkbox, after checking the HTML, it is:
<input type="checkbox" value="1" id="active" name="active" <input=""> />
But no such problem when edit existing SPF or DMARC record.
correct behaviour
<input type="checkbox" value="1" id="active" name="active" checked="">
environment
Server OS: CentOS Server OS version: 7.3.1611 ISPConfig version: 3.1.14p2
proposed fix
Pre-defined to check checkboxes at the beginning of function onShowEnd() in /usr/local/ispconfig/interface/web/dns/dns_spf_edit.php
function onShowEnd() {
global $app, $conf;
$zone = $app->functions->intval($_GET['zone']);
// pre-defined to check checkboxes
$app->tpl->setVar("active", "CHECKED");
$app->tpl->setVar("spf_a_active", "CHECKED");
$app->tpl->setVar("spf_mx_active", "CHECKED");
//* check for an existing spf-record
$sql = "SELECT data, active FROM dns_rr WHERE data LIKE 'v=spf1%' AND zone = ? AND " . $app->tform->getAuthSQL('r');
$rec = $app->db->queryOneRecord($sql, $zone);
if ( isset($rec) && !empty($rec) ) {screenshots
