Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I ISPConfig 3
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 550
    • Issues 550
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISPConfig
  • ISPConfig 3
  • Issues
  • #5473

Closed
Open
Created Dec 04, 2019 by Webslice@webslice

Updater is not taking custom Apache configuration paths or init script into account

Originates from !926 (merged)

The update.php script is not looking at the values which are configured in System->Server Config->Web, specifically the variables:

  • vhost_conf_dir
  • vhost_conf_enabled_dir
  • apache_init_script

I think that this information is not relevant for install.php, as these values will be the default for a fresh server anyway. We could pull the server config in update.php and override the variables in $conf as needed. So roughly something like:

require_once "/usr/local/ispconfig/server/lib/app.inc.php";

$app->uses('getconf');
$web_conf = $app->getconf->get_server_config($conf['server_id'] ,'web');
if (!empty($web_conf['vhost_conf_dir']) {
    $conf['apache']['vhost_conf_dir'] = $web_conf['vhost_conf_dir'];
}
... etc

But I am having difficulty overseeing if this would be a good idea.

Could you confirm if this sounds like a potential solution to you guys? If so, I will create a PR. Also open to better places to do this.

Thank you

Edited Dec 04, 2019 by Webslice
Assignee
Assign to
Time tracking