Skip to content

GitLab

Open
Created by Webslice@webslice

Updater is not taking custom Apache configuration paths or init script into account

Originates from !926 (merged)

The update.php script is not looking at the values which are configured in System->Server Config->Web, specifically the variables:

  • vhost_conf_dir
  • vhost_conf_enabled_dir
  • apache_init_script

I think that this information is not relevant for install.php, as these values will be the default for a fresh server anyway. We could pull the server config in update.php and override the variables in $conf as needed. So roughly something like:

require_once "/usr/local/ispconfig/server/lib/app.inc.php";

$app->uses('getconf');
$web_conf = $app->getconf->get_server_config($conf['server_id'] ,'web');
if (!empty($web_conf['vhost_conf_dir']) {
    $conf['apache']['vhost_conf_dir'] = $web_conf['vhost_conf_dir'];
}
... etc

But I am having difficulty overseeing if this would be a good idea.

Could you confirm if this sounds like a potential solution to you guys? If so, I will create a PR. Also open to better places to do this.

Thank you

Edited by Webslice