Rsapmd user configuration always add header and rewrite subject regardless of SPAM tag method configured
wrong behaviour
Rsapmd user configuration generated always include add header and rewrite subject regardless of SPAM tag method configured in ISPConfig spamfilter policy.
correct behaviour
Rsapmd user configuration generated should include "add header" or/and "rewrite subject" based on SPAM tag method configured in ISPConfig spamfilter policy.
problem
The problem is causated by the code in rspamd_plugin::user_settings_update() from /server/plugins-available/rspamd_plugin.inc.php:
class rspamd_plugin {
# (...)
function user_settings_update($event_name, $data) {
# (...)
$tpl->setVar('rspamd_spam_tag_method', floatval($policy['rspamd_spam_tag_method']));
# (...)
}
}
proposed fix
rspamd_spam_tag_method is a string not a float, so it should be set like this:
class rspamd_plugin {
# (...)
function user_settings_update($event_name, $data) {
# (...)
$tpl->setVar('rspamd_spam_tag_method', $policy['rspamd_spam_tag_method']);
# (...)
}
}