Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
I
ISPConfig 3
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 480
    • Issues 480
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 22
    • Merge Requests 22
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISPConfig
  • ISPConfig 3
  • Issues
  • #6002

Closed
Open
Opened Jan 06, 2021 by Tony G@CaptainStarbuck

Sort fields in debian_postfix.conf.master

This is a suggestion/request to sort the fields in the postfix main.cf config template - and only those where sorting makes sense.

Example where sorting might not make sense:

  • Someone might prefer that the smtp_*_restrictions are sorted in order of their application, which is not alphabetical.

In the case of proxy_read_maps, which is an aggregate of other fields, it's still OK to sort this field starting with 'p' before it's included fields, like those starting with 's', because the order of the fields in the file does not matter.

Reasoning:

  • It's much easier to find a setting when it's in sorted order.
  • As a practical example, it's taken me a long time to work out the delta/diff between the most recent update (3.2.2) and my own settings. If settings are sorted it's much easier to diff tpl, conf-custom, and the main.cf files.
  • Related - I have many fields in main.cf that are not in the default template. It's much easier to see if there are related changes in the template if both the tpl and the conf-custom versions are in the same order.

If approved, I'll post a MR with a suggested sorting. This will only include the default tpl fields.

Edited Jan 07, 2021 by Tony G
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ispconfig/ispconfig3#6002