Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
I
ISPConfig 3
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 480
    • Issues 480
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 22
    • Merge Requests 22
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISPConfig
  • ISPConfig 3
  • Issues
  • #6013

Closed
Open
Opened Jan 13, 2021 by Hj Ahmad Rasyid Hj Ismail@ahrasisContributor

SSL ISPConfig Installer / Updater Code May Be Repetitive

I have been revisiting ISPConfig installer_base.lib.php as well as install.php and update.php files and I think the code with regards to SSL may be repetitive and most of them, if not all, may be avoided if the SSL request for the server and its services can be made before configure_postfix (include creation of smtpd.cert and smtpd.key) and configure_dovecot (include creation of dhparam file dh.pem).

Reading on dovecot, I think it is not necessary to use ssl-parameters.dat and convert it as dhparam file (dh.pem) even if it is meant for v2.2 as using it was only a mere suggestion to ease creating creating the same but using openssl to issue it should also work as well and pure-ftpd is using one that can be symlinked.

Since symlinks can be made to all of them whether by using self-signed or LE SSL certs or others, if it is possible to rearrange the priority in those files especially install.php and update.php, we may avoid such a repetition and may be make the install / update process a little bit faster?

A thought to be discussed further before any decision could be made.

Edited Jan 13, 2021 by Hj Ahmad Rasyid Hj Ismail
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ispconfig/ispconfig3#6013