Skip to content

site-enable symlink always created

short description

The if statement that decides when a link should be created in make_acme_vhost() is malformed so is always true

environment

Server OS: debian Server OS version: buster ISPConfig version: 3.2.3

proposed fix

Currently, the last lines in make_acme_vhost() in install/lib/installer_base.php (line 2775 of commit c40198b1) are

if(!@is_link($vhost_conf_enabled_dir.'' . $use_symlink)) {
    symlink($vhost_conf_dir.'/' . $use_name, $vhost_conf_enabled_dir.'/' . $use_symlink);
}  

I believe they should be

if(!@is_link($vhost_conf_enabled_dir.'/' . $use_symlink)) {
    symlink($vhost_conf_dir.'/' . $use_name, $vhost_conf_enabled_dir.'/' . $use_symlink);
}