Backups broken due to syntax error in backup.inc.php
Summary
Backups stopped working in ispconfig stable. /var/log/ispconfig/cron.log contains the following error:
PHP Parse error: syntax error, unexpected '(' in /usr/local/ispconfig/server/lib/classes/backup.inc.php on line 1083
The lines in the file are calling an anonymous log function and the syntax seems not supported in old PHP5.x versions:
$ php -l /usr/local/ispconfig/server/lib/classes/backup.inc.php PHP Parse error: syntax error, unexpected '(' in /usr/local/ispconfig/server/lib/classes/backup.inc.php on line 1083
Errors parsing /usr/local/ispconfig/server/lib/classes/backup.inc.php
While running the backup.inc.php with a newer PHP version (i.e. 7.4.) works fine, i.e:
$ php74 -l /usr/local/ispconfig/server/lib/classes/backup.inc.php
No syntax errors detected in /usr/local/ispconfig/server/lib/classes/backup.inc.php
From what I understand CentOS7 with default PHP5.x is STILL supported, so this should be considered a serious stable bug.
Correct behaviour
No syntax error should show up when running the backup code.
Environment
Server OS + version: CentOS7 ISPConfig version: 3.2.8p2 Software version of the related software: CentOS default PHP 5.4.16 (cli) (built: Apr 1 2020 04:07:17)