From b3735ebce048530773f7d65560be9b21e883e52d Mon Sep 17 00:00:00 2001
From: Herman van Rink <rink@initfour.nl>
Date: Tue, 25 Jul 2023 22:59:10 +0200
Subject: [PATCH] Generalize the form title to be content aware, #6545

---
 interface/lib/classes/tform_actions.inc.php         |  4 ++++
 interface/web/client/form/client.tform.php          |  1 +
 interface/web/client/form/domain.tform.php          |  1 +
 interface/web/client/form/reseller.tform.php        |  1 +
 interface/web/dns/dns_soa_edit.php                  | 10 ----------
 interface/web/dns/form/dns_soa.tform.php            |  1 +
 interface/web/mail/form/mail_domain.tform.php       |  1 +
 interface/web/mail/form/mail_user.tform.php         |  1 +
 interface/web/mail/mail_user_edit.php               | 11 -----------
 interface/web/sites/form/database.tform.php         |  1 +
 interface/web/sites/form/database_user.tform.php    |  1 +
 interface/web/sites/form/ftp_user.tform.php         |  1 +
 interface/web/sites/form/shell_user.tform.php       |  1 +
 interface/web/sites/form/web_childdomain.tform.php  |  1 +
 interface/web/sites/form/web_vhost_domain.tform.php |  1 +
 15 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/interface/lib/classes/tform_actions.inc.php b/interface/lib/classes/tform_actions.inc.php
index 0053be2663..7060fee2d3 100644
--- a/interface/lib/classes/tform_actions.inc.php
+++ b/interface/lib/classes/tform_actions.inc.php
@@ -580,6 +580,10 @@ class tform_actions {
 
 		$this->dataRecord = $record;
 
+		if(isset($app->tform->formDef['record_name_field'])) {
+			$app->tform->formDef['title'] = $app->lng($app->tform->formDef['title']) . ' ' . $this->dataRecord[$app->tform->formDef['record_name_field']];
+		}
+
 		// Userdaten umwandeln
 		$record = $app->tform->getHTML($record, $this->active_tab, 'EDIT');
 		$record['id'] = $this->id;
diff --git a/interface/web/client/form/client.tform.php b/interface/web/client/form/client.tform.php
index 3f51c20902..c373bf0a38 100644
--- a/interface/web/client/form/client.tform.php
+++ b/interface/web/client/form/client.tform.php
@@ -41,6 +41,7 @@
 $form["title"]   = "Client";
 $form["description"]    = "";
 $form["name"]   = "client";
+$form["record_name_field"] = "username";
 $form["action"]  = "client_edit.php";
 $form["db_table"] = "client";
 $form["db_table_idx"] = "client_id";
diff --git a/interface/web/client/form/domain.tform.php b/interface/web/client/form/domain.tform.php
index f521a55b2d..c96af934d7 100644
--- a/interface/web/client/form/domain.tform.php
+++ b/interface/web/client/form/domain.tform.php
@@ -63,6 +63,7 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 $form["title"]    = "Domain";
 $form["description"]  = "";
 $form["name"]    = "domain";
+$form["record_name_field"] = "domain";
 $form["action"]   = "domain_edit.php";
 $form["db_table"]  = "domain";
 $form["db_table_idx"] = "domain_id";
diff --git a/interface/web/client/form/reseller.tform.php b/interface/web/client/form/reseller.tform.php
index d48dea6229..c90b8f4a0a 100644
--- a/interface/web/client/form/reseller.tform.php
+++ b/interface/web/client/form/reseller.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "Reseller";
 $form["description"]  = "";
 $form["name"]    = "reseller";
+$form["record_name_field"] = "username";
 $form["action"]   = "reseller_edit.php";
 $form["db_table"]  = "client";
 $form["db_table_idx"] = "client_id";
diff --git a/interface/web/dns/dns_soa_edit.php b/interface/web/dns/dns_soa_edit.php
index 309a84236a..e17571e736 100644
--- a/interface/web/dns/dns_soa_edit.php
+++ b/interface/web/dns/dns_soa_edit.php
@@ -79,16 +79,6 @@ class page_action extends tform_actions {
 		parent::onShowNew();
 	}
 
-	function onShowEdit() {
-		global $app, $conf;
-
-		parent::onShowEdit();
-
-		if(isset($this->dataRecord)) {
-			$app->tform->formDef['title'] = $app->lng('DNS Zone') . ' ' . $this->dataRecord['origin'];
-		}
-	}
-
 	function onShowEnd() {
 		global $app, $conf;
 
diff --git a/interface/web/dns/form/dns_soa.tform.php b/interface/web/dns/form/dns_soa.tform.php
index 7deb109456..b9ec102d1f 100644
--- a/interface/web/dns/form/dns_soa.tform.php
+++ b/interface/web/dns/form/dns_soa.tform.php
@@ -42,6 +42,7 @@ global $app;
 $form["title"]    = "DNS Zone";
 $form["description"]  = "";
 $form["name"]    = "dns_soa";
+$form["record_name_field"] = "origin";
 $form["action"]   = "dns_soa_edit.php";
 $form["db_table"]  = "dns_soa";
 $form["db_table_idx"] = "id";
diff --git a/interface/web/mail/form/mail_domain.tform.php b/interface/web/mail/form/mail_domain.tform.php
index 4a042abf2e..7e105f97a1 100644
--- a/interface/web/mail/form/mail_domain.tform.php
+++ b/interface/web/mail/form/mail_domain.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "Mail Domain";
 $form["description"]  = "";
 $form["name"]    = "mail_domain";
+$form["record_name_field"] = "domain";
 $form["action"]   = "mail_domain_edit.php";
 $form["db_table"]  = "mail_domain";
 $form["db_table_idx"] = "domain_id";
diff --git a/interface/web/mail/form/mail_user.tform.php b/interface/web/mail/form/mail_user.tform.php
index d135e4f3de..3dd334a29c 100644
--- a/interface/web/mail/form/mail_user.tform.php
+++ b/interface/web/mail/form/mail_user.tform.php
@@ -51,6 +51,7 @@ if(!$app->auth->is_admin()) {
 $form["title"]    = "Mailbox";
 $form["description"]  = "";
 $form["name"]    = "mail_user";
+$form["record_name_field"] = "email";
 $form["action"]   = "mail_user_edit.php";
 $form["db_table"]  = "mail_user";
 $form["db_table_idx"] = "mailuser_id";
diff --git a/interface/web/mail/mail_user_edit.php b/interface/web/mail/mail_user_edit.php
index e435f6ab96..975133fdc4 100644
--- a/interface/web/mail/mail_user_edit.php
+++ b/interface/web/mail/mail_user_edit.php
@@ -67,17 +67,6 @@ class page_action extends tform_actions {
 		parent::onShowNew();
 	}
 
-	function onShowEdit() {
-		global $app, $conf;
-
-		parent::onShowEdit();
-
-		if(isset($this->dataRecord)) {
-			$app->tform->formDef['title'] = $app->lng('Mailbox') . ' ' . $this->dataRecord['email'];
-		}
-	}
-
-
 	function onShowEnd() {
 		global $app, $conf;
 
diff --git a/interface/web/sites/form/database.tform.php b/interface/web/sites/form/database.tform.php
index dd3910c043..2d4785df99 100644
--- a/interface/web/sites/form/database.tform.php
+++ b/interface/web/sites/form/database.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "Database";
 $form["description"]  = "";
 $form["name"]    = "database";
+$form["record_name_field"] = "database_name";
 $form["action"]   = "database_edit.php";
 $form["db_table"]  = "web_database";
 $form["db_table_idx"] = "database_id";
diff --git a/interface/web/sites/form/database_user.tform.php b/interface/web/sites/form/database_user.tform.php
index 5f91cbd1f3..3c62fa42bb 100644
--- a/interface/web/sites/form/database_user.tform.php
+++ b/interface/web/sites/form/database_user.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "Database User";
 $form["description"]  = "";
 $form["name"]    = "database_user";
+$form["record_name_field"] = "database_user";
 $form["action"]   = "database_user_edit.php";
 $form["db_table"]  = "web_database_user";
 $form["db_table_idx"] = "database_user_id";
diff --git a/interface/web/sites/form/ftp_user.tform.php b/interface/web/sites/form/ftp_user.tform.php
index e62f5ca40a..092fc016a1 100644
--- a/interface/web/sites/form/ftp_user.tform.php
+++ b/interface/web/sites/form/ftp_user.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "FTP User";
 $form["description"]  = "";
 $form["name"]    = "ftp_user";
+$form["record_name_field"] = "username";
 $form["action"]   = "ftp_user_edit.php";
 $form["db_table"]  = "ftp_user";
 $form["db_table_idx"] = "ftp_user_id";
diff --git a/interface/web/sites/form/shell_user.tform.php b/interface/web/sites/form/shell_user.tform.php
index 523a03687a..d4230e1f0a 100644
--- a/interface/web/sites/form/shell_user.tform.php
+++ b/interface/web/sites/form/shell_user.tform.php
@@ -41,6 +41,7 @@
 $form["title"]    = "Shell User";
 $form["description"]  = "";
 $form["name"]    = "shell_user";
+$form["record_name_field"] = "username";
 $form["action"]   = "shell_user_edit.php";
 $form["db_table"]  = "shell_user";
 $form["db_table_idx"] = "shell_user_id";
diff --git a/interface/web/sites/form/web_childdomain.tform.php b/interface/web/sites/form/web_childdomain.tform.php
index 36718f5c9d..a8fe73ebc2 100644
--- a/interface/web/sites/form/web_childdomain.tform.php
+++ b/interface/web/sites/form/web_childdomain.tform.php
@@ -43,6 +43,7 @@ if(isset($_SESSION['s']['var']['childdomain_type']) && $_SESSION['s']['var']['ch
 $form["title"]    = ($childdomain_type == 'subdomain' ? "Subdomain" : 'Web Aliasdomain');
 $form["description"]  = "";
 $form["name"]    = "web_childdomain";
+$form["record_name_field"] = "domain";
 $form["action"]   = "web_childdomain_edit.php";
 $form["db_table"]  = "web_domain";
 $form["db_table_idx"] = "domain_id";
diff --git a/interface/web/sites/form/web_vhost_domain.tform.php b/interface/web/sites/form/web_vhost_domain.tform.php
index ba0d86f3eb..c773df1334 100644
--- a/interface/web/sites/form/web_vhost_domain.tform.php
+++ b/interface/web/sites/form/web_vhost_domain.tform.php
@@ -60,6 +60,7 @@ if(isset($_SESSION['s']['var']['vhostdomain_type'])) {
 $form["title"]    = $form_title;
 $form["description"]  = "";
 $form["name"]    = "web_vhost_domain";
+$form["record_name_field"] = "domain";
 $form["action"]   = "web_vhost_domain_edit.php";
 $form["db_table"]  = "web_domain";
 $form["db_table_idx"] = "domain_id";
-- 
GitLab