ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2024-02-15T11:42:55Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6637DNS import, add external NS as default2024-02-15T11:42:55ZHelmoDNS import, add external NS as defaultWhen the DNS zone importer adds default dns records it only can add servers managed by ispconfig.
But my slave dns is not managed by ispconfig, so I'd like to add a field for extra nameservers.When the DNS zone importer adds default dns records it only can add servers managed by ispconfig.
But my slave dns is not managed by ispconfig, so I'd like to add a field for extra nameservers.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6636DNS import, option to ignore NS records2024-02-15T11:42:55ZHelmoDNS import, option to ignore NS recordsWhen importing a DNS zone it will often be in a migration scenario where the zone should get a new NS record anyway.
I'm adding a checkbox to ignore any NS records in the file, and let the import create default NS records.When importing a DNS zone it will often be in a migration scenario where the zone should get a new NS record anyway.
I'm adding a checkbox to ignore any NS records in the file, and let the import create default NS records.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6632Disable FastCGI option on newly installed systems2024-01-23T22:58:24ZThomDisable FastCGI option on newly installed systems3.2.12ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6630Remove Pagespeed support2024-03-12T17:40:11ZMichaelRemove Pagespeed supportThe Pagespeed project (Apache module as well as Nginx) has not been maintained since at least 30. June 2022 and the Git repositories have been archived.
I therefore suggest removing Pagespeed.
Maybe it is possible to "substitute" Pa...The Pagespeed project (Apache module as well as Nginx) has not been maintained since at least 30. June 2022 and the Git repositories have been archived.
I therefore suggest removing Pagespeed.
Maybe it is possible to "substitute" Pagespeed with Google's Lighthouse some day in the future which provides a similar set of features, except that the website owner has to manually make the adjustments to his website.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6627Wrong CNAME DNS Validation2024-01-10T07:04:45Zteuto.netWrong CNAME DNS ValidationThe current cname validation only checks if there is already an entry with the same name.
There i no validation for DNS entry's like name.origin.The current cname validation only checks if there is already an entry with the same name.
There i no validation for DNS entry's like name.origin.teuto.netteuto.nethttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6626Mirror server IP not automatically added to database Remote Access IPs list2024-01-09T19:17:02ZHelmoMirror server IP not automatically added to database Remote Access IPs listThe webserver's IP is auto added to the list of Remote Access IPs when the database is not on the same host.
However when that host has a mirror server those IP's are not added. MR incoming ...
It annoyed me that a huge chunk of code w...The webserver's IP is auto added to the list of Remote Access IPs when the database is not on the same host.
However when that host has a mirror server those IP's are not added. MR incoming ...
It annoyed me that a huge chunk of code was duplicated there so I first created #6625HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6625De-duplicate onBeforeUpdate and onBeforeInsert in database_edit.php2024-01-09T19:17:19ZHelmoDe-duplicate onBeforeUpdate and onBeforeInsert in database_edit.phpIt annoyed me that a huge chunk of code was duplicated between onBeforeUpdate() and onBeforeInsert() in database_edit.php, and a few subtle differences had already crept up... bugs.
E.g. on Insert we were not checking is a database_user...It annoyed me that a huge chunk of code was duplicated between onBeforeUpdate() and onBeforeInsert() in database_edit.php, and a few subtle differences had already crept up... bugs.
E.g. on Insert we were not checking is a database_user was filled in, but in the update method we call an error database_user_missing_txt for it.HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6623LDAP Acces feature request2023-12-27T08:51:18ZImad DaouLDAP Acces feature requestDear ISPConfig Team,
Is there a way to have ISPConfig works with LDAP the way OPNSense does?
https://docs.opnsense.org/manual/how-tos/user-ldap.html
That would be great, this way we can have Enterprise LDAP platform like Active direc...Dear ISPConfig Team,
Is there a way to have ISPConfig works with LDAP the way OPNSense does?
https://docs.opnsense.org/manual/how-tos/user-ldap.html
That would be great, this way we can have Enterprise LDAP platform like Active directory use ISPConfig for mailboxes; I strongly believe ISPConfig can do great at the enterprise level, especially if AD users can use ISPConfig for mailboxes.
Thank you!https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6622Change in system requirements for ISPConfig 3.2.122023-12-13T19:54:28ZTill BrehmChange in system requirements for ISPConfig 3.2.12The following system requirements will change with the release of ISPConfig 3.2.12:
- The min. PHP version will change from PHP 5.4 to PHP 7.0.
- The PHP OpenSSL Module is required.The following system requirements will change with the release of ISPConfig 3.2.12:
- The min. PHP version will change from PHP 5.4 to PHP 7.0.
- The PHP OpenSSL Module is required.3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6621Logs showing localhost (127.0.0.1) instead of HTTP_X_FORWARDED_FOR when using...2024-01-09T21:31:11ZTim de BoerLogs showing localhost (127.0.0.1) instead of HTTP_X_FORWARDED_FOR when using a proxy to ISPconfig## Summary
When using a proxy Vhost in front of the ISPconfig control panel, the logs shows;
`Successful login for user 'username' from 127.0.0.1 at 2023-12-11 19:17:16 with session ID <randomID>`
## Steps to reproduce
1. Create a Vh...## Summary
When using a proxy Vhost in front of the ISPconfig control panel, the logs shows;
`Successful login for user 'username' from 127.0.0.1 at 2023-12-11 19:17:16 with session ID <randomID>`
## Steps to reproduce
1. Create a Vhost that proxies the `:8080` ISPconfig
2. Login via the proxied version
3. Watch `/var/log/ispconfig/auth.log`
## Correct behaviour
It should show the following;
`Successful login for user 'username' from X.X.X.X at 2023-12-11 19:17:16 with session ID <randomID>`, where `X.X.X.X` is the real IP.
## Environment
Server OS + version: Debian 11\
ISPConfig version: 3.2.11p1
## Proposed fix
Use `$_SERVER['HTTP_X_FORWARDED_FOR']` when set.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6620Restart memcached after a backup restore2023-12-10T16:24:09ZSergioRestart memcached after a backup restoreHi,
Working on WordPress (but I assume it's happening on other applications) happens that when I restore from a backup, some options remain in the state before the restore. This happens because the old data is still in memcached (if enab...Hi,
Working on WordPress (but I assume it's happening on other applications) happens that when I restore from a backup, some options remain in the state before the restore. This happens because the old data is still in memcached (if enabled). So I believe that after restoring a backup ISPConfig should automatically restart memcached so that the queries left in memory are deleted. If possible, it would also good to have some sort of feedback when the restore is complete.
Thank you for all your great work.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6618Remove accidental quotes around a DNS record.2023-12-10T17:57:16ZHelmoRemove accidental quotes around a DNS record.I had someone copy/pasting dns data ... which accidentally included `"`'s around it.
This did not resolve as expected. A simple patch solves that.I had someone copy/pasting dns data ... which accidentally included `"`'s around it.
This did not resolve as expected. A simple patch solves that.HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6617Show DKIM status when editing mail_domain2024-03-26T09:51:12ZHelmoShow DKIM status when editing mail_domainSimilar to #6539 I would like to show the user what the DKIM dns status is. E.g. if the dns record is resolving OK.
This should also help to detect copy/paste errors when using external DNS.
The OK state:
![image](/uploads/4554cceb7f7f...Similar to #6539 I would like to show the user what the DKIM dns status is. E.g. if the dns record is resolving OK.
This should also help to detect copy/paste errors when using external DNS.
The OK state:
![image](/uploads/4554cceb7f7f5c02aa2da8360fc9db0f/image.png)
For a not added to DNS state:
![image](/uploads/adebce3ce00ab90f362f5109eb80a095/image.png)
For a failure scenario:
![image](/uploads/442b3b21d636873ca3541c9ceae19c4e/image.png)
This icon might be a bit too subtle? Thoughts?HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6616Question for creating SSL cert when updating2023-12-03T21:37:14ZThomQuestion for creating SSL cert when updating* Set default to no when updating (always)
* Fix format: `Do you want to create SSL certs for your server? (yes,no) [no]:` instead of `Do you want to create SSL certs for your server? (y,n) [y]:`* Set default to no when updating (always)
* Fix format: `Do you want to create SSL certs for your server? (yes,no) [no]:` instead of `Do you want to create SSL certs for your server? (y,n) [y]:`3.2.12ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6615Add New Prefix Type CUSTOMERNO2023-12-03T16:44:36ZChristopher KaschigAdd New Prefix Type CUSTOMERNO\[This is a feature request but even with following the link 'http://bugtracker.ispconfig.org/index.php?do=newtask&project=3&task_type=2' I am not able to get a non-issue ticke inserted here - sorry\]
I know / assume I could remove the ...\[This is a feature request but even with following the link 'http://bugtracker.ispconfig.org/index.php?do=newtask&project=3&task_type=2' I am not able to get a non-issue ticke inserted here - sorry\]
I know / assume I could remove the prefixes in whole by modifying the FTP user prefix (eg) in the Main Config. But I am a fan of automatisms, as they reduce faulty input.
For this I would like to suggest - in addition to existing 'CLIENTNAME', 'CLIENTID', 'DOMAINID' - a new prefix key 'CUSTOMERNO', which replaces the keyword \[CUSTOMERNO\] by the customer number of the current selected (or user assigned) client.
Following changes work for me, but I would really prefer if this could be adjusted to fit into ISPConfig development best practices:
\[modifiying **/interface/lib/classes/tools_sites.inc.php**\]
\[line 37\]
old:
```plaintext
$keywordlist=array('CLIENTNAME', 'CLIENTID', 'DOMAINID');
```
new:
```plaintext
$keywordlist=array('CLIENTNAME', 'CLIENTID', 'DOMAINID', 'CUSTOMERNO');
```
\[line 40 foreach added case\]
```plaintext
case 'CUSTOMERNO':
$name=str_replace('['.$keyword.']', $this->getCustomerNo($dataRecord), $name);
break;
```
\[new\]
```plaintext
function getCustomerNo($dataRecord) {
global $app, $conf;
$clientId=$this->getClientID($dataRecord);
if ($clientId == '[CLIENTID]') {
return '[CUSTOMERNO]';
} elseif ($clientId == '') {
return 'default';
}
$tmp = $app->db->queryOneRecord("SELECT customer_no FROM client WHERE client_id = ?", $clientId);
$customerNo = $tmp['customer_no'];
if ($customerNo == '') $customerNo = 'default';
$customerNo = $this->convertCustomerNo($customerNo);
return $customerNo;
}
```
\[new - duplicated from function convertClientName for further flexibility, not necessarily needed to be a separate function\]
```plaintext
function convertCustomerNo($customerNo){
$allowed = 'abcdefghijklmnopqrstuvwxyz0123456789_';
$res = '';
$customerNo = strtolower(trim($customerNo));
for ($i=0; $i < strlen($customerNo); $i++){
if ($customerNo[$i] == ' ') continue;
if (strpos($allowed, $customerNo[$i]) !== false){
$res .= $customerNo[$i];
}
else {
$res .= '_';
}
}
return $res;
}
```https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6609Make website http and https port configurable for Apache servers2023-11-19T17:48:23ZTill BrehmMake website http and https port configurable for Apache serversThe website ports are already configurable for Nginx on the options tab. This request is to port this feature to the Apache plugin too.The website ports are already configurable for Nginx on the options tab. This request is to port this feature to the Apache plugin too.3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6608Set account in certbot if multiple accounts are present2023-11-18T12:44:55ZTill BrehmSet account in certbot if multiple accounts are presenthttps://forum.howtoforge.com/threads/playing-with-debian-12-some-issues.91311/page-3https://forum.howtoforge.com/threads/playing-with-debian-12-some-issues.91311/page-33.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6604Enhance ssh keys textarea with Javascript2024-03-27T14:27:09ZHelmoEnhance ssh keys textarea with JavascriptWith multiple (or long) ssh public keys the textarea to enter them for SSH/SFTP account is not ideal.
What about a Javascript enhancement?
![image.png](/uploads/3810a8d251c01cfa6d740a19686f3d59/image.png)
![image.png](/uploads/e0571a5...With multiple (or long) ssh public keys the textarea to enter them for SSH/SFTP account is not ideal.
What about a Javascript enhancement?
![image.png](/uploads/3810a8d251c01cfa6d740a19686f3d59/image.png)
![image.png](/uploads/e0571a587a15e081bad5852b39130c83/image.png)
Patches to improve e.g. the styling are very welcome ;)https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6602Add a post-update hook script2023-11-09T09:40:17ZTill BrehmAdd a post-update hook scriptAdd a script that runs after an ISPConfig update to make customizations easier.Add a script that runs after an ISPConfig update to make customizations easier.3.2.12Till BrehmTill Brehmhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6601Unify, validate and/or robustly parse autoinstall.ini syntax2023-11-09T08:05:27ZJohan EhnbergUnify, validate and/or robustly parse autoinstall.ini syntax## Summary
Currently the syntax of autoinstall.ini varies especially for yes/no statements. This can be seen in the example file: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/docs/autoinstall_samples/autoinstall.ini.sam...## Summary
Currently the syntax of autoinstall.ini varies especially for yes/no statements. This can be seen in the example file: https://git.ispconfig.org/ispconfig/ispconfig3/-/blob/develop/docs/autoinstall_samples/autoinstall.ini.sample?ref_type=heads. Currently the value is also not validated.
Looking at the code, it is also likely that syntax mistake failures vary; I stumbled on one mistake that caused a silent hang.
## Example failing case:
```
echo "reconfigure_permissions_in_master_database=n" >> autoinstall.ini
php -q update.php --autoinstall=autoinstall.ini
<hangs forever with php process at 100% CPU>
```
The fix was obviously to instead declare `reconfigure_permissions_in_master_database=no` (note last character) but it took quite long to figure that out.
## Suggested approaches
Any combination of:
- Unify syntax
- Add validator function
- Pre-parse using the common [Yy]* and [Nn]* approach