ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2024-03-07T20:49:16Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6661Update gitignore2024-03-07T20:49:16ZMichaelUpdate gitignoreFor some reason patch command related excludes (*.rej, *.orig) have been removed.
Related push request coming...For some reason patch command related excludes (*.rej, *.orig) have been removed.
Related push request coming...3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6652gitignore file does not support VS IDE2024-02-27T20:57:16ZHairygitignore file does not support VS IDE## Summary
The gitignore file does not contain any support for using Visual Studio IDE.
Developers should be able to use VS IDE.
## Environment
Visual Studio 2022 Community
## Proposed fix
I can fix this issue by adding the following ...## Summary
The gitignore file does not contain any support for using Visual Studio IDE.
Developers should be able to use VS IDE.
## Environment
Visual Studio 2022 Community
## Proposed fix
I can fix this issue by adding the following lines to the gitignore file, at a minimum:
```
# Visual Studio IDE cache/options directory
.vs/
```
## Related log entries
issue-add-vs-ide-support-to-gitignore3.2.12https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6637DNS import, add external NS as default2024-02-15T11:42:55ZHelmoDNS import, add external NS as defaultWhen the DNS zone importer adds default dns records it only can add servers managed by ispconfig.
But my slave dns is not managed by ispconfig, so I'd like to add a field for extra nameservers.When the DNS zone importer adds default dns records it only can add servers managed by ispconfig.
But my slave dns is not managed by ispconfig, so I'd like to add a field for extra nameservers.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6636DNS import, option to ignore NS records2024-02-15T11:42:55ZHelmoDNS import, option to ignore NS recordsWhen importing a DNS zone it will often be in a migration scenario where the zone should get a new NS record anyway.
I'm adding a checkbox to ignore any NS records in the file, and let the import create default NS records.When importing a DNS zone it will often be in a migration scenario where the zone should get a new NS record anyway.
I'm adding a checkbox to ignore any NS records in the file, and let the import create default NS records.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6647Avoid errors on zone delete2024-02-15T08:21:45ZHelmoAvoid errors on zone deleteWhen I delete a DNS zone I often get warnings mailed.
This is because named-checkzone is ran for every rr being deleted, and in the end the NS records are missing.
```
WARNING - Reason for Bind restart failure: zone example.com/IN: has...When I delete a DNS zone I often get warnings mailed.
This is because named-checkzone is ran for every rr being deleted, and in the end the NS records are missing.
```
WARNING - Reason for Bind restart failure: zone example.com/IN: has no NS records
zone example.com/IN: not loaded due to errors.
```
The message itself is also a copy/paste bug, at that point it's not yet restarting bind. It's `named-checkzone`.
I'd like to pass on a flag from dns_soa_del.php to indicate that we're deleting a whole soa.
Let me know if this method is suitable, or if you see a better way.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6646Make client domains searchable2024-02-11T12:31:11ZHelmoMake client domains searchableThe data from the domains module does not show up in the search results.
I understand that there was hardly a use for it... but combined with #6645 I think it would make sense for me to include them.
![image](/uploads/00fa5b7533edebd6c...The data from the domains module does not show up in the search results.
I understand that there was hardly a use for it... but combined with #6645 I think it would make sense for me to include them.
![image](/uploads/00fa5b7533edebd6c9ea7513605c8e7d/image.png)3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6645Delete button on (Web) Domain and SOA edit form2024-02-11T12:29:58ZHelmoDelete button on (Web) Domain and SOA edit formSimilar to my MR !1362 I'd like to also add optional delete buttons to the Web Domain and SOA edit pages.Similar to my MR !1362 I'd like to also add optional delete buttons to the Web Domain and SOA edit pages.3.2.12HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6621Logs showing localhost (127.0.0.1) instead of HTTP_X_FORWARDED_FOR when using...2024-01-09T21:31:11ZTim de BoerLogs showing localhost (127.0.0.1) instead of HTTP_X_FORWARDED_FOR when using a proxy to ISPconfig## Summary
When using a proxy Vhost in front of the ISPconfig control panel, the logs shows;
`Successful login for user 'username' from 127.0.0.1 at 2023-12-11 19:17:16 with session ID <randomID>`
## Steps to reproduce
1. Create a Vh...## Summary
When using a proxy Vhost in front of the ISPconfig control panel, the logs shows;
`Successful login for user 'username' from 127.0.0.1 at 2023-12-11 19:17:16 with session ID <randomID>`
## Steps to reproduce
1. Create a Vhost that proxies the `:8080` ISPconfig
2. Login via the proxied version
3. Watch `/var/log/ispconfig/auth.log`
## Correct behaviour
It should show the following;
`Successful login for user 'username' from X.X.X.X at 2023-12-11 19:17:16 with session ID <randomID>`, where `X.X.X.X` is the real IP.
## Environment
Server OS + version: Debian 11\
ISPConfig version: 3.2.11p1
## Proposed fix
Use `$_SERVER['HTTP_X_FORWARDED_FOR']` when set.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/5236Reverse proxy to ispconfig on port 8080 does not work due cookie storage problem2023-12-13T20:51:05ZRajko AlbrechtReverse proxy to ispconfig on port 8080 does not work due cookie storage problemI tried to setup a reverse proxy for `config.mydomain.de` pointing to `localhost:8080`. Login page appears, enter credentials and submit. Login page appears again. So usage of ispconfig via reverse proxy isn't possible.
This is the snip...I tried to setup a reverse proxy for `config.mydomain.de` pointing to `localhost:8080`. Login page appears, enter credentials and submit. Login page appears again. So usage of ispconfig via reverse proxy isn't possible.
This is the snippet I use:
```
SSLProxyEngine On
SSLProxyVerify none
SSLProxyCheckPeerCN off
SSLProxyCheckPeerName off
SSLProxyCheckPeerExpire off
ProxyPass / https://localhost:8080/
ProxyPassReverse / https://localhost:8080/
```
## correct behaviour
It should work as accessing it via 8080
## environment
Happens with nginx and apache.
The reason is line 73 in `app.inc.php`: You assign the `SERVER_NAME` to `$cookie_domain`, which is in that case `localhost`.
I think it was made for CSRF protection, but IMHO this is the wrong way. For CSRF you should send an extra CSRF-Token with each post and the cookiedomain should be blank (browser bind it themself to called domain). this is the way, application servers like Ruby on Rails or tomcat and php software like wordpress and so on do it.
Alternative check for `$_SERVER['HTTP_X_FORWARDED_SERVER']`, too.
The current way is no real protection agains CSRF (realy) and another reason does not exist for that I think.
Alternative you may give an option for admins "forbid proxy redirection to ispconfig panel" which enables the current behaviour and for those don't want it, eg, want access it via there own domain name (or can not use port 8080 due firewall restrictions) may let it unchecked and `$cookie_domain` is not set this hard way.
rewrite line
```php
$cookie_domain = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']);
```
to
```php
$cookie_domain = '';
```
makes our resellers happy 'cause them can use snippet above.3.1.14https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6618Remove accidental quotes around a DNS record.2023-12-10T17:57:16ZHelmoRemove accidental quotes around a DNS record.I had someone copy/pasting dns data ... which accidentally included `"`'s around it.
This did not resolve as expected. A simple patch solves that.I had someone copy/pasting dns data ... which accidentally included `"`'s around it.
This did not resolve as expected. A simple patch solves that.HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6542Feature: shortcut do copy e-mail address2023-12-09T21:53:19ZLucas SchatzFeature: shortcut do copy e-mail addressIn the "Email Maibox" menu, it would be useful to have a button to easily copy the e-mail of the user, something like this:
![image](/uploads/7ff2db141a0cfd637fe13738a4dfb03a/image.png)In the "Email Maibox" menu, it would be useful to have a button to easily copy the e-mail of the user, something like this:
![image](/uploads/7ff2db141a0cfd637fe13738a4dfb03a/image.png)https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/2331PureFTPD RSA Key generation2023-12-03T21:20:06ZJasmine IwanekPureFTPD RSA Key generationThe ISPConfig installer makes HTTPS keys for the interface if requested and for postfix/dovecot, it would be nice if it asked the user if they wanted to make a cert for PureFTPD as well.The ISPConfig installer makes HTTPS keys for the interface if requested and for postfix/dovecot, it would be nice if it asked the user if they wanted to make a cert for PureFTPD as well.https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/2997Review mailman configuration2023-12-03T21:18:28ZTill BrehmReview mailman configurationhttp://www.howtoforge.com/forums/showthread.php?p=304381#post304381http://www.howtoforge.com/forums/showthread.php?p=304381#post304381https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/3057Add option to enable/disable certian apache and php functions by the client2023-12-03T21:17:53ZTill BrehmAdd option to enable/disable certian apache and php functions by the clienthttp://www.howtoforge.de/forum/feature-requests-14/kunde-kann-features-aktivieren-deaktivieren-7904/http://www.howtoforge.de/forum/feature-requests-14/kunde-kann-features-aktivieren-deaktivieren-7904/https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/3119add symlinks to ispserver.crt for postfix and pure-FTP2023-12-03T21:14:27Zbaxadd symlinks to ispserver.crt for postfix and pure-FTPTo ease configuration it would be appropriate to add symlinks to postfix' and pure-FTP's directory to the ISPConfig3 key and certificate like in this tutorial:
http://www.howtoforge.com/securing-your-ispconfig-3-installation-with-a-free-...To ease configuration it would be appropriate to add symlinks to postfix' and pure-FTP's directory to the ISPConfig3 key and certificate like in this tutorial:
http://www.howtoforge.com/securing-your-ispconfig-3-installation-with-a-free-class1-ssl-certificate-from-startssl-p2https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/3643Rewrite MongoDB Plugin for php 5.2 /5.3 compatibility2023-12-03T21:14:12ZTill BrehmRewrite MongoDB Plugin for php 5.2 /5.3 compatibilityRewrite MongoDB Plugin for php 5.2 /5.3 compatibilityRewrite MongoDB Plugin for php 5.2 /5.3 compatibilityhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/3269web application post delete procedure2023-12-03T21:13:24ZNickweb application post delete procedureAfter I delete "one button press install", such as wordpress from a root site directory, script removes all - robots.txt, index.html, .htaccess..
may be add a template folder for a copying in to site directory after delete application pr...After I delete "one button press install", such as wordpress from a root site directory, script removes all - robots.txt, index.html, .htaccess..
may be add a template folder for a copying in to site directory after delete application procedure?https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/3777Improvements for php-fpm reload code2023-12-03T21:12:17ZTill BrehmImprovements for php-fpm reload codeThank you to Dominik for providing this code.
In der web_module.inc.php gaaaaanz unten vor dem return $retval folgenden Block rein:
// Now test if restart has hung up and do a restart instead of reload
if (($init_script) && ($action =...Thank you to Dominik for providing this code.
In der web_module.inc.php gaaaaanz unten vor dem return $retval folgenden Block rein:
// Now test if restart has hung up and do a restart instead of reload
if (($init_script) && ($action == 'reload') && ($init_script != $conf['init_scripts'].'/'.$web_config['php_fpm_init_script'])) {
$path_parts = pathinfo($init_script);
$childcnt = exec('echo $(pgrep -c -P$(</opt/'.str_replace('-fpm', '', $path_parts['basename']).'/var/run/php-fpm.pid))');
// Count child-process number must be greater than 2
// 2 is the default process child-count (pm.start_servers = 2) -> see php-fpm.conf
// if it is only 2, then restart is also ok, because no webpages on it
if ($childcnt <= 2) {
$initcommand = $app->system->getinitcommand($path_parts['basename'], 'restart', $path_parts['dirname']);
$retval = array('output' => '', 'retval' => 0);
exec($initcommand.' 2>&1', $retval['output'], $retval['retval']);
$app->log("Restarting php-fpm after reload not worked: $initcommand", LOGLEVEL_DEBUG);
}
unset($childcnt);
}
-------------------------------
Außerdem - beim den bisherigen Ausnahmen schlage ich vor die Zeile 261 (master-Stand)
if($action == 'reload') {
mit einem "else" anfangen zu lassen -> sonst läuft es bei ner reload-Action die schon in der ersten If-Abfrage drin war durch den zweiten Block auch noch durch... und das Init-Command im zweiten If sollte so aussehen:
$initcommand = $app->system->getinitcommand($path_parts['basename'], 'restart', $path_parts['dirname']);
weil das was aktuell drin steht startet einfach nur nochmal den System-FPM-Dienst statt dem Versionsspezifischen wofür es eigentlich da sein sollte....Planned featureshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/2443Tabs in upper menu get reordered automatically2023-12-03T21:09:24ZTill BrehmTabs in upper menu get reordered automaticallyTabs in upper menu get reordered automatically
http://www.howtoforge.com/forums/showthread.php?t=60698Tabs in upper menu get reordered automatically
http://www.howtoforge.com/forums/showthread.php?t=60698https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/2378Patch that adds a email field to web form2023-12-03T21:08:47ZTill BrehmPatch that adds a email field to web formhttp://www.howtoforge.de/forum/entwicklerforum-15/patch-einstellbarer-absender-php-scripten-6515/
The patch has to be rewritten so that the field is added on the options tab instead of the first tab.http://www.howtoforge.de/forum/entwicklerforum-15/patch-einstellbarer-absender-php-scripten-6515/
The patch has to be rewritten so that the field is added on the options tab instead of the first tab.