ISPConfig 3 issueshttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues2023-10-21T15:52:28Zhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6518Remove default RBL entry for Spamhaus2023-10-21T15:52:28ZThomRemove default RBL entry for SpamhausWe should remove the default RBL Spamhaus (and maybe replace it with a alternative) to prevent non-working systems due to Spamhaus usage restrictions.We should remove the default RBL Spamhaus (and maybe replace it with a alternative) to prevent non-working systems due to Spamhaus usage restrictions.3.2.12ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6512Hide empty dashlets2023-06-01T13:01:18ZHelmoHide empty dashletsAs a result of #6505 I noticed that the summation gives 'NAN' where there are no rows to show.
![image](/uploads/98e3564073793759834f7af5da675c63/image.png)
That made me think, why do we show e.g. the mailquota table at all on a server...As a result of #6505 I noticed that the summation gives 'NAN' where there are no rows to show.
![image](/uploads/98e3564073793759834f7af5da675c63/image.png)
That made me think, why do we show e.g. the mailquota table at all on a server that does no mail hosting.3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6510Improve verbosity when an error occurs during replication2023-06-01T13:01:46ZMichaelImprove verbosity when an error occurs during replicationFollow up to the discussion: https://forum.howtoforge.com/threads/uncaught-mysqli_sql_exception-data-truncated-for-column-warnvirusrecip-at-row-1.90116Follow up to the discussion: https://forum.howtoforge.com/threads/uncaught-mysqli_sql_exception-data-truncated-for-column-warnvirusrecip-at-row-1.901163.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6483Improve client circle page2023-04-21T20:46:09ZblinkenboxImprove client circle pageFor us it is not very convenient to have only the client names to distinguish them on a "Client Circle" page. It would be much better to have something like "company_name (firstname name)". Also it would be better to have a line for each...For us it is not very convenient to have only the client names to distinguish them on a "Client Circle" page. It would be much better to have something like "company_name (firstname name)". Also it would be better to have a line for each client. Since we have some clients it would be nice to change the order to:
1. Circle Name
2. Description
3. Active
4. Clients/Resellers
I did this **first solution** by changing the template and sql-query and I can easily create a merge request for this.
![Screenshot_circles](/uploads/499c2b3c5722168d335e19f8a1638855/Screenshot_circles.png)
Maybe it would be even better to have a proper Table with columns. So the head fields are clickable for sorting and maybe have a search:
| member | company name | first name | name |
| ------ | ------ | ------ | ------ |
| [x]| company1 | firstname1 | name1 |
| [ ]| company2 | firstname2 | name2 |
For this **second solution** I need to study more ispconfig internals. As far as I can see the _normal_ tables in ispconfig have a database table as source. This is not the case here. If someone could point me to a similar table in ispconfig it would be easier for me to do the second solution.
My questions:
- Is it OK, to change the page at all?
- Shall I create a merge request for the first solution?
- Can anyone give me a hint for the second solution?
- Ideas for even better solutions?3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6476API call to set DNSSEC algorithm and activate it.2023-05-03T12:38:53ZTomAPI call to set DNSSEC algorithm and activate it.Here a patch to add a function to activate DNSSec and adjust the algorithm.
```
--- interface/lib/classes/remote.d/dns.inc.php.orig 2023-03-09 14:03:11.406869756 +0100
+++ interface/lib/classes/remote.d/dns.inc.php 2023-03-10 12:41:29.3...Here a patch to add a function to activate DNSSec and adjust the algorithm.
```
--- interface/lib/classes/remote.d/dns.inc.php.orig 2023-03-09 14:03:11.406869756 +0100
+++ interface/lib/classes/remote.d/dns.inc.php 2023-03-10 12:41:29.308279150 +0100
@@ -845,6 +845,37 @@
}
}
+ /**
+ * Set DNSSec Algo and activate it if needed.
+ *
+ * @param int session id
+ * @param int client id
+ * @param string algorithm 'NSEC3RSASHA1', 'ECDSAP256SHA256' or 'NSEC3RSASHA1,ECDSAP256SHA256' string
+ * @param boolean update serial
+ *
+ * @author Tom Albers <kovoks@kovoks.nl> KovoKs B.V. 2023
+ */
+ public function dns_zone_set_dnssec($session_id, $client_id, $primary_id, $algo, $update_serial=false) {
+ global $app;
+ if(!$this->checkPerm($session_id, 'dns_zone_set_status')) {
+ throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
+ return false;
+ }
+
+ if(!in_array($algo, ['NSEC3RSASHA1', 'ECDSAP256SHA256', 'NSEC3RSASHA1,ECDSAP256SHA256'])) {
+ throw new SoapFault('permission_denied', 'You are not using a valid algorithm for this function.');
+ return false;
+ }
+
+ $params["dnssec_wanted"] = "Y";
+ $params["dnssec_algo"] = $algo;
+ $affected_rows = $this->updateQuery('../dns/form/dns_soa.tform.php', $client_id, $primary_id, $params);
+ if($update_serial) {
+ $this->increase_serial($session_id, $client_id, ["zone" => $primary_id]);
+ }
+ return $affected_rows;
+ }
+
private function increase_serial($session_id, $client_id, $params) {
global $app;
if(!isset($params['zone']) && isset($params['dns_rr_id'])) {
```3.2.10ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6451Selecting a dnssec algorithm should imply wanting to sign the zone2023-03-09T10:04:18ZHelmoSelecting a dnssec algorithm should imply wanting to sign the zoneJust a convenience thingy ... no need to click on two checkboxes.
Just like when you click on 'Let's Encrypt SSL' we also check the 'SSL' checkbox.
![image](/uploads/8facb30e404333fdf64f0ec4dfe5f7af/image.png)Just a convenience thingy ... no need to click on two checkboxes.
Just like when you click on 'Let's Encrypt SSL' we also check the 'SSL' checkbox.
![image](/uploads/8facb30e404333fdf64f0ec4dfe5f7af/image.png)3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6450Show DNSSEC status in soa list2023-03-08T16:49:43ZHelmoShow DNSSEC status in soa listCan we add an icon in the soa list to show that a dns zone is DNSsec signed?
I propose https://fontawesome.com/v4/icon/key
![image](/uploads/039909a8696b94fa1a1179c421dbac63/image.png)Can we add an icon in the soa list to show that a dns zone is DNSsec signed?
I propose https://fontawesome.com/v4/icon/key
![image](/uploads/039909a8696b94fa1a1179c421dbac63/image.png)3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6449Show mail_domain status in list on mail_user_edit2023-03-08T16:49:35ZHelmoShow mail_domain status in list on mail_user_editYou can create mailboxes on an inactive mail_domain, but it's nice to be reminded of that status.
![image](/uploads/1e1ea8bba2d81580b2d7fe7a0a37b6cb/image.png)
What about adding `(inactive)` in the list?
I also looked at using a font-...You can create mailboxes on an inactive mail_domain, but it's nice to be reminded of that status.
![image](/uploads/1e1ea8bba2d81580b2d7fe7a0a37b6cb/image.png)
What about adding `(inactive)` in the list?
I also looked at using a font-awsone icon but that gets striped out by the chosen JS lib.3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6445Move mailbox cleanup cronjobs to be included in ISPConfig main cronjobs2023-05-26T07:29:12ZThomMove mailbox cleanup cronjobs to be included in ISPConfig main cronjobsWe don't want a third separate cronjob, so we need to clean it up and move it to the main cronjobs.We don't want a third separate cronjob, so we need to clean it up and move it to the main cronjobs.3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6435Updating a slave server should not ask for SQL root password2023-04-14T12:24:38ZHelmoUpdating a slave server should not ask for SQL root passwordWhen using the standard update script on a slave server it asks for `MySQL master server root password` when in most cases it will remain unused.
Only when you confirm the `Reconfigure Permissions in master database?` question do we do o...When using the standard update script on a slave server it asks for `MySQL master server root password` when in most cases it will remain unused.
Only when you confirm the `Reconfigure Permissions in master database?` question do we do operations that need more privileges then the normal `$conf['dbmaster_user']` account.
I propose to move the free_query inside the if block.3.2.10HelmoHelmohttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6399add mail_relay_domain API functions2023-01-29T20:56:20ZPyte Cadd mail_relay_domain API functionsAdd functions for mail_relay_domain to the remote apiAdd functions for mail_relay_domain to the remote api3.2.10https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6381Limited PHP upload_max_filesize and post_max_size for apps vhost/pool2022-09-29T15:02:13ZJudah - MWLimited PHP upload_max_filesize and post_max_size for apps vhost/poolThe NGINX apps vhost explicitly sets `client_max_body_size 100M`, but the apps can't take advantage of that because they still depend on what the user has specified in `/etc/php.ini` which defaults to `2M`.
For example when trying to up...The NGINX apps vhost explicitly sets `client_max_body_size 100M`, but the apps can't take advantage of that because they still depend on what the user has specified in `/etc/php.ini` which defaults to `2M`.
For example when trying to upload an SQL DB dump in PHPMyAdmin:
![image](/uploads/8438a97cc6beafa1ad9d39e6b194e981/image.png)
I suggest the following PHP option overrides in the apps pool:
```php
php_admin_value[post_max_size] = 100M;
php_admin_value[upload_max_filesize] = 100M;
```
Someone who uses apache should also investigate if `server/conf/apache_apps.vhost.master` should be modified to increase the max body size to match the NGINX configuration.3.2.9Judah - MWJudah - MWhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6372Add an option to disable automatic creation of CAA record on issuing LE2022-08-19T13:11:48ZMichaelAdd an option to disable automatic creation of CAA record on issuing LEFor reference: https://forum.howtoforge.com/threads/prevent-caa-records-from-lets-encrypt.89113For reference: https://forum.howtoforge.com/threads/prevent-caa-records-from-lets-encrypt.891133.2.9MichaelMichaelhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6370Show user info in datalog list view2022-08-15T22:32:59ZMichaelShow user info in datalog list viewFor QOL reasons, show the user in the Datalog who performed actions.For QOL reasons, show the user in the Datalog who performed actions.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6335Some PHP-FPM config seems to be missing in apache2 vhost template2022-09-06T14:45:24ZGuillaume SubironSome PHP-FPM config seems to be missing in apache2 vhost templateI would have prefer to make a pull request but it seems I am not allowed to fork the projet.
## Summary
On Debian 11, PHP requests are not passed to PHP-FPM when DocumentRoot starts with `/var/www/foo.com/web` instead of `/var/www/clie...I would have prefer to make a pull request but it seems I am not allowed to fork the projet.
## Summary
On Debian 11, PHP requests are not passed to PHP-FPM when DocumentRoot starts with `/var/www/foo.com/web` instead of `/var/www/clients/client1/web1/web`
## Steps to reproduce
- Check that mod-fastcgi is not enabled in apache2
- Set the site in PHP-FPM
- In Apache Directives, add `DocumentRoot {DOCROOT}`
- PHP files will be returned as text
- Set the site in Fast-CGI, it will work again
- Set the site in PHP-FPM, it will not work again…
## Environment
Server OS + version: Debian 11, Apache2.4
ISPConfig version: 3.2.8p1
Software version of the related software: Apache/2.4.53 (Debian)
Package libapache2-mod-fastcgi is not installed, mod-fastcgi is not enabled
## Proposed fix
In `server/conf/vhost.conf.master`, I believe the blocks in lines 411 and 421 should be deduplicated to add `<Directory {tmpl_var name='web_document_root_www'}>`. This double block seems to be present everywhere (lines 377-384 for example), but not in FPM use_tcp and use_socket configs.
Thank you.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6334Delete Client message should include client name for verification2022-08-15T22:35:20ZJeff NewmanDelete Client message should include client name for verificationISPC 3.2.8
just went to delete a client (did not need). There is a popup window with an "are you sure" message/alert, and then there's a verification web page to again verify deletion.
The issue - neither of these repeat or indicate t...ISPC 3.2.8
just went to delete a client (did not need). There is a popup window with an "are you sure" message/alert, and then there's a verification web page to again verify deletion.
The issue - neither of these repeat or indicate the name of the item being deleted. This is also true for other delete functions. It would be nice if the messages included identifying information indicating what the asset is that will be deleted - it's possible that the wrong thing was clicked on, but that wouldn't be known at that last step.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6332API to get mail user details for all account that belong to a client.2022-08-15T22:33:14ZHelmoAPI to get mail user details for all account that belong to a client.I'm missing an mail_user_get_all_by_client api function.I'm missing an mail_user_get_all_by_client api function.3.2.9https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6317Updated Italian translation (attached)2022-03-31T10:36:45ZTill BrehmUpdated Italian translation (attached)Attached is an updated Italian translation. Thanks to Aldo for providing the update.
[it.lng](/uploads/4dbb6477a7abd3211658eab355f27ee2/it.lng)Attached is an updated Italian translation. Thanks to Aldo for providing the update.
[it.lng](/uploads/4dbb6477a7abd3211658eab355f27ee2/it.lng)3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6314Only add Mailman related config to the Postfix config if Mailman is installed2022-09-30T19:05:22ZThomOnly add Mailman related config to the Postfix config if Mailman is installedCurrently, in all Postfix configurations, there are references to Mailman, e.g. for the transport. We should only put that in there if Mailman is installed. This will prevent issues such as https://www.howtoforge.com/community/threads/af...Currently, in all Postfix configurations, there are references to Mailman, e.g. for the transport. We should only put that in there if Mailman is installed. This will prevent issues such as https://www.howtoforge.com/community/threads/after-migrate-from-debian-10-to-11-i-cant-use-an-email-that-existing-in-mailing-list.88681/3.2.9ThomThomhttps://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6313Add warning to update script when incorrect PHP version is used as default2022-11-01T12:53:35ZThomAdd warning to update script when incorrect PHP version is used as defaultAdd a warning to the update script that the default PHP version is not in line with the OS default. Eventually offer to fix this?Add a warning to the update script that the default PHP version is not in line with the OS default. Eventually offer to fix this?3.2.9ThomThom