Major Let'sEncrypt certification issue in git-master (might not be in 3.1 stable) affecting ISPC updates
@tbrehm I wrote an email to you but I think I elaborated the issue.
LE-Certs are created with $domain = $data['new']['domain'];
instead of ssl_domain. in 3.1 stable that must have been ssl_domain.
Well the change is a wise one as LE always reissues the cert to the CN if it exists which results in an error if you change the SSL domain as ISPC can not find the ccert under the new path then (as LE reissued the old one).
So what is the issue?
Simple: If someone did not use 'domain' as 'ssl_domain' before updating the a more recent verison (currently the master branch) this will result in a loss of SSL-functionality for website using LE-Certificates where ssl_domain != domain
In my opinion eighter the installer should take care of this and remove and reissue affected LE-Certificates when updating ISPC or the integration has to be able to handle an "old path" - or even better if possible tell certbot where to store the cert files?!
However this should definitely be solved before an official release of the new LE integration!
This took me almost 3 hours of testing and code-reading now...
I hope I have not missed some important part. I did not cross-check this with 3.1 stable code but I could solve my issue by using ssl_domain instead. But this leads to an issue when chngt the ssl domain then vice versa.
I would suggest to keep the "domain" variant and disable or hide the complete SSL-Tab when LE is active to not confuse the end-user.