diff --git a/docs/Remote_API_docs.txt b/docs/Remote_API_docs.txt index a11c78dd496939b3cee19c25cef68ce88bdf57b3..6f1c4fdb66717e4ce1fc7d1aadc8028f7c2026c1 100644 --- a/docs/Remote_API_docs.txt +++ b/docs/Remote_API_docs.txt @@ -1,3 +1,3 @@ -The remote API documentation is in the remote_client/API-docs subfolder. \ No newline at end of file +The remote API documentation is in the remoting_client/API-docs subfolder. diff --git a/interface/lib/classes/tools_sites.inc.php b/interface/lib/classes/tools_sites.inc.php index 0fd5963ea023e5d1df4f53da8c3e3ccab443494c..3400c5b708097d837a6880881b1e4a064d9fdd5d 100644 --- a/interface/lib/classes/tools_sites.inc.php +++ b/interface/lib/classes/tools_sites.inc.php @@ -47,7 +47,7 @@ class tools_sites { $name=str_replace('['.$keyword.']', $this->getClientID($dataRecord), $name); break; case 'DOMAINID': - $name=str_replace('['.$keyword.']', $dataRecord['parent_domain_id'], $name); + $name=str_replace('['.$keyword.']', $dataRecord['parent_domain_id'] ? $dataRecord['parent_domain_id'] : '[DOMAINID]', $name); break; } } @@ -92,7 +92,7 @@ class tools_sites { } elseif(isset($dataRecord['sys_groupid'])) { $client_group_id = $dataRecord['sys_groupid']; } else { - $client_group_id = 0; + return '[CLIENTNAME]'; } } @@ -119,7 +119,7 @@ class tools_sites { } elseif(isset($dataRecord['sys_groupid'])) { $client_group_id = $dataRecord['sys_groupid']; } else { - $client_group_id = 0; + return '[CLIENTID]'; } } $tmp = $app->db->queryOneRecord("SELECT client_id FROM sys_group WHERE groupid = " . $app->functions->intval($client_group_id)); diff --git a/interface/web/mail/mail_domain_dkim_create.php b/interface/web/mail/mail_domain_dkim_create.php index 2a486a7db71e588540ecca686d2d6c83acbdf086..0f636b12db63306c504abd822bf56ff482aefec4 100644 --- a/interface/web/mail/mail_domain_dkim_create.php +++ b/interface/web/mail/mail_domain_dkim_create.php @@ -80,7 +80,7 @@ function get_public_key($private_key) { require_once('../../lib/classes/validate_dkim.inc.php'); $validate_dkim=new validate_dkim (); if($validate_dkim->validate_post('private',$private_key)) { /* validate the $_POST-value */ - exec('echo '.escapeshellarg($private_key).'|openssl rsa -pubout -outform PEM',$pubkey,$result); + exec('echo '.escapeshellarg($private_key).'|openssl rsa -pubout -outform PEM 2> /dev/null',$pubkey,$result); $public_key=pub_key($pubkey); } else { $public_key='invalid key'; @@ -92,8 +92,8 @@ $_POST=getRealPOST(); switch ($_POST['action']) { case 'create': /* create DKIM Private-key */ - exec('openssl rand -out /usr/local/ispconfig/server/temp/random-data.bin 4096', $output, $result); - exec('openssl genrsa -rand /usr/local/ispconfig/server/temp/random-data.bin 1024', $privkey, $result); + exec('openssl rand -out /usr/local/ispconfig/server/temp/random-data.bin 4096 2> /dev/null', $output, $result); + exec('openssl genrsa -rand /usr/local/ispconfig/server/temp/random-data.bin 1024 2> /dev/null', $privkey, $result); unlink("/usr/local/ispconfig/server/temp/random-data.bin"); foreach($privkey as $values) $private_key=$private_key.$values."\n"; break; diff --git a/interface/web/sites/database_edit.php b/interface/web/sites/database_edit.php index c392c79e5054d6c73b6d5d8cc1023fd4d9b3d8ed..22b631a15b25557b6e0a6171dcf041b62821c9ae 100644 --- a/interface/web/sites/database_edit.php +++ b/interface/web/sites/database_edit.php @@ -146,7 +146,11 @@ class page_action extends tform_actions { $app->tpl->setVar("database_name", $app->tools_sites->removePrefix($this->dataRecord['database_name'], $this->dataRecord['database_name_prefix'], $dbname_prefix)); } - $app->tpl->setVar("database_name_prefix", $app->tools_sites->getPrefix($this->dataRecord['database_name_prefix'], $dbname_prefix, $global_config['dbname_prefix'])); + if($this->dataRecord['database_name'] == "") { + $app->tpl->setVar("database_name_prefix", $dbname_prefix); + } else { + $app->tpl->setVar("database_name_prefix", $app->tools_sites->getPrefix($this->dataRecord['database_name_prefix'], $dbname_prefix, $global_config['dbname_prefix'])); + } if($this->id > 0) { //* we are editing a existing record diff --git a/interface/web/sites/database_user_edit.php b/interface/web/sites/database_user_edit.php index 75422ca09047ee1b085a326f6582da811ad2a4b2..18b46b90e1bd4d1131d8544d2a37eb43173e043b 100644 --- a/interface/web/sites/database_user_edit.php +++ b/interface/web/sites/database_user_edit.php @@ -103,8 +103,11 @@ class page_action extends tform_actions { $app->tpl->setVar("database_user", $app->tools_sites->removePrefix($this->dataRecord['database_user'], $this->dataRecord['database_user_prefix'], $dbuser_prefix)); } - - $app->tpl->setVar("database_user_prefix", $app->tools_sites->getPrefix($this->dataRecord['database_user_prefix'], $dbuser_prefix, $global_config['dbuser_prefix'])); + if($this->dataRecord['database_user'] == "") { + $app->tpl->setVar("database_user_prefix", $dbuser_prefix); + } else { + $app->tpl->setVar("database_user_prefix", $app->tools_sites->getPrefix($this->dataRecord['database_user_prefix'], $dbuser_prefix, $global_config['dbuser_prefix'])); + } parent::onShowEnd(); } diff --git a/interface/web/sites/ftp_user_edit.php b/interface/web/sites/ftp_user_edit.php index 034620168ba8bce17e4346771335e48ca74a0cce..e4dec4a19d03253ad7b0f38cd90e5db028c393f9 100644 --- a/interface/web/sites/ftp_user_edit.php +++ b/interface/web/sites/ftp_user_edit.php @@ -82,7 +82,11 @@ class page_action extends tform_actions { $app->tpl->setVar("username", $app->tools_sites->removePrefix($this->dataRecord['username'], $this->dataRecord['username_prefix'], $ftpuser_prefix)); } - $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $ftpuser_prefix, $global_config['ftpuser_prefix'])); + if($this->dataRecord['username'] == "") { + $app->tpl->setVar("username_prefix", $ftpuser_prefix); + } else { + $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $ftpuser_prefix, $global_config['ftpuser_prefix'])); + } parent::onShowEnd(); } diff --git a/interface/web/sites/shell_user_edit.php b/interface/web/sites/shell_user_edit.php index 3c72a5f843c0a25c2871da16d592630a1facb433..f0c8c3694241a8dbd32afda9b2c33e39e9f54c46 100644 --- a/interface/web/sites/shell_user_edit.php +++ b/interface/web/sites/shell_user_edit.php @@ -82,7 +82,11 @@ class page_action extends tform_actions { $app->tpl->setVar("username", $app->tools_sites->removePrefix($this->dataRecord['username'], $this->dataRecord['username_prefix'], $shelluser_prefix)); } - $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $shelluser_prefix, $global_config['shelluser_prefix'])); + if($this->dataRecord['username'] == "") { + $app->tpl->setVar("username_prefix", $shelluser_prefix); + } else { + $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $shelluser_prefix, $global_config['shelluser_prefix'])); + } if($this->id > 0) { //* we are editing a existing record diff --git a/interface/web/sites/webdav_user_edit.php b/interface/web/sites/webdav_user_edit.php index 56b019c000e1d3344ba371794e5b395f6e5f9bf1..fcea99eff20d947228ed956cb8fb015482cd64dd 100644 --- a/interface/web/sites/webdav_user_edit.php +++ b/interface/web/sites/webdav_user_edit.php @@ -81,7 +81,11 @@ class page_action extends tform_actions { $app->tpl->setVar("username", $app->tools_sites->removePrefix($this->dataRecord['username'], $this->dataRecord['username_prefix'], $webdavuser_prefix)); } - $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $webdavuser_prefix, $global_config['webdavuser_prefix'])); + if($this->dataRecord['username'] == "") { + $app->tpl->setVar("username_prefix", $webdavuser_prefix); + } else { + $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $webdavuser_prefix, $global_config['webdavuser_prefix'])); + } if($this->id > 0) { //* we are editing a existing record diff --git a/server/plugins-available/mail_plugin_dkim.inc.php b/server/plugins-available/mail_plugin_dkim.inc.php index 268c9c51fa3aae74dbf1ceddf09188128eb90dda..a74c4b8ed463b85dce3610448b34dff473b16f73 100644 --- a/server/plugins-available/mail_plugin_dkim.inc.php +++ b/server/plugins-available/mail_plugin_dkim.inc.php @@ -123,7 +123,21 @@ class mail_plugin_dkim { if (!is_dir($mail_config['dkim_path'])) { $app->log('DKIM Path '.$mail_config['dkim_path'].' not found - (re)created.', LOGLEVEL_DEBUG); - mkdir($mail_config['dkim_path'], 0750, true); + if($app->system->is_user('amavis')) { + $amavis_user='amavis'; + } elseif ($app->system->is_user('vscan')) { + $amavis_user='vscan'; + } + else { + $amavis_user=''; + } + if(!empty($amavis_user)) { + mkdir($mail_config['dkim_path'], 0750, true); + exec('chown '.$amavis_user.' /var/lib/amavis/dkim'); + unset($amavis_user); + } else { + mkdir($mail_config['dkim_path'], 0755, true); + } } if (!is_writeable($mail_config['dkim_path'])) { @@ -173,7 +187,7 @@ class mail_plugin_dkim { $app->log('Saved DKIM Private-key to '.$key_file.'.private', LOGLEVEL_DEBUG); $success=true; /* now we get the DKIM Public-key */ - exec('cat '.escapeshellarg($key_file.'.private').'|openssl rsa -pubout', $pubkey, $result); + exec('cat '.escapeshellarg($key_file.'.private').'|openssl rsa -pubout 2> /dev/null', $pubkey, $result); $public_key=''; foreach($pubkey as $values) $public_key=$public_key.$values."\n"; /* save the DKIM Public-key in dkim-dir */