Skip to content
Snippets Groups Projects
Commit 3eeed9bd authored by bpssoft's avatar bpssoft
Browse files

* Added bruteforge protection into login 

* Cleanup some stuff into login/index.php like globals
* Add errors to the lang files
parent 3fac9871
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
CODING_NOTES.php.txt
+ 3
− 1
View file @ 3eeed9bd
...@@ -7,8 +7,10 @@ Some guidelines for web development with php. ...@@ -7,8 +7,10 @@ Some guidelines for web development with php.
* error_reporting(E_ALL|E_STRICT) , yep php5 * error_reporting(E_ALL|E_STRICT) , yep php5
* Magic quotes is gone in php6, get used to it now. config = magic_quotes_gpc() Everything must be quoted * Magic quotes is gone in php6, get used to it now. config = magic_quotes_gpc() Everything must be quoted
please mark any section that nned review or work on with please mark any section that need review or work on with
// TODO // TODO
* Add documentation about access levels (public, private, protected).
* Make function / var names on the following way, first word lower, next word(s) first letter upper like. getFirstResult();
Pear coding guiidelines Pear coding guiidelines
......
install/sql/ispconfig3.sql
+ 10
− 0
View file @ 3eeed9bd
...@@ -864,3 +864,13 @@ CREATE TABLE `web_domain` ( ...@@ -864,3 +864,13 @@ CREATE TABLE `web_domain` (
-- --
-- Daten fr Tabelle `web_domain` -- Daten fr Tabelle `web_domain`
-- --
--
-- Table for attempts login
--
CREATE TABLE `attempts_login` (
`ip` varchar(12) NOT NULL,
`times` tinyint(1) NOT NULL default '1',
`login_time` timestamp NOT NULL default '0000-00-00 00:00:00'
);
interface/lib/classes/datasources_enbion.inc.php
+ 1
− 1
View file @ 3eeed9bd
...@@ -30,7 +30,7 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ...@@ -30,7 +30,7 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
class datasources_enbion { class datasources_enbion {
function get_employees() { public function get_employees() {
global $app, $conf; global $app, $conf;
$out = array(); $out = array();
......
interface/web/login/index.php
+ 98
− 68
View file @ 3eeed9bd
...@@ -32,80 +32,110 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ...@@ -32,80 +32,110 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
class login_index { class login_index {
public $status = ''; public $status = '';
private $target = ''; private $target = '';
private $app;
public function render() { private $conf;
if(isset($_SESSION['s']['user']) && is_array($_SESSION['s']['user']) && is_array($_SESSION['s']['module'])) { public function __construct()
die('HEADER_REDIRECT:'.$_SESSION['s']['module']['startpage']); {
global $app, $conf;
$this->app = $app;
$this->conf = $conf;
} }
global $app, $conf; public function render() {
$app->uses('tpl');
$app->tpl->newTemplate('form.tpl.htm'); if(isset($_SESSION['s']['user']) && is_array($_SESSION['s']['user']) && is_array($_SESSION['s']['module'])) {
die('HEADER_REDIRECT:'.$_SESSION['s']['module']['startpage']);
$error = ''; }
$this->app->uses('tpl');
//* Login Form was send $this->app->tpl->newTemplate('form.tpl.htm');
if(count($_POST) > 0) {
$error = '';
// iporting variables
$username = $app->db->quote($_POST['username']);
$passwort = $app->db->quote($_POST['passwort']); //* Login Form was send
if(count($_POST) > 0) {
if($username != '' and $passwort != '') {
$sql = "SELECT * FROM sys_user WHERE USERNAME = '$username' and ( PASSWORT = '".md5($passwort)."' or PASSWORT = password('$passwort') )"; // iporting variables
$user = $app->db->queryOneRecord($sql); $ip = $this->app->db->quote(ip2long($_SERVER['REMOTE_ADDR']));
if($user) { $username = $this->app->db->quote($_POST['username']);
if($user['active'] == 1) { $passwort = $this->app->db->quote($_POST['passwort']);
$user = $app->db->toLower($user);
$_SESSION = array(); if($username != '' and $passwort != '') {
$_SESSION['s']['user'] = $user; //* Check if there already wrong logins
$_SESSION['s']['user']['theme'] = isset($user['app_theme']) ? $user['app_theme'] : 'default'; $sql = "SELECT * FROM `attempts_login` WHERE `ip`= '{$ip}' AND `login_time` < NOW() + INTERVAL 15 MINUTE LIMIT 1";
$_SESSION['s']['language'] = $user['language']; $alreadyfailed = $this->app->db->queryOneRecord($sql);
$_SESSION["s"]['theme'] = $_SESSION['s']['user']['theme']; //* login to much wrong
if($alreadyfailed['times'] > 5) {
if(is_file($_SESSION['s']['user']['startmodule'].'/lib/module.conf.php')) { $error = $this->app->lng(1004);
include_once($_SESSION['s']['user']['startmodule'].'/lib/module.conf.php'); } else {
$_SESSION['s']['module'] = $module; $sql = "SELECT * FROM sys_user WHERE USERNAME = '$username' and ( PASSWORT = '".md5($passwort)."' or PASSWORT = password('$passwort') )";
} $user = $this->app->db->queryOneRecord($sql);
echo 'HEADER_REDIRECT:'.$_SESSION['s']['module']['startpage']; if($user) {
if($user['active'] == 1) {
exit; // User login right, so attempts can be deleted
} else { $sql = "DELETE FROM `attempts_login` WHERE `ip`='{$ip}'";
$error = $app->lng(1003); $this->app->db->query($sql);
} $user = $this->app->db->toLower($user);
} else { $_SESSION = array();
//* Incorrect login - Username and password incorrect $_SESSION['s']['user'] = $user;
$error = $app->lng(1002); $_SESSION['s']['user']['theme'] = isset($user['app_theme']) ? $user['app_theme'] : 'default';
if($app->db->errorMessage != '') $error .= '<br>'.$app->db->errorMessage != ''; $_SESSION['s']['language'] = $user['language'];
} $_SESSION["s"]['theme'] = $_SESSION['s']['user']['theme'];
} else {
//* Username or password empty if(is_file($_SESSION['s']['user']['startmodule'].'/lib/module.conf.php')) {
$error = $app->lng(1001); include_once($_SESSION['s']['user']['startmodule'].'/lib/module.conf.php');
} $_SESSION['s']['module'] = $module;
} }
if($error != ''){ echo 'HEADER_REDIRECT:'.$_SESSION['s']['module']['startpage'];
$error = '<table class="error">
<tr> exit;
<td><strong>Error:</strong><br>'.$error.'</td> } else {
</tr> $error = $this->app->lng(1003);
</table>'; }
} } else {
if(!$alreadyfailed['times'] )
{
//* user login the first time wrong
$app->tpl->setVar('error', $error); $sql = "INSERT INTO `attempts_login` (`ip`, `times`, `login_time`) VALUES ('{$ip}', 1, NOW())";
$app->tpl->setInclude('content_tpl','login/templates/index.htm'); $this->app->db->query($sql);
$app->tpl_defaults(); } elseif($alreadyfailed['times'] >= 1) {
//* update times wrong
$sql = "UPDATE `attempts_login` SET `times`=`times`+1, `login_time`=NOW() WHERE `login_time` >= '{$time}' LIMIT 1";
$this->app->db->query($sql);
}
//* Incorrect login - Username and password incorrect
$error = $this->app->lng(1002);
if($this->app->db->errorMessage != '') $error .= '<br />'.$this->app->db->errorMessage != '';
}
}
} else {
//* Username or password empty
$error = $this->app->lng(1001);
}
}
if($error != ''){
$error = '<table class="error">
<tr>
<td><strong>Error:</strong><br>'.$error.'</td>
</tr>
</table>';
}
$this->status = 'OK';
return $app->tpl->grab();
} // << end function $this->app->tpl->setVar('error', $error);
$this->app->tpl->setInclude('content_tpl','login/templates/index.htm');
$this->app->tpl_defaults();
$this->status = 'OK';
return $this->app->tpl->grab();
} // << end function
} // << end class } // << end class
......
interface/web/login/lib/lang/de.lng
+ 1
− 0
View file @ 3eeed9bd
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
$wb[1001] = "Username or Password empty."; $wb[1001] = "Username or Password empty.";
$wb[1002] = "Username or Passwort wrong."; $wb[1002] = "Username or Passwort wrong.";
$wb[1003] = "User is blocked."; $wb[1003] = "User is blocked.";
$wb[1004] = "To many wrong login's, Please retry it after 15 minutes";
......
interface/web/login/lib/lang/en.lng 0 → 100644
+ 17
− 0
View file @ 3eeed9bd
<?php
$wb[1001] = "Username or Password empty.";
$wb[1002] = "Username or Password wrong.";
$wb[1003] = "User is blocked.";
$wb[1004] = "To many wrong login's, Please retry it after 15 minutes";
?>
\ No newline at end of file
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment