Skip to content
Snippets Groups Projects
Commit b84b62a6 authored by tbrehm's avatar tbrehm
Browse files

Fixed: FS#636 - Fetchmail/Getmail configs do not delete

parent fee7a4a1
No related branches found
No related tags found
No related merge requests found
...@@ -140,12 +140,22 @@ class getmail_plugin { ...@@ -140,12 +140,22 @@ class getmail_plugin {
function delete($event_name,$data) { function delete($event_name,$data) {
global $app, $conf; global $app, $conf;
// load the server specific configuration options for getmail
$app->uses("getconf");
$getmail_config = $app->getconf->get_server_config($conf["server_id"], 'getmail');
$this->getmail_config_dir = $getmail_config["getmail_config_dir"];
$config_file_path = escapeshellcmd($this->getmail_config_dir.'/'.$data["old"]["source_server"].'_'.$data["old"]["source_username"].'.conf'); $config_file_path = escapeshellcmd($this->getmail_config_dir.'/'.$data["old"]["source_server"].'_'.$data["old"]["source_username"].'.conf');
if(stristr($config_file_path,"..") || stristr($config_file_path,"|") || stristr($config_file_path,";") || stristr($config_file_path,'$')) { if(stristr($config_file_path,"..") || stristr($config_file_path,"|") || stristr($config_file_path,";") || stristr($config_file_path,'$')) {
$app->log("Possibly faked path for getmail config file: '$config_file_path'. File is not written.",LOGLEVEL_ERROR); $app->log("Possibly faked path for getmail config file: '$config_file_path'. File is not written.",LOGLEVEL_ERROR);
return false; return false;
} }
if(is_file($config_file_path)) unlink($config_file_path); if(is_file($config_file_path)) {
unlink($config_file_path);
$app->log("Deleting file: '$config_file_path'.",LOGLEVEL_DEBUG);
} else {
$app->log("Nothing to delete: '$config_file_path'.",LOGLEVEL_DEBUG);
}
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment