This command is using features that are not POSIX-compliant (the [[ and
the || in them), that despite being supported by many shells (including
bash) are not available in dash.

Since system() runs the code with /bin/sh that is an interface defined
as only being POSIX-compliant, with no extensions, it should not presume
a specific shell in that.

Closes: #6326
Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

There may be no guarantee that `$caller[...]` is actually set, or that
either `file` or `line` are not empty.

Marius Burkard authored 3 years ago and Gwyneth Llewelyn committed 3 years ago

Good point; I'd even use `!empty($caller['file']) && !empty($caller['line'])` to save a few cycles in the (improbable) case where both _may_ be set, but empty (thus making the whole exercise pointless...).

Also, tried to clean up the code formatting according to the guidelines
_and_ added (most) entries for PHPDoc.

SSLProxyEngine is neither needed for http(s) redirects nor for non-SSL proxy configs.
Thus excluding it from these cases.

Based on a fix by Thom <thom@amsterdamtech.nl>