Disable http to https redirect when SSL is turned off (!1170) · Merge requests · ISPConfig / ISPConfig 3 · GitLab

Snippets Groups Projects

Merged Thom requested to merge thom/ispconfig3:4325-redir-off into develop 4 years ago

All threads resolved!

Closes #4325 (closed)

Edited 4 years ago by Thom

Activity

Thom marked as a Work In Progress 4 years ago

marked as a Work In Progress
Till Brehm @tbrehm · 4 years ago

Owner

Resolved 4 years ago by Thom

I don't think that we can enable/disable rewrite_enabled variable based on SSL setting, rewrites are more than just the HTTP to https redirect. With the proposed change, all rewrites would stop working on non-ssl sites, as far as I can see.

Last reply by Thom 4 years ago
Thom added 1 commit 4 years ago
added 1 commit

f0cc342e - Only disable HTTPS redirect when SSL is turned off (#4325 (closed))

Compare with previous version
Thom unmarked as a Work In Progress 4 years ago

unmarked as a Work In Progress
Thom resolved all threads 4 years ago

resolved all threads
Till Brehm added MR: Review Pending MR: Reviewed TB labels 4 years ago

added MR: Review Pending MR: Reviewed TB labels
Till Brehm changed milestone to %3.2 4 years ago

changed milestone to %3.2
Marius Burkard added MR: Reviewed MB label 4 years ago

added MR: Reviewed MB label
Till Brehm added Implemented label and removed MR: Review Pending label 4 years ago

added Implemented label and removed MR: Review Pending label
Till Brehm merged 4 years ago

merged
Till Brehm mentioned in commit 517e8dfb 4 years ago

mentioned in commit 517e8dfb

Please register or sign in to reply