Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • I ISPConfig 3
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 590
    • Issues 590
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 49
    • Merge requests 49
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISPConfig
  • ISPConfig 3
  • Merge requests
  • !1595

Avoid bashisms in the call to acme.sh

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mattia Rizzolo requested to merge mapreri/ispconfig3:6326-avoid-bashism-in-acme.sh into develop Apr 04, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

This command is using features that are not POSIX-compliant (the [[ and the || in them), that despite being supported by many shells (including bash) are not available in dash.

Since system() runs the code with /bin/sh that is an interface defined as only being POSIX-compliant, with no extensions, it should not presume a specific shell in that.

Closes #6326 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 6326-avoid-bashism-in-acme.sh