Skip to content
Snippets Groups Projects

Fix notification mail template header-body splitting

Merged Dirk Dankhoff requested to merge dirkd/ispconfig3:stable-3.0.5 into stable-3.0.5

Since file() doesn't remove "\n" from the lines read the condition $lines[$l] == '' never evaluated to true. So $mailHeaders would always contain every line from the template while $mailBody contained none of them.

Together with the bugfix of PHP#68776 [1] disallowing multiple "\n"'s & preceding "\n" in mail()'s $additionalHeaders arg this caused mails not being sent because $mailHeaders would include at least one "\n\n" which was meant to separate the mail headers from the body.

[1] https://bugs.php.net/bug.php?id=68776

Merge request reports

Checking pipeline status.

Approval is optional

Merged by avatar (Mar 29, 2025 10:18pm UTC)

Merge details

  • Changes merged into stable-3.0.5 with 2110eb58.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading