Nginx: "check config" checkbox for graceful reload not visible
For Apache the server setting check_apache_config
allows toggeling between hard webserver restart but config check and graceful webserver reload.
The nginx plugin does use the same key but the setting is hidden in the backend (display: none
).
Workaround: Remove display: none
using browser dev tools to show related checkbox
Possible fix:
- Show
check_apache_config
line in the template for both apache and nginx and remove Apache reference from translation strings - OR: Introduce new
check_nginx_config
Long term idea:
- Use non-destructive configcheck using e.g
nginx -t -c /etc/nginx/nginx.conf
instead of restart with connection check
Related code:
Use of check_apache_config
in nginx plugin: https://git.ispconfig.org/ispconfig/ispconfig3/blob/master/server/plugins-available/nginx_plugin.inc.php#L1950
Template: https://git.ispconfig.org/ispconfig/ispconfig3/blob/master/interface/web/admin/templates/server_config_web_edit.htm#L75
Is a merge request is welcome I'll do one when I have time.
This is related to #4246 (closed)