Wrong check on SQL Mode during install/update
short description
During the install/update process, ispconfig checks if the sql mode NO_ENGINE_SUBSTITUTION is set. Problem is the check itself. the install process checks if only this sql mode is set (if sql_mode == NO_ENGINE_SUBSTITUTION) instead of allowing that multiple modes are active.
correct behaviour
check if sql_mode contains NO_ENGINE_SUBSTITUTION
environment
Server OS: debian Server OS version: stretch ISPConfig version: 3.1.9
proposed fix
lib/installer_base.lib.php - Line 230
lib/update.lib.php - Line 130
if ($check_sql_mode['@@sql_mode'] != '' && !strstr($check_sql_mode['@@sql_mode'], 'NO_ENGINE_SUBSTITUTION'))