acme installation fails during fresh install or update
short description
acme.conf is not linked in site-enabled during install or update so a Let's Encrypt SSL certificate cannot be added.
Attempted on fresh debian installation.
Running ispconfig_update.sh --force
does not fix the problem but manually linking acme.conf and then running update does.
environment
Server OS: debian Server OS version: buster ISPConfig version: 3.2.3
proposed fix
Currently, the last lines in make_acme_vhost()
in install/lib/installer_base.php
(line 2775 of commit c40198b1) are
if(!@is_link($vhost_conf_enabled_dir.'' . $use_symlink)) {
symlink($vhost_conf_dir.'/' . $use_name, $vhost_conf_enabled_dir.'/' . $use_symlink);
}
I believe they should be
if(!@is_link($vhost_conf_enabled_dir.'/' . $use_symlink)) {
symlink($vhost_conf_dir.'/' . $use_name, $vhost_conf_enabled_dir.'/' . $use_symlink);
}
Also, I just wanted you to know that it did not appear that apache was reloaded or restarted after it was installed so the certificate did not work at first but that could have been caused by running force on the same version that was already installed.
references
There are many issues (like 6015 and 6030) regarding acme installation not working on install and update that have all been marked as fixed (but the above code has not changed since tag 3.2).