DNS - any not allowed in also_notify [bind restart fail]
Summary
"any" not allowed in also_notify [bind restart fail]
Steps to reproduce
- type "any" into DNS->some Zone-> Zone settings -> Also Notify Field
- try to restart bind (will fail) with
02-Oct-2023 09:34:39.046 config: error: /etc/bind/named.conf.local:4: unable to find primaries list 'any'\
02-Oct-2023 09:34:39.046 general: error: reloading configuration failed: failure
Correct behaviour
Disallow value "any" in field also-notify ("any" in xfer is ok)
Environment
Ubuntu 22.04 - ISPConfig 2.3.11
Output of the command
Proposed fix
optional, of course.\
Maybe change the check or write other function for also_notify
Index: interface/lib/classes/validate_dns.inc.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/interface/lib/classes/validate_dns.inc.php b/interface/lib/classes/validate_dns.inc.php
--- a/interface/lib/classes/validate_dns.inc.php
+++ b/interface/lib/classes/validate_dns.inc.php (date 1696240257952)
@@ -292,7 +292,7 @@
if($validator['allowempty'] != 'y') $validator['allowempty'] = 'n';
if($validator['allowempty'] == 'y' && $field_value == '') {
//* Do nothing
- } elseif ($field_value == 'any' && $field_name != ) {
+ } elseif ($field_value == 'any' && $field_name != "also_notify") {
//* Do nothing
} else {
//* Check if its a IPv4 or IPv6 address/range
Edited by Till Brehm