Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
I
ISPConfig 3
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 23
    • Merge Requests 23
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ISPConfig
  • ISPConfig 3
  • Merge Requests
  • !1272

Merged
Opened Oct 17, 2020 by Helmo@helmoReporter

Apply autofocus to form fields in ajax loaded pages

  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 4

On the login form ISPconfig had an autofocus attribute on the username field.

That is a standard and handled by the browser, but such a feature would also be useful for our forms. In most cases there is a clear 'first' field, but no field gets focus when a form is loaded via JS.

I opt to add a call in onAfterContentLoad() that mimics this behaviour. Then we can add add the autofocus attribute in each form to the field that makes most sense.

As an example I've set in now in the forms: DNS a record, user_mailbox, mail_aliasdomain

If you agree then we can add a few more autofocus attributes before merging.

The relevant html spec: https://html.spec.whatwg.org/multipage/interaction.html#the-autofocus-attribute

Edited Dec 07, 2020 by Helmo
Assignee
Assign to
Reviewer
Request review from
3.2.2
Milestone
3.2.2
Assign milestone
Time tracking
Reference: ispconfig/ispconfig3!1272
Source branch: patch-autofocus

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.